I was doing some refactoring, and kept hitting modpost errors and
warnings. It was getting a bit annoying that a lot of the modpost
messages have different formats for modules, and different quoting for
symbols, sections, and namespaces.

Clean them up a bit.

BR,
Jani.


Jani Nikula (2):
  modpost: add module as parameter to modpost_log()
  modpost: use mod_warn() and mod_error(), clean up logging

 scripts/mod/modpost.c | 112 +++++++++++++++++++++---------------------
 scripts/mod/modpost.h |   8 +--
 2 files changed, 60 insertions(+), 60 deletions(-)

-- 
2.47.3

> I was doing some refactoring, and kept hitting modpost errors and
> warnings. It was getting a bit annoying that a lot of the modpost
> messages have different formats for modules, and different quoting for
> symbols, sections, and namespaces.
> 
> Clean them up a bit.
> 
> Jani Nikula (2):
>   modpost: add module as parameter to modpost_log()
>   modpost: use mod_warn() and mod_error(), clean up logging
> 
>  scripts/mod/modpost.c | 112 +++++++++++++++++++++---------------------
>  scripts/mod/modpost.h |   8 +--
>  2 files changed, 60 insertions(+), 60 deletions(-)

Thanks, this definitely seems like a nice cleanup! I have definitely
noticed how inconsistently modpost messages were formmatted in the past.

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

-- 
Cheers,
Nathan

On Fri, 07 Aug 2026 19:29:39 +0300, Jani Nikula wrote:
> modpost: error logging cleanups
> 
> I was doing some refactoring, and kept hitting modpost errors and
> warnings. It was getting a bit annoying that a lot of the modpost
> messages have different formats for modules, and different quoting for
> symbols, sections, and namespaces.
> 
> [...]

Applied to kbuild/linux.git (kbuild-next-unstable), thanks!

[1/2] modpost: add module as parameter to modpost_log()
      https://git.kernel.org/kbuild/c/ae3de10f
[2/2] modpost: use mod_warn() and mod_error(), clean up logging
      https://git.kernel.org/kbuild/c/bbeb002c

Please look out for regression or issue reports or other follow up
comments, as they may result in the patch/series getting dropped,
reverted or modified (e.g. trailers).

Patches applied to the kbuild-next-unstable branch are accepted pending
wider testing in linux-next and any post-commit review; they will
generally be moved to the kbuild-next branch in about a week if no
issues are found.

Best regards,
-- 
Nicolas

> I was doing some refactoring, and kept hitting modpost errors and
> warnings. It was getting a bit annoying that a lot of the modpost
> messages have different formats for modules, and different quoting for
> symbols, sections, and namespaces.
> 
> Clean them up a bit.
> 
> BR,
> Jani.
> 
> Jani Nikula (2):
>   modpost: add module as parameter to modpost_log()
>   modpost: use mod_warn() and mod_error(), clean up logging
> 
>  scripts/mod/modpost.c | 112 +++++++++++++++++++++---------------------
>  scripts/mod/modpost.h |   8 +--
>  2 files changed, 60 insertions(+), 60 deletions(-)
> 
> --
> 2.47.3

Thanks for the cleanup!  Looks good to me.

Reviewed-by: Nicolas Schier <nsc@kernel.org>

-- 
Nicolas