The patch set allows to register a dmabuf to an io_uring instance for
a specified file and use it with io_uring read / write requests. The
infrastructure is not tied to io_uring and there could be more users
in the future. A similar idea was attempted some years ago by Keith [1]
(from where I borrowed a good number of changes). Later it was brough
back up to life by Tushar and Vishal.
It's an opt-in feature for files, and they need to implement a new
file operation to use it. Only NVMe block devices are supported in this
series. The user API is built on top of io_uring's "registered buffers",
where a dmabuf is registered in a special way, but after it can be used
as any other "registered buffer" with IORING_OP_{READ,WRITE}_FIXED
requests. It's created via a new file operation and the resulted map is
then passed through the I/O stack in a new iterator type. There is some
additional infrastructure to glue it together, count requests, manage
lifetime and implement invalidation.
Tushar, William, Phil as well as Kanchan, Anuj and Nitesh did a lot of
testing and experimentation on various devices with previous versions of
the patch set (separate thanks for trying it out and investigating
problems). Earlier benchmarks by Anuj for IOMMU optimisations with
udmabuf showed:
STRICT: before = 570 KIOPS, after = 5.01 MIOPS
LAZY: before = 1.93 MIOPS, after = 5.01 MIOPS
PASSTHROUGH: before = 5.01 MIOPS, after = 5.01 MIOPS
# Patch set structure:
- Patches 1-2 introduce internal API and infrastructure mediating
io_uring and target subsystem / devices
- Patches 3-8: block layer support + prep patches
- Patches 9-11 implement NVMe support
- Patches 12-16 add io_uring support and uapi. Patch 14 specifically
enables dma-buf support, the rest are preparation patches.
There are some liburing tests that can serve as an example:
git: https://github.com/isilence/liburing.git rw-dmabuf-tests-v5
url: https://github.com/isilence/liburing/tree/rw-dmabuf-tests-v5
The patches are based on Jens' for-next. Also available as a branch:
git: https://github.com/isilence/linux.git rw-dmabuf-v5
url: https://github.com/isilence/linux/tree/rw-dmabuf-v5
[1] https://lore.kernel.org/io-uring/20220805162444.3985535-1-kbusch@fb.com/
v5: - Reject dma-buf with buffered IO for raw bdev
- Add lim->max_segments bio splitting
- Add bio_iov_iter_set() helper
- Fix io_uring uapi validation
- Other minor changes
NVMe:
- Rename nvme_pci_sgl_set_data() to nvme_pci_dma_iter_set_sgl(), split
into its own prep patch.
- Convert segment walk loops to do-while.
- Drop adjacent segment coalescing logic.
- Drop first_dma/first_len from nvme_pci_dmabuf_sgl_nents()
- Remove entries > NVME_MAX_SEGS bailout; moving to the block layer.
- Factor SGL vs PRP decision making into a helper.
v4: - https://lore.kernel.org/all/cover.1785274111.git.asml.silence@gmail.com/
- Add sgl support from Anuj
- Move it under drivers/dma-buf/ and rename
- Fix mis-sized allocations
- Fix io_uring re-import mishandling
- Drop map before io_uring "task work"
- Move blk-mq callback to block_device_operations
- Convert bio flag to REQ_OP*
- Other small changes
v3: https://lore.kernel.org/io-uring/cover.1777475843.git.asml.silence@gmail.com/
- Rework io_uring registration
- Move token/map infrastructure code out of blk-mq
- Simplify callbacks: remove a separate blk-mq table, which was
mostly just forwarding calls (to nvme).
- Don't skip dma sync depending on request direction
- Fix a couple of hangs
- Rename s/dma/dmabuf/
- Other small changes
v2: - Don't pass raw dma addresses, wrap it into a driver specific object
- Split into two objects: token and map
- Implement move_notify
Anuj Gupta (2):
nvme-pci: rename nvme_pci_sgl_set_data to nvme_pci_dma_iter_set_sgl
nvme-pci: add SGL support for the dmabuf path
Pavel Begunkov (14):
dma-buf: introduce initial file I/O infrastructure
iov_iter: add iterator type for dmabuf maps
block: rename bi_bvec_done
block: always adjust bi_offset on bio_advance_iter
block: move bvec init into __bio_clone
block: introduce bio_iov_iter_set()
block: introduce dma map backed bio type
block: add dma-buf support for raw bdev
nvme-pci: implement dma-buf backed requests
io_uring/rsrc: introduce buf registration structure
io_uring/rsrc: extend buffer update
io_uring/rsrc: add uncloneable regbuf flag
io_uring/rsrc: add regbuf import flags
io_uring/rsrc: add dmabuf backed registered buffers
Documentation/block/biovecs.rst | 8 +-
block/bio.c | 33 ++-
block/blk-map.c | 2 +-
block/blk-merge.c | 45 +++-
block/blk-mq-dma.c | 2 +-
block/blk.h | 2 +-
block/fops.c | 35 ++-
drivers/block/loop.c | 2 +-
drivers/block/zloop.c | 2 +-
drivers/dma-buf/Makefile | 2 +-
drivers/dma-buf/dma-buf-io.c | 278 +++++++++++++++++++++
drivers/md/dm-io-rewind.c | 16 +-
drivers/md/dm-pcache/segment.c | 4 +-
drivers/nvdimm/btt.c | 2 +-
drivers/nvme/host/core.c | 12 +
drivers/nvme/host/nvme.h | 2 +
drivers/nvme/host/pci.c | 424 +++++++++++++++++++++++++++++++-
drivers/nvme/host/tcp.c | 2 +-
fs/btrfs/misc.h | 2 +-
include/linux/bio.h | 23 +-
include/linux/blk-mq.h | 7 +
include/linux/blk_types.h | 14 +-
include/linux/blkdev.h | 2 +
include/linux/bvec.h | 17 +-
include/linux/dma-buf-io.h | 92 +++++++
include/linux/fs.h | 2 +
include/linux/io_uring_types.h | 5 +
include/linux/uio.h | 11 +
include/uapi/linux/io_uring.h | 31 ++-
io_uring/io_uring.c | 3 +-
io_uring/net.c | 4 +-
io_uring/rsrc.c | 280 ++++++++++++++++++---
io_uring/rsrc.h | 45 +++-
io_uring/rw.c | 6 +-
lib/iov_iter.c | 31 ++-
net/ceph/messenger.c | 4 +-
36 files changed, 1321 insertions(+), 131 deletions(-)
create mode 100644 drivers/dma-buf/dma-buf-io.c
create mode 100644 include/linux/dma-buf-io.h
--
2.54.0