Revive HDMI/DP audio support for the it6505, originally posted by
Jiaxin Yu [1], rebased onto current -next with the review feedback
addressed: &client->dev is gone (the driver gained it6505->dev) and
"#sound-dai-cells" has since been added by commit 325af1bef5b9
("dt-bindings: display: bridge: it6505: Add #sound-dai-cells").
Patches 1-9 fix pre-existing bugs found during review of earlier
versions of this series; they carry Fixes: tags and are ordered first
so stable trees can pick them.
Patch 10 wires up the it6505 audio helpers via hdmi_codec_ops,
unblocking the mt8186-mt6366 sound card which references it6505 as
the I2S3 codec. Patch 11 makes hw_params succeed with no display
attached, needed when the I2S bus is shared with another codec as on
MT8186 "steelix" Chromebooks, where the speaker path must keep
working regardless of the it6505 link state.
Tested on a MT8186 (google,steelix) Chromebook: the sound card comes
up, speakers, microphone and headset jack work. HDMI/DP audio output
itself could not be tested for lack of a suitable adapter cable.
[1] https://lore.kernel.org/all/20230730180803.22570-4-jiaxin.yu@mediatek.com/
---
v5:
* patch 1: serialise notifier registration state with extcon_lock
* patch 2: also drop the runtime PM usage ref held for a connected
display; retitled
* new patches 3-7 and 9: more pre-existing fixes from v4 review
(AUX unregister symmetry, poweroff error path, IRQ status read
errors, two divisions by zero, of_node_put before use)
* patch 10 (was 4): update plugged_cb/codec_dev under mode_lock
* patches 8 and 11: no changes
v4: https://lore.kernel.org/all/cover.1784681487.git.daniel@makrotopia.org/
* patch 1: quiesce extcon notifier and IRQ before cancelling work,
initialise extcon_wq in probe; retitled
* new patch 2: disable runtime PM on remove
* patch 3 (was 2): collected Chen-Yu Tsai's Reviewed-by
* patch 4 (was 3): start out muted; mute state and cached
parameters updated under audio_lock; unregister codec after
quiesce
* patch 5 (was 4): apply audio defaults at probe time
v3: https://lore.kernel.org/all/cover.1784600387.git.daniel@makrotopia.org/
* new patches 1 and 2, fixing a pre-existing use-after-free on
remove() and an out-of-bounds read with channel_count == 0
* patch 3 (was 1): serialise audio enable/disable with audio_lock;
track mute state so the FIFO-error IRQ cannot undo a mute
* patch 4 (was 2): no changes
v2: https://lore.kernel.org/all/cover.1784561622.git.daniel@makrotopia.org/
* keep and unregister the hdmi-codec platform_device on remove
* initialise delayed_audio before registering the codec device
* cancel delayed_audio synchronously on shutdown and remove
* disable audio immediately when muting
* patch 2: drop the encoder check instead of returning 0 early
Daniel Golle (10):
drm/bridge: it6505: quiesce event sources and work on remove()
drm/bridge: it6505: balance and disable runtime PM on remove
drm/bridge: it6505: unregister DP AUX adapter on bridge detach
drm/bridge: it6505: complete poweroff even if disabling regulators
fails
drm/bridge: it6505: bail out of the IRQ handler when status reads fail
drm/bridge: it6505: avoid division by zero in pixel clock calculation
drm/bridge: it6505: avoid division by zero in audio FS debug print
drm/bridge: it6505: guard against zero channel count in audio
infoframe
drm/bridge: it6505: hold endpoint OF node reference while parsing it
drm/bridge: it6505: Don't reject audio hw_params without an encoder
Jiaxin Yu (1):
drm/bridge: it6505: Add audio support
drivers/gpu/drm/bridge/ite-it6505.c | 247 +++++++++++++++++++++-------
1 file changed, 190 insertions(+), 57 deletions(-)
base-commit: 0718283ab28bc3907e10b61a6b4be6fefa1cbb2f
--
2.55.0