[PATCH v3 09/13] mm/huge_memory: use mm instead of tlb->mm

Lorenzo Stoakes (Oracle) posted 13 patches 2 weeks ago
[PATCH v3 09/13] mm/huge_memory: use mm instead of tlb->mm
Posted by Lorenzo Stoakes (Oracle) 2 weeks ago
Reduce the repetition, and lay the ground for further refactorings by
keeping this variable separate.

Signed-off-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org>
---
 mm/huge_memory.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index c5b16c218900..673d0c4734ad 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -2338,6 +2338,7 @@ bool zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma,
 		 pmd_t *pmd, unsigned long addr)
 {
 	bool has_deposit = arch_needs_pgtable_deposit();
+	struct mm_struct *mm = tlb->mm;
 	struct folio *folio = NULL;
 	bool flush_needed = false;
 	spinlock_t *ptl;
@@ -2385,9 +2386,9 @@ bool zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma,
 
 	if (folio_test_anon(folio)) {
 		has_deposit = true;
-		add_mm_counter(tlb->mm, MM_ANONPAGES, -HPAGE_PMD_NR);
+		add_mm_counter(mm, MM_ANONPAGES, -HPAGE_PMD_NR);
 	} else {
-		add_mm_counter(tlb->mm, mm_counter_file(folio),
+		add_mm_counter(mm, mm_counter_file(folio),
 			       -HPAGE_PMD_NR);
 
 		/*
@@ -2406,7 +2407,7 @@ bool zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma,
 
 out:
 	if (has_deposit)
-		zap_deposited_table(tlb->mm, pmd);
+		zap_deposited_table(mm, pmd);
 
 	spin_unlock(ptl);
 	if (flush_needed)
-- 
2.53.0
Re: [PATCH v3 09/13] mm/huge_memory: use mm instead of tlb->mm
Posted by Baolin Wang 1 week, 6 days ago

On 3/21/26 2:07 AM, Lorenzo Stoakes (Oracle) wrote:
> Reduce the repetition, and lay the ground for further refactorings by
> keeping this variable separate.
> 
> Signed-off-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org>
> ---

LGTM.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Re: [PATCH v3 09/13] mm/huge_memory: use mm instead of tlb->mm
Posted by Suren Baghdasaryan 6 days, 8 hours ago
On Fri, Mar 20, 2026 at 10:42 PM Baolin Wang
<baolin.wang@linux.alibaba.com> wrote:
>
>
>
> On 3/21/26 2:07 AM, Lorenzo Stoakes (Oracle) wrote:
> > Reduce the repetition, and lay the ground for further refactorings by
> > keeping this variable separate.
> >
> > Signed-off-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org>
> > ---
>
> LGTM.
> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>

Reviewed-by: Suren Baghdasaryan <surenb@google.com>