[PATCH net-next 0/2] net: dsa: mxl862xx: add support for bridge offloading

Daniel Golle posted 2 patches 1 month ago
There is a newer version of this series
drivers/net/dsa/mxl862xx/mxl862xx-api.h | 171 +++++++
drivers/net/dsa/mxl862xx/mxl862xx-cmd.h |  19 +-
drivers/net/dsa/mxl862xx/mxl862xx.c     | 576 ++++++++++++++++++++++--
drivers/net/dsa/mxl862xx/mxl862xx.h     |  21 +
net/dsa/tag_mxl862xx.c                  |   2 +
5 files changed, 757 insertions(+), 32 deletions(-)
[PATCH net-next 0/2] net: dsa: mxl862xx: add support for bridge offloading
Posted by Daniel Golle 1 month ago
As a next step to complete the mxl862xx DSA driver, add support for
offloading forwarding between bridged ports to the switch hardware.

This works pretty much without any big surprises, apart from two
subtleties:
 * per-port control over flooding behavior has to be implemented by
   (ab)using a 0-rate QoS meters as stopper in lack of any better
   option.
 * STP state transition unconditionally enables learning on a port
   even if it was previously explicitely disabled (a firmware bug)

Note that as the driver is still lacking all VLAN features (which
are going to be added next), at this point some of the
bridge_vlan_aware.sh tests are failing after applying this series.

This is expected and cannot be avoided without implementing
port_vlan_filtering + port_vlan_add/del. And adding both bridge and
VLAN offloading at the same time would be too much for anyone to
review.

All other relevant selftests (including bridge_vlan_unaware.sh) are
still passing.

Daniel Golle (2):
  dsa: tag_mxl862xx: set dsa_default_offload_fwd_mark()
  net: dsa: mxl862xx: implement bridge offloading

 drivers/net/dsa/mxl862xx/mxl862xx-api.h | 171 +++++++
 drivers/net/dsa/mxl862xx/mxl862xx-cmd.h |  19 +-
 drivers/net/dsa/mxl862xx/mxl862xx.c     | 576 ++++++++++++++++++++++--
 drivers/net/dsa/mxl862xx/mxl862xx.h     |  21 +
 net/dsa/tag_mxl862xx.c                  |   2 +
 5 files changed, 757 insertions(+), 32 deletions(-)

-- 
2.53.0
Re: [PATCH net-next 0/2] net: dsa: mxl862xx: add support for bridge offloading
Posted by Daniel Golle 1 month ago
On Sat, Mar 07, 2026 at 03:29:15AM +0000, Daniel Golle wrote:
> As a next step to complete the mxl862xx DSA driver, add support for
> offloading forwarding between bridged ports to the switch hardware.
> 
> This works pretty much without any big surprises, apart from two
> subtleties:
>  * per-port control over flooding behavior has to be implemented by
>    (ab)using a 0-rate QoS meters as stopper in lack of any better
>    option.
>  * STP state transition unconditionally enables learning on a port
>    even if it was previously explicitely disabled (a firmware bug)
> 
> Note that as the driver is still lacking all VLAN features (which
> are going to be added next), at this point some of the
> bridge_vlan_aware.sh tests are failing after applying this series.
> 
> This is expected and cannot be avoided without implementing
> port_vlan_filtering + port_vlan_add/del. And adding both bridge and
> VLAN offloading at the same time would be too much for anyone to
> review.
> 
> All other relevant selftests (including bridge_vlan_unaware.sh) are
> still passing.

I forgot to add that (as expected) also test

VLAN-aware bridge with different PVIDs: Checking which packets were received

now fails in no_forwarding.sh, and will be fixed by implementing VLAN
operations in the next series.


> 
> Daniel Golle (2):
>   dsa: tag_mxl862xx: set dsa_default_offload_fwd_mark()
>   net: dsa: mxl862xx: implement bridge offloading
> 
>  drivers/net/dsa/mxl862xx/mxl862xx-api.h | 171 +++++++
>  drivers/net/dsa/mxl862xx/mxl862xx-cmd.h |  19 +-
>  drivers/net/dsa/mxl862xx/mxl862xx.c     | 576 ++++++++++++++++++++++--
>  drivers/net/dsa/mxl862xx/mxl862xx.h     |  21 +
>  net/dsa/tag_mxl862xx.c                  |   2 +
>  5 files changed, 757 insertions(+), 32 deletions(-)
> 
> -- 
> 2.53.0