[PATCH v3 1/3] dt-bindings: arm: fsl: add Variscite DART-MX91 Boards

Stefano Radaelli posted 3 patches 1 month, 1 week ago
There is a newer version of this series
[PATCH v3 1/3] dt-bindings: arm: fsl: add Variscite DART-MX91 Boards
Posted by Stefano Radaelli 1 month, 1 week ago
From: Stefano Radaelli <stefano.r@variscite.com>

Add DT compatible strings for Variscite DART-MX91 SoM and Variscite
development carrier Board.

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>
---
v2->v3:
 - Rebased the series to fix DTS apply issues.

v1->v2:
 - Ordering by hex and node name.

 Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 5716d701292c..be2b88c3d9ee 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1545,6 +1545,12 @@ properties:
           - const: phytec,imx93-phycore-som # phyCORE-i.MX93 SoM
           - const: fsl,imx93
 
+      - description: Variscite DART-MX91 based boards
+        items:
+          - const: variscite,var-dart-mx91-sonata # Variscite DART-MX91 on Sonata Development Board
+          - const: variscite,var-dart-mx91 # Variscite DART-MX91 SOM
+          - const: fsl,imx91
+
       - description: Variscite VAR-SOM-MX93 based boards
         items:
           - const: variscite,var-som-mx93-symphony
-- 
2.47.3
Re: [PATCH v3 1/3] dt-bindings: arm: fsl: add Variscite DART-MX91 Boards
Posted by Frank Li 1 month ago
From: Frank Li (AI-BOT) <frank.li@nxp.com>

This is a device tree bindings patch adding compatible strings for
Variscite DART-MX91 boards. Review follows:

> +      - description: Variscite DART-MX91 based boards
> +        items:
> +          - const: variscite,var-dart-mx91-sonata # Variscite DART-MX91 on Sonata Development Board
Line exceeds 80 characters; wrap the inline comment or move to description.

> +          - const: variscite,var-dart-mx91 # Variscite DART-MX91 SOM
Line exceeds 80 characters; same issue.

The patch itself is minimal and correct in structure. The YAML ordering
(hex then node name) is consistent with the changelog note. The compatible
strings follow the established pattern: board-specific variant, then SoM,
then fallback to fsl,imx91.

Suggestion: Move the inline comments to the description field or shorten
them to fit within 80 columns per coding-style.rst.

AI bot review and may be useless.