Hi all,
Currently, there are two helpers to match the root compatible value
against an of_device_id array:
- of_machine_device_match() returns true if a match is found,
- of_machine_get_match_data() returns the match data if a match is
found.
However, there is no helper that returns the actual of_device_id
structure corresponding to the match, leading to code duplication in
various drivers. Worse, with the plan to make of_root private[1], more
open-coded users may appear.
Hence this series adds a new helper of_machine_get_match(), which
returns the match entry, and converts several drivers to make use of it.
Note that the new wrapper comes at no cost (binary size-wise),
as the variant returning bool can be a trivial inline wrapper.
One could argue we don't even need the variant that returns bool,
as
"if (of_machine_device_match(...))" and
"if (of_machine_get_match(...))",
and
"if (!of_machine_device_match(...))" and
"if (!of_machine_get_match(...))"
are equivalent.
The return type only matters when assigning to or returning an explicit
type, like in drivers/soc/tegra/common.c:
bool soc_is_tegra(void)
{
return of_machine_device_match(tegra_machine_match);
}
Only the Renesas driver patch was tested on actual hardware.
Thanks for your comments!
[1] "[PATCH v2 0/9] soc: remove direct accesses to of_root from
drivers/soc/"
https://lore.kernel.org/20260223-soc-of-root-v2-0-b45da45903c8@oss.qualcomm.com/
Geert Uytterhoeven (7):
of: Add of_machine_get_match() helper
of: Convert to of_machine_get_match()
cpufreq: airoha: Convert to of_machine_get_match()
cpufreq: qcom-nvmem: Convert to of_machine_get_match()
cpufreq: ti-cpufreq: Convert to of_machine_get_match()
soc: qcom: pd-mapper: Convert to of_machine_get_match()
soc: renesas: Convert to of_machine_get_match()
drivers/cpufreq/airoha-cpufreq.c | 7 +------
drivers/cpufreq/qcom-cpufreq-nvmem.c | 16 ++--------------
drivers/cpufreq/ti-cpufreq.c | 12 +-----------
drivers/of/base.c | 20 ++++++--------------
drivers/soc/qcom/qcom_pd_mapper.c | 8 +-------
drivers/soc/renesas/renesas-soc.c | 2 +-
include/linux/of.h | 11 ++++++++---
7 files changed, 20 insertions(+), 56 deletions(-)
--
2.43.0
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds