This patchset provides 4 code styles fixes:

Remove empty lines between error handling.
Remove defensive txq_num check.
Use array_size instead of multiplying.
SQ use SQ_CTXT_PREF_CI_HI to improve readability.

Changes:

PATCH V01: https://lore.kernel.org/netdev/cover.1768915707.git.zhuyikai1@h-partners.com/

PATCH V02: https://lore.kernel.org/netdev/cover.1769142701.git.zhuyikai1@h-partners.com/
* Send "Fix netif_queue_set_napi queue_index parameter passing error" to net (Jakub Kicinski)

PATCH V03:
* Modify commit description to be more accurate and clear (Simon Horman)

Fan Gong (15):
  hinic3: Add command queue detailed-respone interfaces
  hinic3: Add Command Queue/Async Event Queue/Mailbox dump interfaces
  hinic3: Add chip_present_flag checks to prevent errors when card is
    absent
  hinic3: Add RX GRO and VLAN offload support
  hinic3: Add msg_send_lock for message sending concurrecy
  hinic3: Add PF device support and function type validation
  hinic3: Add PF FLR wait and timeout handling
  hinic3: Add PF/VF capability parsing and parameter validation
  hinic3: Add ethtool basic ops
  hinic3: Add ethtool queue ops
  hinic3: Add ethtool statistic ops
  hinic3: Add ethtool coalesce ops
  hinic3: Add ethtool rss ops
  hinic3: Add MTU size validation
  hinic3: Config netdev->watchdog_timeo to set nic tx timeout

 drivers/net/ethernet/huawei/hinic3/Makefile   |    1 +
 .../net/ethernet/huawei/hinic3/hinic3_cmdq.c  |  225 ++-
 .../net/ethernet/huawei/hinic3/hinic3_cmdq.h  |   15 +
 .../ethernet/huawei/hinic3/hinic3_common.h    |    1 +
 .../net/ethernet/huawei/hinic3/hinic3_csr.h   |    2 +
 .../net/ethernet/huawei/hinic3/hinic3_eqs.c   |   67 +
 .../net/ethernet/huawei/hinic3/hinic3_eqs.h   |    6 +
 .../ethernet/huawei/hinic3/hinic3_ethtool.c   | 1217 +++++++++++++++++
 .../ethernet/huawei/hinic3/hinic3_hw_cfg.c    |   53 +-
 .../ethernet/huawei/hinic3/hinic3_hw_cfg.h    |    8 +
 .../ethernet/huawei/hinic3/hinic3_hw_comm.c   |   65 +
 .../ethernet/huawei/hinic3/hinic3_hw_comm.h   |    2 +
 .../ethernet/huawei/hinic3/hinic3_hw_intf.h   |   25 +-
 .../net/ethernet/huawei/hinic3/hinic3_hwdev.c |   11 +
 .../net/ethernet/huawei/hinic3/hinic3_hwdev.h |    1 +
 .../net/ethernet/huawei/hinic3/hinic3_hwif.c  |   31 +-
 .../net/ethernet/huawei/hinic3/hinic3_irq.c   |    3 +-
 .../net/ethernet/huawei/hinic3/hinic3_lld.c   |    1 +
 .../net/ethernet/huawei/hinic3/hinic3_main.c  |   10 +
 .../net/ethernet/huawei/hinic3/hinic3_mbox.c  |   35 +-
 .../net/ethernet/huawei/hinic3/hinic3_mbox.h  |    2 +
 .../huawei/hinic3/hinic3_mgmt_interface.h     |   55 +-
 .../huawei/hinic3/hinic3_netdev_ops.c         |   76 +-
 .../ethernet/huawei/hinic3/hinic3_nic_cfg.c   |  167 +++
 .../ethernet/huawei/hinic3/hinic3_nic_cfg.h   |  219 +++
 .../ethernet/huawei/hinic3/hinic3_nic_dev.h   |   30 +
 .../ethernet/huawei/hinic3/hinic3_nic_io.h    |    4 +
 .../huawei/hinic3/hinic3_pci_id_tbl.h         |    1 +
 .../net/ethernet/huawei/hinic3/hinic3_rss.c   |  487 ++++++-
 .../net/ethernet/huawei/hinic3/hinic3_rss.h   |   19 +
 .../net/ethernet/huawei/hinic3/hinic3_rx.c    |   84 +-
 .../net/ethernet/huawei/hinic3/hinic3_rx.h    |   17 +
 .../net/ethernet/huawei/hinic3/hinic3_tx.c    |   72 +-
 .../net/ethernet/huawei/hinic3/hinic3_tx.h    |    2 +
 34 files changed, 2985 insertions(+), 29 deletions(-)
 create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_ethtool.c


base-commit: f77c7b96014471f2c39823ed9fcb42967e7d9ede
-- 
2.43.0

On 2/24/2026 9:15 PM, Fan Gong wrote:
> This patchset provides 4 code styles fixes:
>
> Remove empty lines between error handling.
> Remove defensive txq_num check.
> Use array_size instead of multiplying.
> SQ use SQ_CTXT_PREF_CI_HI to improve readability.
>
> Changes:
>
> PATCH V01: https://lore.kernel.org/netdev/cover.1768915707.git.zhuyikai1@h-partners.com/
>
> PATCH V02: https://lore.kernel.org/netdev/cover.1769142701.git.zhuyikai1@h-partners.com/
> * Send "Fix netif_queue_set_napi queue_index parameter passing error" to net (Jakub Kicinski)
>
> PATCH V03:
> * Modify commit description to be more accurate and clear (Simon Horman)

Sorry for forgetting to replace cover letter to a newer one.
We will send the next version with correct cover letter and commit contexts, and refer to
possible AI review for revisions after 24 hours.

Thanks,
Fan Gong

On Tue, 24 Feb 2026 21:43:15 +0800 Fan Gong wrote:
> Sorry for forgetting to replace cover letter to a newer one.
> We will send the next version with correct cover letter and commit contexts,
> and refer to possible AI review for revisions after 24 hours.

FWIW the AI review is here:
https://netdev-ai.bots.linux.dev/ai-review.html?id=199da9b3-7cc5-40ef-b5d0-e8073e3eb49f

The LLM timed out for one of the patches so it won't get published 
to patchwork.

Another note - could you perhaps cut this series down?
You're adding a bunch of features and:

  34 files changed, 2985 insertions(+), 29 deletions(-)

Not too bad, but I still think you'd make faster progress with
a smaller series.

On 2/26/2026 9:28 AM, Jakub Kicinski wrote:
> The LLM timed out for one of the patches so it won't get published 
> to patchwork.
>
> Another note - could you perhaps cut this series down?
> You're adding a bunch of features and:
>
>   34 files changed, 2985 insertions(+), 29 deletions(-)
>
> Not too bad, but I still think you'd make faster progress with
> a smaller series.
>

Thanks for the review. We'll split the series into smaller patchsets and
modify the code based on the reviews of Ioana, patchwork checkes and AI.

Fan gong