[PATCH v2 11/13] iio: imu: bmi323: remove unused drdy_trigger_enabled

Antoniu Miclaus posted 13 patches 6 days, 10 hours ago
[PATCH v2 11/13] iio: imu: bmi323: remove unused drdy_trigger_enabled
Posted by Antoniu Miclaus 6 days, 10 hours ago
Remove unused drdy_trigger_enabled field from bmi323_data
struct. The field is declared but never accessed in the
driver.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 drivers/iio/imu/bmi323/bmi323_core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/imu/bmi323/bmi323_core.c b/drivers/iio/imu/bmi323/bmi323_core.c
index 6bcb9a436581..f3d499423399 100644
--- a/drivers/iio/imu/bmi323/bmi323_core.c
+++ b/drivers/iio/imu/bmi323/bmi323_core.c
@@ -156,7 +156,6 @@ struct bmi323_data {
 	struct iio_mount_matrix orientation;
 	enum bmi323_irq_pin irq_pin;
 	struct iio_trigger *trig;
-	bool drdy_trigger_enabled;
 	enum bmi323_state state;
 	s64 fifo_tstamp, old_fifo_tstamp;
 	u32 odrns[BMI323_SENSORS_CNT];
-- 
2.43.0
Re: [PATCH v2 11/13] iio: imu: bmi323: remove unused drdy_trigger_enabled
Posted by Andy Shevchenko 5 days, 12 hours ago
On Mon, Feb 02, 2026 at 01:26:01PM +0200, Antoniu Miclaus wrote:
> Remove unused drdy_trigger_enabled field from bmi323_data
> struct. The field is declared but never accessed in the
> driver.

...

> struct bmi323_data {

>  	struct iio_mount_matrix orientation;
>  	enum bmi323_irq_pin irq_pin;
>  	struct iio_trigger *trig;
> -	bool drdy_trigger_enabled;

Hmm... Not directly related to your series, but with it applied it makes sense
to revisit the structure layouts as they might be rearranged to occupy less
space.

>  	enum bmi323_state state;

For example, this enum, if moved closer to irq_pin, might result in less gap on
some architectures. (Probably not, as we use long, id est 'int' sized, enums.)

In any way, `pahole` can hint about that, but as I said, it's not for this
series.

>  	s64 fifo_tstamp, old_fifo_tstamp;
>  	u32 odrns[BMI323_SENSORS_CNT];

-- 
With Best Regards,
Andy Shevchenko