[PATCH v12 3/4] net: mdio: add unlocked mdiodev C45 bus accessors

Daniel Golle posted 4 patches 1 week ago
There is a newer version of this series
[PATCH v12 3/4] net: mdio: add unlocked mdiodev C45 bus accessors
Posted by Daniel Golle 1 week ago
Add helper inline functions __mdiodev_c45_read() and
__mdiodev_c45_write(), which are the C45 equivalents of the existing
__mdiodev_read() and __mdiodev_write() added by commit e6a45700e7e1
("net: mdio: add unlocked mdiobus and mdiodev bus accessors")

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
v12: no changes
v11: no changes
v10: no changes
v9: no changes
v8: no changes
v7: no changes
v6: no changes
v5: fix indentation
RFC v4: no changes
RFC v3: no changes
RFC v2: add this patch, initial submission
---
 include/linux/mdio.h | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/include/linux/mdio.h b/include/linux/mdio.h
index 42d6d47e445b..52d94b8ae371 100644
--- a/include/linux/mdio.h
+++ b/include/linux/mdio.h
@@ -648,6 +648,19 @@ static inline int mdiodev_modify_changed(struct mdio_device *mdiodev,
 				      mask, set);
 }
 
+static inline int __mdiodev_c45_read(struct mdio_device *mdiodev, int devad,
+				     u16 regnum)
+{
+	return __mdiobus_c45_read(mdiodev->bus, mdiodev->addr, devad, regnum);
+}
+
+static inline int __mdiodev_c45_write(struct mdio_device *mdiodev, u32 devad,
+				      u16 regnum, u16 val)
+{
+	return __mdiobus_c45_write(mdiodev->bus, mdiodev->addr, devad, regnum,
+				   val);
+}
+
 static inline int mdiodev_c45_modify(struct mdio_device *mdiodev, int devad,
 				     u32 regnum, u16 mask, u16 set)
 {
-- 
2.52.0
Re: [PATCH v12 3/4] net: mdio: add unlocked mdiodev C45 bus accessors
Posted by Russell King (Oracle) 5 days, 21 hours ago
On Sun, Feb 01, 2026 at 02:25:03AM +0000, Daniel Golle wrote:
> Add helper inline functions __mdiodev_c45_read() and
> __mdiodev_c45_write(), which are the C45 equivalents of the existing
> __mdiodev_read() and __mdiodev_write() added by commit e6a45700e7e1
> ("net: mdio: add unlocked mdiobus and mdiodev bus accessors")
> 
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>

Sigh, there's too many versions of this patch series. While netdev has
a 24H period, there is also this - note the last sentence. The reason
this exists is to stop this exact problem, where ongoing discussion is
split across multiple different versions of the same series.

Resending after review
~~~~~~~~~~~~~~~~~~~~~~

Allow at least 24 hours to pass between postings. This will ensure reviewers
from all geographical locations have a chance to chime in. Do not wait
too long (weeks) between postings either as it will make it harder for reviewers
to recall all the context.

Make sure you address all the feedback in your new posting. *Do not post a new
version of the code if the discussion about the previous version is still
ongoing, unless directly instructed by a reviewer.*


-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!