This patch series enables the PMIC, voltage regulators, usb and pcie
for the OrangePi rv2 board.

Han Gao (7):
  riscv: dts: spacemit: Enable i2c8 adapter for OrangePi RV2
  riscv: dts: spacemit: Define fixed regulators for OrangePi RV2
  riscv: dts: spacemit: Define the P1 PMIC regulators for OrangePi RV2
  riscv: dts: spacemit: Enable USB3.0 on OrangePi RV2
  riscv: dts: spacemit: Update PMIC supply properties for OrangePi RV2
  riscv: dts: spacemit: Add a PCIe regulator for OrangePi RV2
  riscv: dts: spacemit: PCIe and PHY-related updates for OrangePi RV2

 .../boot/dts/spacemit/k1-orangepi-rv2.dts     | 235 ++++++++++++++++++
 1 file changed, 235 insertions(+)


base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
prerequisite-patch-id: 32d6acfcb4801407e38510b391407943e9a8ec82
prerequisite-patch-id: ae644485e1a8ead3fa7a087c8db9062c7acc14ff
prerequisite-patch-id: 605d537aa0f8387b3523786a875c76b9edfbcbb4
prerequisite-patch-id: faab9c820ac67de42c40f2c4578bb5b8753fcb71
prerequisite-patch-id: f9c4643cc99e5b9f1acc9daf1e679b95f81cee73
prerequisite-patch-id: 50138c8918218ea3b8650999bd558ed6350ed2f2
prerequisite-patch-id: f8f91e32361cc99c531170c39ed54cd1b3c5997d
prerequisite-patch-id: 475d1968c0c41895578809410c9bd8fe24997de4
prerequisite-patch-id: c40f1562f712f04578ef58472840d257a19919fe
prerequisite-patch-id: e9ef3af6c80187e6f05444704d13212d3beaf40a
prerequisite-patch-id: 7076909bb4103588b4761d175eca40bce470230f
prerequisite-patch-id: 0c859b4d131b3360875c795c6148c6176b55fb91
prerequisite-patch-id: 2ed98dc1ab0f5ed923cc252415c345dc8caf6f17
prerequisite-patch-id: 1be1a031763fac029076a768f012af31e455be66
prerequisite-patch-id: 21bb8387c946e050910440e7a7622305d46d946d
prerequisite-patch-id: f3bdc2c74b230663710086bd770a755d56cb8b9c
prerequisite-patch-id: ba6a7df5c7a2fa9ce0b8a72a9177e42a4dcdab01
prerequisite-patch-id: 33fd23112b55b5e6b1e276594826ee454afc1c7e
prerequisite-patch-id: 009a5aaff0768d90d148eb9d5d999c5098fd6d93
prerequisite-patch-id: 7e41df07cbce163a689f5dca246b98a0122d1610
-- 
2.47.3

Hi Han,

On 05:38 Sun 01 Feb     , Han Gao wrote:
> This patch series enables the PMIC, voltage regulators, usb and pcie
> for the OrangePi rv2 board.
> 
It's obvious too late for v6.20, besides this series depend on P1 PMIC
patch which haven't settled down.. Guodong is working on v3, see

https://lore.kernel.org/all/CAH1PCMYmK=cenJAvhGdZuh68fwNu-c_JJFpyztZUXvcOTv0YSg@mail.gmail.com/

> Han Gao (7):
>   riscv: dts: spacemit: Enable i2c8 adapter for OrangePi RV2
>   riscv: dts: spacemit: Define fixed regulators for OrangePi RV2
>   riscv: dts: spacemit: Define the P1 PMIC regulators for OrangePi RV2
>   riscv: dts: spacemit: Enable USB3.0 on OrangePi RV2
>   riscv: dts: spacemit: Update PMIC supply properties for OrangePi RV2
>   riscv: dts: spacemit: Add a PCIe regulator for OrangePi RV2
>   riscv: dts: spacemit: PCIe and PHY-related updates for OrangePi RV2
> 
>  .../boot/dts/spacemit/k1-orangepi-rv2.dts     | 235 ++++++++++++++++++
>  1 file changed, 235 insertions(+)
> 
> 
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> prerequisite-patch-id: 32d6acfcb4801407e38510b391407943e9a8ec82
> prerequisite-patch-id: ae644485e1a8ead3fa7a087c8db9062c7acc14ff
> prerequisite-patch-id: 605d537aa0f8387b3523786a875c76b9edfbcbb4
> prerequisite-patch-id: faab9c820ac67de42c40f2c4578bb5b8753fcb71
> prerequisite-patch-id: f9c4643cc99e5b9f1acc9daf1e679b95f81cee73
> prerequisite-patch-id: 50138c8918218ea3b8650999bd558ed6350ed2f2
> prerequisite-patch-id: f8f91e32361cc99c531170c39ed54cd1b3c5997d
> prerequisite-patch-id: 475d1968c0c41895578809410c9bd8fe24997de4
> prerequisite-patch-id: c40f1562f712f04578ef58472840d257a19919fe
> prerequisite-patch-id: e9ef3af6c80187e6f05444704d13212d3beaf40a
> prerequisite-patch-id: 7076909bb4103588b4761d175eca40bce470230f
> prerequisite-patch-id: 0c859b4d131b3360875c795c6148c6176b55fb91
> prerequisite-patch-id: 2ed98dc1ab0f5ed923cc252415c345dc8caf6f17
> prerequisite-patch-id: 1be1a031763fac029076a768f012af31e455be66
> prerequisite-patch-id: 21bb8387c946e050910440e7a7622305d46d946d
> prerequisite-patch-id: f3bdc2c74b230663710086bd770a755d56cb8b9c
> prerequisite-patch-id: ba6a7df5c7a2fa9ce0b8a72a9177e42a4dcdab01
> prerequisite-patch-id: 33fd23112b55b5e6b1e276594826ee454afc1c7e
> prerequisite-patch-id: 009a5aaff0768d90d148eb9d5d999c5098fd6d93
> prerequisite-patch-id: 7e41df07cbce163a689f5dca246b98a0122d1610
> -- 
> 2.47.3
> 

-- 
Yixun Lan (dlan)

On Sun, 01 Feb 2026 05:38:07 +0800, Han Gao <gaohan@iscas.ac.cn> wrote:
> This patch series enables the PMIC, voltage regulators, usb and pcie
> for the OrangePi rv2 board.

Hi:

Thank you for sending this in. I am working on "b4 review" functionality 
and I am using arbitrary series to perform agent-assisted reviews to 
find bugs in the process.

This review was done by Claude Opus 4.5. I do not know enough about the 
subsystem to make any judgment about the quality of these reviews, but 
they look valid enough.

Hopefully, these were useful. If not, I am sorry for wasting your time.

-- 
Konstantin Ryabitsev <konstantin@linuxfoundation.org>

On 2/1/26 13:18, Konstantin Ryabitsev wrote:
> On Sun, 01 Feb 2026 05:38:07 +0800, Han Gao <gaohan@iscas.ac.cn> wrote:
>> This patch series enables the PMIC, voltage regulators, usb and pcie
>> for the OrangePi rv2 board.
> Hi:
>
> Thank you for sending this in. I am working on "b4 review" functionality 
> and I am using arbitrary series to perform agent-assisted reviews to 
> find bugs in the process.
>
> This review was done by Claude Opus 4.5. I do not know enough about the 
> subsystem to make any judgment about the quality of these reviews, but 
> they look valid enough.

I'm not sure if you see this, but your bot gave two contradictory
recommendations.

On patch 3 it says:

> This vin-supply is replaced by per-rail supplies (vin1-supply through
> vin6-supply, aldoin-supply, dldoin1-supply, dldoin2-supply) in patch
> 5/7.  Consider using the final supply properties here directly to avoid
> an intermediate state that is immediately superseded.
Whereas on patch 5 it says

> These per-rail supply properties (vin1-supply through dldoin2-supply)
> are not declared in the spacemit,p1.yaml binding, which only has
> vin-supply.  With unevaluatedProperties: false on the PMIC node, these
> will cause dtbs_check failures.  The binding needs to be updated to
> match, or these should remain as the single vin-supply.
"Use vin1-supply through dldoin2-supply, not vin-supply" and "use
vin-supply only, not vin1-supply etc" can't both be correct, so
obviously something weird is going on.

So what on earth is going on? Granted, Han could have described it
better in his cover letter, but there's a proposed update to the
spacemit,p1 bindings [1] that would have deprecated vin-supply and
allowed vin1-supply etc. So there's a dependency in this series of
something like:

    patch 1,2 -> patch 3 -> bindings update [1] -> patch 5

If/when the bindings update is accepted, patch 5 can be accepted into
the DTS tree. Until then, patch 5 should be withheld.

This isn't obvious from the patch itself, but still, the two
recommendations are contradictory on their own, and make dtbs_check
(mentioned in the patch 5 comment!) would have caught the problem with
the patch 3 comment. 

> Hopefully, these were useful. If not, I am sorry for wasting your time.

I acknowledge that this is a sample size of 1, but this is not making me
feel inclined to trust the future of whatever "agent-assisted review" is
going to be happening. What good is an "agent" if it knows about make
dtbs_check but doesn't even run it to see what would happen to its
suggested fixes?

I don't know what you have in mind for "b4 review", but I think at the
very least, "b4 review" should not encourage "I do not know much about
the subsystem but the LLM comments look valid" replies.

Regards,
Vivian "dramforever" Wang

[1]: https://lore.kernel.org/spacemit/20260124-spacemit-p1-v2-0-2c86b06694ba@riscstar.com/

On Sun, Feb 01, 2026 at 03:54:45PM +0800, Vivian Wang wrote:
> > This review was done by Claude Opus 4.5. I do not know enough about the 
> > subsystem to make any judgment about the quality of these reviews, but 
> > they look valid enough.
> 
> I'm not sure if you see this, but your bot gave two contradictory
> recommendations.

Criticism accepted. For the record, it's not a bot -- I'm writing a review
tool that *may*, should the reviewer wish it, incorporate an LLM agent as a
manual step.

My goal was to test end-to-end review functionality, but from now on I will
focus on subsystems where I can actually discern actual useful reviews from
"looks reasonable" reviews.

Thanks and my apologies,
-K