Fix checkpatch.pl check regarding:
- Line length of X exceeds 100 columns
Redistribute comments to multiple lines to adhere to kernel coding
standards.
Signed-off-by: Mahad Ibrahim <mahad.ibrahim.dev@gmail.com>
---
drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c
index b7176a992518..fb108492efac 100644
--- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c
+++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c
@@ -60,7 +60,8 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, const u32 Condition1, const
if ((cond1 & BIT3) != 0) /* APA */
bitMask |= 0xFF000000;
- if ((cond2 & bitMask) == (driver2 & bitMask)) /* BoardType of each RF path is matched */
+ /* BoardType of each RF path is matched */
+ if ((cond2 & bitMask) == (driver2 & bitMask))
return true;
}
return false;
@@ -210,7 +211,10 @@ void ODM_ReadAndConfig_MP_8723B_MAC_REG(struct dm_odm_t *pDM_Odm)
}
if (!bMatched) {
- /* Condition isn't matched. Discard the following (offset, data) pairs. */
+ /*
+ * Condition isn't matched.
+ * Discard the following (offset, data) pairs.
+ */
while (v1 < 0x40000000 && i < ArrayLen - 2)
READ_NEXT_PAIR(v1, v2, i);
--
2.47.3
On Sun, Jan 18, 2026 at 04:54:45PM +0500, Mahad Ibrahim wrote: > Fix checkpatch.pl check regarding: > - Line length of X exceeds 100 columns > > Redistribute comments to multiple lines to adhere to kernel coding > standards. > > Signed-off-by: Mahad Ibrahim <mahad.ibrahim.dev@gmail.com> > --- > drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c > index b7176a992518..fb108492efac 100644 > --- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c > +++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c > @@ -60,7 +60,8 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, const u32 Condition1, const > if ((cond1 & BIT3) != 0) /* APA */ > bitMask |= 0xFF000000; > > - if ((cond2 & bitMask) == (driver2 & bitMask)) /* BoardType of each RF path is matched */ > + /* BoardType of each RF path is matched */ Why the extra space after /* and before BoardType? thanks, greg k-h
On Tue Jan 27, 2026 at 7:40 PM PKT, Greg KH wrote: >> - if ((cond2 & bitMask) == (driver2 & bitMask)) /* BoardType of each RF path is matched */ >> + /* BoardType of each RF path is matched */ > > Why the extra space after /* and before BoardType? > > thanks, > > greg k-h Thank you for the review. I included it to match the existing comment style prevalent in this specific file. Not adding it would have caused inconsistency. However I realize this violates the kernel coding standards. I will send a v3 series that addresses this issue, as well as fix the line comment style in that file as a separate logical change. thanks, Mahad Ibrahim
© 2016 - 2026 Red Hat, Inc.