[PATCH net-next v2 5/5] net: phy: realtek: get rid of magic number in rtlgen_read_status()

Daniel Golle posted 5 patches 1 month ago
[PATCH net-next v2 5/5] net: phy: realtek: get rid of magic number in rtlgen_read_status()
Posted by Daniel Golle 1 month ago
Use newly introduced helper macros RTL822X_VND2_TO_PAGE and
RTL822X_VND2_TO_PAGE_REG to access RTL_VEND2_PHYSR register over Clause-22
paged access instead of using magic numbers.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
v2: no changes

 drivers/net/phy/realtek/realtek_main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/phy/realtek/realtek_main.c b/drivers/net/phy/realtek/realtek_main.c
index d1c7935a13acc..eb5b540ada0e5 100644
--- a/drivers/net/phy/realtek/realtek_main.c
+++ b/drivers/net/phy/realtek/realtek_main.c
@@ -1154,7 +1154,8 @@ static int rtlgen_read_status(struct phy_device *phydev)
 	if (!phydev->link)
 		return 0;
 
-	val = phy_read_paged(phydev, 0xa43, 0x12);
+	val = phy_read_paged(phydev, RTL822X_VND2_TO_PAGE(RTL_VND2_PHYSR),
+			     RTL822X_VND2_TO_PAGE_REG(RTL_VND2_PHYSR));
 	if (val < 0)
 		return val;
 
-- 
2.52.0
Re: [PATCH net-next v2 5/5] net: phy: realtek: get rid of magic number in rtlgen_read_status()
Posted by Maxime Chevallier 1 month ago

On 05/01/2026 17:39, Daniel Golle wrote:
> Use newly introduced helper macros RTL822X_VND2_TO_PAGE and
> RTL822X_VND2_TO_PAGE_REG to access RTL_VEND2_PHYSR register over Clause-22
> paged access instead of using magic numbers.
> 
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>

That's nicer indeed !

Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Maxime