Agilex5 introduces changes in how reserved memory is mapped and accessed
compared to previous SoC generations. Agilex5 compatible allows stratix10-
FPGA manager driver to handle these changes.

Fallback is added for driver probe and init that rely on matching of table
and DT node.

Reviewed-by: Xu Yilun <yilun.xu@intel.com>
Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
---
Changes in v5:
	- Revert to oneOf and use enum without items.
Changes in v4:
	- Remove redundant "items - enum" as suggested in v3.
	- Simplify compatible property to use contains instead of oneOf.
	- Validate fallback and non-fallback DT. Also validate binding with
          dt_binding_check.
Changes in v3:
	- Add description for Agilex5 Device
	- Add and define fallback to "intel,agilex-soc-fpga-mgr"
	- Validate against Agilex and Stratix10 (non-fallback) and Agilex5
	  (fallback)
Changes in v2:
	- No changes in this patch
---
 .../bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml    | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml b/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
index 6e536d6b28a9..14437dfc47a4 100644
--- a/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
+++ b/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
@@ -20,9 +20,13 @@ description:
 
 properties:
   compatible:
-    enum:
-      - intel,stratix10-soc-fpga-mgr
-      - intel,agilex-soc-fpga-mgr
+    oneOf:
+      - enum:
+          - intel,stratix10-soc-fpga-mgr
+          - intel,agilex-soc-fpga-mgr
+      - enum:
+          - intel,agilex5-soc-fpga-mgr
+        const: intel,agilex-soc-fpga-mgr
 
 required:
   - compatible
-- 
2.43.7

On Wed, Nov 19, 2025 at 07:34:18AM +0800, Khairul Anuar Romli wrote:
> Agilex5 introduces changes in how reserved memory is mapped and accessed
> compared to previous SoC generations. Agilex5 compatible allows stratix10-
> FPGA manager driver to handle these changes.
> 
> Fallback is added for driver probe and init that rely on matching of table
> and DT node.
> 
> Reviewed-by: Xu Yilun <yilun.xu@intel.com>
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> ---
> Changes in v5:
> 	- Revert to oneOf and use enum without items.
> Changes in v4:
> 	- Remove redundant "items - enum" as suggested in v3.
> 	- Simplify compatible property to use contains instead of oneOf.
> 	- Validate fallback and non-fallback DT. Also validate binding with
>           dt_binding_check.
> Changes in v3:
> 	- Add description for Agilex5 Device
> 	- Add and define fallback to "intel,agilex-soc-fpga-mgr"
> 	- Validate against Agilex and Stratix10 (non-fallback) and Agilex5
> 	  (fallback)
> Changes in v2:
> 	- No changes in this patch
> ---
>  .../bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml    | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml b/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
> index 6e536d6b28a9..14437dfc47a4 100644
> --- a/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
> +++ b/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
> @@ -20,9 +20,13 @@ description:
>  
>  properties:
>    compatible:
> -    enum:
> -      - intel,stratix10-soc-fpga-mgr
> -      - intel,agilex-soc-fpga-mgr
> +    oneOf:
> +      - enum:
> +          - intel,stratix10-soc-fpga-mgr
> +          - intel,agilex-soc-fpga-mgr

Great, you've fixed this part.

> +      - enum:
> +          - intel,agilex5-soc-fpga-mgr
> +        const: intel,agilex-soc-fpga-mgr

But unfortunately this is wrong, and you should have noticed it
because the dts patch you have will produce a warning.
This one actually does need the items, you had it right in v3.
You'll note that my v3 feedback specifically said "this construct" and
was inserted at the point of the redundant single item items list:
https://lore.kernel.org/all/20251114-countless-vantage-6e18528d2e31@spud/

pw-bot: changes-requested

Please take some time to both test and understand the change you are
making.

Thanks,
Conor.

>  
>  required:
>    - compatible
> -- 
> 2.43.7
> 

On 19/11/2025 9:20 am, Conor Dooley wrote:
> On Wed, Nov 19, 2025 at 07:34:18AM +0800, Khairul Anuar Romli wrote:
>> Agilex5 introduces changes in how reserved memory is mapped and accessed
>> compared to previous SoC generations. Agilex5 compatible allows stratix10-
>> FPGA manager driver to handle these changes.
>>
>> Fallback is added for driver probe and init that rely on matching of table
>> and DT node.
>>
>> Reviewed-by: Xu Yilun <yilun.xu@intel.com>
>> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
>> ---
>> Changes in v5:
>> 	- Revert to oneOf and use enum without items.
>> Changes in v4:
>> 	- Remove redundant "items - enum" as suggested in v3.
>> 	- Simplify compatible property to use contains instead of oneOf.
>> 	- Validate fallback and non-fallback DT. Also validate binding with
>>            dt_binding_check.
>> Changes in v3:
>> 	- Add description for Agilex5 Device
>> 	- Add and define fallback to "intel,agilex-soc-fpga-mgr"
>> 	- Validate against Agilex and Stratix10 (non-fallback) and Agilex5
>> 	  (fallback)
>> Changes in v2:
>> 	- No changes in this patch
>> ---
>>   .../bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml    | 10 +++++++---
>>   1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml b/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
>> index 6e536d6b28a9..14437dfc47a4 100644
>> --- a/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
>> +++ b/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
>> @@ -20,9 +20,13 @@ description:
>>   
>>   properties:
>>     compatible:
>> -    enum:
>> -      - intel,stratix10-soc-fpga-mgr
>> -      - intel,agilex-soc-fpga-mgr
>> +    oneOf:
>> +      - enum:
>> +          - intel,stratix10-soc-fpga-mgr
>> +          - intel,agilex-soc-fpga-mgr
> 
> Great, you've fixed this part.
> 
>> +      - enum:
>> +          - intel,agilex5-soc-fpga-mgr
>> +        const: intel,agilex-soc-fpga-mgr
> 
> But unfortunately this is wrong, and you should have noticed it
> because the dts patch you have will produce a warning.
> This one actually does need the items, you had it right in v3.
> You'll note that my v3 feedback specifically said "this construct" and
> was inserted at the point of the redundant single item items list:
> https://lore.kernel.org/all/20251114-countless-vantage-6e18528d2e31@spud/
> 
> pw-bot: changes-requested
> 
> Please take some time to both test and understand the change you are
> making.
> 
> Thanks,
> Conor.
> 

Yeap, this is the part that I am seeing warning during the test and I am 
trying to resolved it now.

I will go through other bindings with rg --multiline that you shared and 
will send next version after all the test is done.

Thank You.

Best Regards,
Khairul

>>   
>>   required:
>>     - compatible
>> -- 
>> 2.43.7
>>

On Wed, Nov 19, 2025 at 01:45:03AM +0000, Romli, Khairul Anuar wrote:

> I will go through other bindings with rg --multiline that you shared and 
> will send next version after all the test is done.

Unless you're planning on fixing the ones that should not have contains,
that comment was only for Krzysztof.