1. Patchew
  2. linux
  3. [PATCH 0/3] mm: Coccinelle-driven cleanups across memory management code
  4. View patch

[PATCH 3/3] mm/zswap: use %pe to print PTR_ERR() values

Sahil Chandna posted 3 patches 1 week, 6 days ago
There is a newer version of this series
[PATCH 3/3] mm/zswap: use %pe to print PTR_ERR() values
Posted by Sahil Chandna 1 week, 6 days ago 
Use the %pe printk format specifier to report error pointers directly
instead of printing PTR_ERR() as a long value. This improves clarity,
produces more readable error messages.

This instance was flagged by the Coccinelle script
(misc/ptr_err_to_pe.cocci) as an opportunity to adopt %pe.

Found by: make coccicheck MODE=report M=mm/
No functional change intended.

Signed-off-by: Sahil Chandna <chandna.sahil@gmail.com>
---
 mm/zswap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/zswap.c b/mm/zswap.c
index c1af782e54ec..c35604db32ad 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -749,8 +749,8 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node)
 
 	acomp = crypto_alloc_acomp_node(pool->tfm_name, 0, 0, cpu_to_node(cpu));
 	if (IS_ERR(acomp)) {
-		pr_err("could not alloc crypto acomp %s : %ld\n",
-				pool->tfm_name, PTR_ERR(acomp));
+		pr_err("could not alloc crypto acomp %s : %pe\n",
+				pool->tfm_name, acomp);
 		ret = PTR_ERR(acomp);
 		goto fail;
 	}
-- 
2.50.1
Re: [PATCH 3/3] mm/zswap: use %pe to print PTR_ERR() values
Posted by Nhat Pham 1 week, 5 days ago 
On Tue, Nov 18, 2025 at 6:09 AM Sahil Chandna <chandna.sahil@gmail.com> wrote:
>
> Use the %pe printk format specifier to report error pointers directly
> instead of printing PTR_ERR() as a long value. This improves clarity,
> produces more readable error messages.
>
> This instance was flagged by the Coccinelle script
> (misc/ptr_err_to_pe.cocci) as an opportunity to adopt %pe.
>
> Found by: make coccicheck MODE=report M=mm/
> No functional change intended.
>
> Signed-off-by: Sahil Chandna <chandna.sahil@gmail.com>

Acked-by: Nhat Pham <nphamcs@gmail.com>
Re: [PATCH 3/3] mm/zswap: use %pe to print PTR_ERR() values
Posted by SeongJae Park 1 week, 6 days ago 
On Tue, 18 Nov 2025 11:38:51 +0530 Sahil Chandna <chandna.sahil@gmail.com> wrote:

> Use the %pe printk format specifier to report error pointers directly
> instead of printing PTR_ERR() as a long value. This improves clarity,
> produces more readable error messages.
> 
> This instance was flagged by the Coccinelle script
> (misc/ptr_err_to_pe.cocci) as an opportunity to adopt %pe.
> 
> Found by: make coccicheck MODE=report M=mm/
> No functional change intended.
> 
> Signed-off-by: Sahil Chandna <chandna.sahil@gmail.com>

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]
Re: [PATCH 3/3] mm/zswap: use %pe to print PTR_ERR() values
Posted by Yosry Ahmed 1 week, 6 days ago 
On Tue, Nov 18, 2025 at 11:38:51AM +0530, Sahil Chandna wrote:
> Use the %pe printk format specifier to report error pointers directly
> instead of printing PTR_ERR() as a long value. This improves clarity,
> produces more readable error messages.
> 
> This instance was flagged by the Coccinelle script
> (misc/ptr_err_to_pe.cocci) as an opportunity to adopt %pe.
> 
> Found by: make coccicheck MODE=report M=mm/
> No functional change intended.
> 
> Signed-off-by: Sahil Chandna <chandna.sahil@gmail.com>

Acked-by: Yosry Ahmed <yosry.ahmed@linux.dev>

> ---
>  mm/zswap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/zswap.c b/mm/zswap.c
> index c1af782e54ec..c35604db32ad 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -749,8 +749,8 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node)
>  
>  	acomp = crypto_alloc_acomp_node(pool->tfm_name, 0, 0, cpu_to_node(cpu));
>  	if (IS_ERR(acomp)) {
> -		pr_err("could not alloc crypto acomp %s : %ld\n",
> -				pool->tfm_name, PTR_ERR(acomp));
> +		pr_err("could not alloc crypto acomp %s : %pe\n",
> +				pool->tfm_name, acomp);
>  		ret = PTR_ERR(acomp);
>  		goto fail;
>  	}
> -- 
> 2.50.1
>
Re: [PATCH 3/3] mm/zswap: use %pe to print PTR_ERR() values
Posted by Markus Elfring 1 week, 6 days ago 
…
> +++ b/mm/zswap.c
> @@ -749,8 +749,8 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node)
>  
>  	acomp = crypto_alloc_acomp_node(pool->tfm_name, 0, 0, cpu_to_node(cpu));
>  	if (IS_ERR(acomp)) {
…
> +		pr_err("could not alloc crypto acomp %s : %pe\n",
> +				pool->tfm_name, acomp);
>  		ret = PTR_ERR(acomp);
…

Would you like to reduce the indentation for the passed parameters?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.18-rc6#n110

Regards,
Markus
Re: [PATCH 3/3] mm/zswap: use %pe to print PTR_ERR() values
Posted by Matthew Wilcox 1 week, 6 days ago 
On Tue, Nov 18, 2025 at 02:20:59PM +0100, Markus Elfring wrote:
> …
> > +++ b/mm/zswap.c
> > @@ -749,8 +749,8 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node)
> >  
> >  	acomp = crypto_alloc_acomp_node(pool->tfm_name, 0, 0, cpu_to_node(cpu));
> >  	if (IS_ERR(acomp)) {
> …
> > +		pr_err("could not alloc crypto acomp %s : %pe\n",
> > +				pool->tfm_name, acomp);
> >  		ret = PTR_ERR(acomp);
> …
> 
> Would you like to reduce the indentation for the passed parameters?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.18-rc6#n110

That is the exact opposite of what this suggestion is intended to say.

Sahil, you should ignore any suggestion made to you by Markus.  He has
been told many times to stop making these useless and unhelpful comments,
and yet he persists.
Re: [PATCH 3/3] mm/zswap: use %pe to print PTR_ERR() values
Posted by Markus Elfring 1 week, 6 days ago 
>>> +++ b/mm/zswap.c
>>> @@ -749,8 +749,8 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node)
>>>  
>>>  	acomp = crypto_alloc_acomp_node(pool->tfm_name, 0, 0, cpu_to_node(cpu));
>>>  	if (IS_ERR(acomp)) {
>> …
>>> +		pr_err("could not alloc crypto acomp %s : %pe\n",
>>> +				pool->tfm_name, acomp);
>>>  		ret = PTR_ERR(acomp);
>> …
>>
>> Would you like to reduce the indentation for the passed parameters?
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.18-rc6#n110
> 
> That is the exact opposite of what this suggestion is intended to say.

I wonder about the interpretation of the provided information in such a direction.


> Sahil, you should ignore any suggestion made to you by Markus.

Do you try to distract from reminders according to a known information source here?

Regards,
Markus

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.