1. Patchew
  2. linux
  3. [PATCH v2 0/2] Enable FPGA Manager support for Agilex5
  4. View patch

[PATCH v2 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes

Khairul Anuar Romli posted 2 patches 3 weeks, 4 days ago
There is a newer version of this series
[PATCH v2 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes
Posted by Khairul Anuar Romli 3 weeks, 4 days ago 
The Intel Agilex 5 SoC contains a programmable FPGA region that requires
proper device tree description to enable FPGA manager support in the Linux
kernel. Without the 'fpga-region' and 'fpga-mgr' nodes, the kernel cannot
detect or manage the FPGA hardware correctly.

This patch adds a 'fpga-region' node with compatible = "fpga-region", along
with appropriate #address-cells and #size-cells properties, to describe the
FPGA region layout.

Also defines specific compatible string for Agilex5 and add Agilex string
as fallback for stratix10-soc driver initialization.

Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
---
Changes in v2:
	- All fallback compatible string to ensure driver is still able to
	  initialize without new compatible string added in the driver.
---
 arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
index bf7128adddde..06be0b8671c0 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
@@ -85,9 +85,21 @@ svc {
 			method = "smc";
 			memory-region = <&service_reserved>;
 			iommus = <&smmu 10>;
+
+			fpga_mgr: fpga-mgr {
+				compatible = "intel,agilex5-soc-fpga-mgr",
+					     "intel,agilex-soc-fpga-mgr";
+			};
 		};
 	};
 
+	fpga-region {
+		compatible = "fpga-region";
+		#address-cells = <0x2>;
+		#size-cells = <0x2>;
+		fpga-mgr = <&fpga_mgr>;
+	};
+
 	psci {
 		compatible = "arm,psci-0.2";
 		method = "smc";
-- 
2.43.7
Re: [PATCH v2 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes
Posted by Krzysztof Kozlowski 3 weeks, 4 days ago 
On 13/11/2025 05:43, Khairul Anuar Romli wrote:
> The Intel Agilex 5 SoC contains a programmable FPGA region that requires
> proper device tree description to enable FPGA manager support in the Linux
> kernel. Without the 'fpga-region' and 'fpga-mgr' nodes, the kernel cannot
> detect or manage the FPGA hardware correctly.
> 
> This patch adds a 'fpga-region' node with compatible = "fpga-region", along
> with appropriate #address-cells and #size-cells properties, to describe the
> FPGA region layout.
> 
> Also defines specific compatible string for Agilex5 and add Agilex string
> as fallback for stratix10-soc driver initialization.
> 
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> ---
> Changes in v2:
> 	- All fallback compatible string to ensure driver is still able to
> 	  initialize without new compatible string added in the driver.
> ---
>  arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> index bf7128adddde..06be0b8671c0 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> @@ -85,9 +85,21 @@ svc {
>  			method = "smc";
>  			memory-region = <&service_reserved>;
>  			iommus = <&smmu 10>;
> +
> +			fpga_mgr: fpga-mgr {
> +				compatible = "intel,agilex5-soc-fpga-mgr",
> +					     "intel,agilex-soc-fpga-mgr";


You did not bother to test this...

Best regards,
Krzysztof
Re: [PATCH v2 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes
Posted by Xu Yilun 3 weeks, 4 days ago 
On Thu, Nov 13, 2025 at 12:43:56PM +0800, Khairul Anuar Romli wrote:
> The Intel Agilex 5 SoC contains a programmable FPGA region that requires
> proper device tree description to enable FPGA manager support in the Linux
> kernel. Without the 'fpga-region' and 'fpga-mgr' nodes, the kernel cannot
> detect or manage the FPGA hardware correctly.
> 
> This patch adds a 'fpga-region' node with compatible = "fpga-region", along
> with appropriate #address-cells and #size-cells properties, to describe the
> FPGA region layout.
> 
> Also defines specific compatible string for Agilex5 and add Agilex string
> as fallback for stratix10-soc driver initialization.
> 
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>

Reviewed-by: Xu Yilun <yilun.xu@intel.com>
Re: [PATCH v2 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes
Posted by Krzysztof Kozlowski 3 weeks, 4 days ago 
On 13/11/2025 06:55, Xu Yilun wrote:
> On Thu, Nov 13, 2025 at 12:43:56PM +0800, Khairul Anuar Romli wrote:
>> The Intel Agilex 5 SoC contains a programmable FPGA region that requires
>> proper device tree description to enable FPGA manager support in the Linux
>> kernel. Without the 'fpga-region' and 'fpga-mgr' nodes, the kernel cannot
>> detect or manage the FPGA hardware correctly.
>>
>> This patch adds a 'fpga-region' node with compatible = "fpga-region", along
>> with appropriate #address-cells and #size-cells properties, to describe the
>> FPGA region layout.
>>
>> Also defines specific compatible string for Agilex5 and add Agilex string
>> as fallback for stratix10-soc driver initialization.
>>
>> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> 
> Reviewed-by: Xu Yilun <yilun.xu@intel.com>

How this can be reviewed if it is completely wrong and obviously not
matching the bindings from this patchset?

Best regards,
Krzysztof
Re: [PATCH v2 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes
Posted by Xu Yilun 3 weeks, 3 days ago 
On Thu, Nov 13, 2025 at 08:12:24AM +0100, Krzysztof Kozlowski wrote:
> On 13/11/2025 06:55, Xu Yilun wrote:
> > On Thu, Nov 13, 2025 at 12:43:56PM +0800, Khairul Anuar Romli wrote:
> >> The Intel Agilex 5 SoC contains a programmable FPGA region that requires
> >> proper device tree description to enable FPGA manager support in the Linux
> >> kernel. Without the 'fpga-region' and 'fpga-mgr' nodes, the kernel cannot
> >> detect or manage the FPGA hardware correctly.
> >>
> >> This patch adds a 'fpga-region' node with compatible = "fpga-region", along
> >> with appropriate #address-cells and #size-cells properties, to describe the
> >> FPGA region layout.
> >>
> >> Also defines specific compatible string for Agilex5 and add Agilex string
> >> as fallback for stratix10-soc driver initialization.
> >>
> >> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> > 
> > Reviewed-by: Xu Yilun <yilun.xu@intel.com>
> 
> How this can be reviewed if it is completely wrong and obviously not
> matching the bindings from this patchset?

I apologize. Obviously I didn't pay enough effort on DT. Thanks for
pointing out and providing the Doc.

> 
> Best regards,
> Krzysztof
Re: [PATCH v2 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes
Posted by Romli, Khairul Anuar 3 weeks, 4 days ago 
On 13/11/2025 3:12 pm, Krzysztof Kozlowski wrote:
> On 13/11/2025 06:55, Xu Yilun wrote:
>> On Thu, Nov 13, 2025 at 12:43:56PM +0800, Khairul Anuar Romli wrote:
>>> The Intel Agilex 5 SoC contains a programmable FPGA region that requires
>>> proper device tree description to enable FPGA manager support in the Linux
>>> kernel. Without the 'fpga-region' and 'fpga-mgr' nodes, the kernel cannot
>>> detect or manage the FPGA hardware correctly.
>>>
>>> This patch adds a 'fpga-region' node with compatible = "fpga-region", along
>>> with appropriate #address-cells and #size-cells properties, to describe the
>>> FPGA region layout.
>>>
>>> Also defines specific compatible string for Agilex5 and add Agilex string
>>> as fallback for stratix10-soc driver initialization.
>>>
>>> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
>>
>> Reviewed-by: Xu Yilun <yilun.xu@intel.com>
> 
> How this can be reviewed if it is completely wrong and obviously not
> matching the bindings from this patchset?
> 
> Best regards,
> Krzysztof

Could you point out which part that I need to fix?

Thanks.

Best Regards,
Khairul
Re: [PATCH v2 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes
Posted by Krzysztof Kozlowski 3 weeks, 4 days ago 
On 13/11/2025 10:09, Romli, Khairul Anuar wrote:
> On 13/11/2025 3:12 pm, Krzysztof Kozlowski wrote:
>> On 13/11/2025 06:55, Xu Yilun wrote:
>>> On Thu, Nov 13, 2025 at 12:43:56PM +0800, Khairul Anuar Romli wrote:
>>>> The Intel Agilex 5 SoC contains a programmable FPGA region that requires
>>>> proper device tree description to enable FPGA manager support in the Linux
>>>> kernel. Without the 'fpga-region' and 'fpga-mgr' nodes, the kernel cannot
>>>> detect or manage the FPGA hardware correctly.
>>>>
>>>> This patch adds a 'fpga-region' node with compatible = "fpga-region", along
>>>> with appropriate #address-cells and #size-cells properties, to describe the
>>>> FPGA region layout.
>>>>
>>>> Also defines specific compatible string for Agilex5 and add Agilex string
>>>> as fallback for stratix10-soc driver initialization.
>>>>
>>>> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
>>>
>>> Reviewed-by: Xu Yilun <yilun.xu@intel.com>
>>
>> How this can be reviewed if it is completely wrong and obviously not
>> matching the bindings from this patchset?
>>
>> Best regards,
>> Krzysztof
> 
> Could you point out which part that I need to fix?
>

Why? Tools tell you that. Why are you expecting the community to do the
job of compiler/toolchain/toolset? We have better things to do.

Best regards,
Krzysztof

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.