[PATCH v2 2/3] staging: rtl8723bs: Rename camel case argument

Bryant Boatright posted 3 patches 3 months ago
There is a newer version of this series
[PATCH v2 2/3] staging: rtl8723bs: Rename camel case argument
Posted by Bryant Boatright 3 months ago
Adhere to Linux kernel style.

Reported by checkpatch:

CHECK: Avoid CamelCase: <bw_40MHz>

Signed-off-by: Bryant Boatright <bryant.boatright@proton.me>
---
 drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 18 +++++++++---------
 drivers/staging/rtl8723bs/include/ieee80211.h  |  2 +-
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
index d25fd538305a..f22f8a95f372 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
@@ -1077,26 +1077,26 @@ void rtw_get_bcn_info(struct wlan_network *pnetwork)
 }
 
 /* show MCS rate, unit: 100Kbps */
-u16 rtw_mcs_rate(u8 bw_40MHz, u8 short_GI, unsigned char *MCS_rate)
+u16 rtw_mcs_rate(u8 bw_40_mhz, u8 short_GI, unsigned char *MCS_rate)
 {
 	u16 max_rate = 0;
 
 	if (MCS_rate[0] & BIT(7))
-		max_rate = (bw_40MHz) ? ((short_GI)?1500:1350):((short_GI)?722:650);
+		max_rate = (bw_40_mhz) ? ((short_GI)?1500:1350):((short_GI)?722:650);
 	else if (MCS_rate[0] & BIT(6))
-		max_rate = (bw_40MHz) ? ((short_GI)?1350:1215):((short_GI)?650:585);
+		max_rate = (bw_40_mhz) ? ((short_GI)?1350:1215):((short_GI)?650:585);
 	else if (MCS_rate[0] & BIT(5))
-		max_rate = (bw_40MHz) ? ((short_GI)?1200:1080):((short_GI)?578:520);
+		max_rate = (bw_40_mhz) ? ((short_GI)?1200:1080):((short_GI)?578:520);
 	else if (MCS_rate[0] & BIT(4))
-		max_rate = (bw_40MHz) ? ((short_GI)?900:810):((short_GI)?433:390);
+		max_rate = (bw_40_mhz) ? ((short_GI)?900:810):((short_GI)?433:390);
 	else if (MCS_rate[0] & BIT(3))
-		max_rate = (bw_40MHz) ? ((short_GI)?600:540):((short_GI)?289:260);
+		max_rate = (bw_40_mhz) ? ((short_GI)?600:540):((short_GI)?289:260);
 	else if (MCS_rate[0] & BIT(2))
-		max_rate = (bw_40MHz) ? ((short_GI)?450:405):((short_GI)?217:195);
+		max_rate = (bw_40_mhz) ? ((short_GI)?450:405):((short_GI)?217:195);
 	else if (MCS_rate[0] & BIT(1))
-		max_rate = (bw_40MHz) ? ((short_GI)?300:270):((short_GI)?144:130);
+		max_rate = (bw_40_mhz) ? ((short_GI)?300:270):((short_GI)?144:130);
 	else if (MCS_rate[0] & BIT(0))
-		max_rate = (bw_40MHz) ? ((short_GI)?150:135):((short_GI)?72:65);
+		max_rate = (bw_40_mhz) ? ((short_GI)?150:135):((short_GI)?72:65);
 
 	return max_rate;
 }
diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs/include/ieee80211.h
index f94db820d335..cf0bfe3e19ba 100644
--- a/drivers/staging/rtl8723bs/include/ieee80211.h
+++ b/drivers/staging/rtl8723bs/include/ieee80211.h
@@ -781,7 +781,7 @@ void rtw_get_bcn_info(struct wlan_network *pnetwork);
 
 void rtw_macaddr_cfg(struct device *dev, u8 *mac_addr);
 
-u16 rtw_mcs_rate(u8 bw_40MHz, u8 short_GI, unsigned char *MCS_rate);
+u16 rtw_mcs_rate(u8 bw_40_mhz, u8 short_GI, unsigned char *MCS_rate);
 
 int rtw_action_frame_parse(const u8 *frame, u32 frame_len, u8 *category, u8 *action);
 const char *action_public_str(u8 action);
-- 
2.43.0
Re: [PATCH v2 2/3] staging: rtl8723bs: Rename camel case argument
Posted by Greg Kroah-Hartman 2 months, 2 weeks ago
On Mon, Nov 10, 2025 at 07:49:46PM +0000, Bryant Boatright wrote:
> Adhere to Linux kernel style.
> 
> Reported by checkpatch:
> 
> CHECK: Avoid CamelCase: <bw_40MHz>

MHz is the correct spelling of this, right?  I think "mhz" means
something else (i.e. nothing.)

So this isn't a good change, sorry.

thanks,

greg k-h