[PATCH 1/3] staging: rtl8723bs: Rename camel case enumeration

Bryant Boatright posted 3 patches 1 month, 1 week ago
There is a newer version of this series
[PATCH 1/3] staging: rtl8723bs: Rename camel case enumeration
Posted by Bryant Boatright 1 month, 1 week ago
Adhere to Linux kernel style.

Reported by checkpatch:

CHECK: Avoid CamelCase: <ParseRes>
CHECK: Avoid CamelCase: <ParseFailed>
CHECK: Avoid CamelCase: <ParseUnknown>
CHECK: Avoid CamelCase: <ParseOK>

Signed-off-by: Bryant Boatright <bryant.boatright@proton.me>
---
 drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 8 ++++----
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c  | 2 +-
 drivers/staging/rtl8723bs/include/ieee80211.h  | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
index 027b2dd0a4b9..ed00cec80911 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
@@ -839,7 +839,7 @@ static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, uint elen,
  * @show_errors: Whether to show parsing errors in debug log
  * Returns: Parsing result
  */
-enum ParseRes rtw_ieee802_11_parse_elems(u8 *start, uint len,
+enum parse_res rtw_ieee802_11_parse_elems(u8 *start, uint len,
 				struct rtw_ieee802_11_elems *elems,
 				int show_errors)
 {
@@ -857,7 +857,7 @@ enum ParseRes rtw_ieee802_11_parse_elems(u8 *start, uint len,
 		left -= 2;
 
 		if (elen > left)
-			return ParseFailed;
+			return parse_failed;
 
 		switch (id) {
 		case WLAN_EID_SSID:
@@ -960,9 +960,9 @@ enum ParseRes rtw_ieee802_11_parse_elems(u8 *start, uint len,
 	}
 
 	if (left)
-		return ParseFailed;
+		return parse_failed;
 
-	return unknown ? ParseUnknown : ParseOK;
+	return unknown ? parse_unknown : parse_ok;
 }
 
 void rtw_macaddr_cfg(struct device *dev, u8 *mac_addr)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index 8fe0555ab033..d79b29143fc5 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -1005,7 +1005,7 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame)
 	pstat->capability = capab_info;
 
 	/* now parse all ieee802_11 ie to point to elems */
-	if (rtw_ieee802_11_parse_elems(pos, left, &elems, 1) == ParseFailed ||
+	if (rtw_ieee802_11_parse_elems(pos, left, &elems, 1) == parse_failed ||
 	    !elems.ssid) {
 		status = WLAN_STATUS_CHALLENGE_FAIL;
 		goto OnAssocReqFail;
diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs/include/ieee80211.h
index 1098b0209200..e94efe8f964b 100644
--- a/drivers/staging/rtl8723bs/include/ieee80211.h
+++ b/drivers/staging/rtl8723bs/include/ieee80211.h
@@ -724,9 +724,9 @@ struct rtw_ieee802_11_elems {
 	u8 vht_op_mode_notify_len;
 };
 
-enum ParseRes { ParseOK = 0, ParseUnknown = 1, ParseFailed = -1 };
+enum parse_res { parse_ok = 0, parse_unknown = 1, parse_failed = -1 };
 
-enum ParseRes rtw_ieee802_11_parse_elems(u8 *start, uint len,
+enum parse_res rtw_ieee802_11_parse_elems(u8 *start, uint len,
 				struct rtw_ieee802_11_elems *elems,
 				int show_errors);
 
-- 
2.43.0
Re: [PATCH 1/3] staging: rtl8723bs: Rename camel case enumeration
Posted by Michael Straube 1 month, 1 week ago
Hi Bryant,

Am 08.11.25 um 05:54 schrieb Bryant Boatright:
> -enum ParseRes { ParseOK = 0, ParseUnknown = 1, ParseFailed = -1 };
> +enum parse_res { parse_ok = 0, parse_unknown = 1, parse_failed = -1 };

The constants in enums are usually named all upper case.
PARSE_OK, PARSE_UNKNOWN, PARSE_FAILED

Best regards,
Michael
Re: [PATCH 1/3] staging: rtl8723bs: Rename camel case enumeration
Posted by Bryant Boatright 1 month, 1 week ago
On Sat, Nov 08, 2025 at 06:51:45AM +0100, Michael Straube wrote:
> Hi Bryant,
> 
> Am 08.11.25 um 05:54 schrieb Bryant Boatright:
> > -enum ParseRes { ParseOK = 0, ParseUnknown = 1, ParseFailed = -1 };
> > +enum parse_res { parse_ok = 0, parse_unknown = 1, parse_failed = -1 };
> 
> The constants in enums are usually named all upper case.
> PARSE_OK, PARSE_UNKNOWN, PARSE_FAILED
> 
> Best regards,
> Michael

Michael,

Thanks for the feedback, I'll correct that and resubmit in a
V2 patchset.

Best,
Bryant