[RFC 03/10] drivers: dax: use pgtable_has_pmd_leaves()

Luiz Capitulino posted 10 patches 1 month, 1 week ago
There is a newer version of this series
[RFC 03/10] drivers: dax: use pgtable_has_pmd_leaves()
Posted by Luiz Capitulino 1 month, 1 week ago
dav_align_valid() uses has_transparent_hugepage() to check if PMD-sized
pages are supported, use pgtable_has_pmd_leaves() instead.

Signed-off-by: Luiz Capitulino <luizcap@redhat.com>
---
 drivers/dax/dax-private.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dax/dax-private.h b/drivers/dax/dax-private.h
index 0867115aeef2..10aeaec9e789 100644
--- a/drivers/dax/dax-private.h
+++ b/drivers/dax/dax-private.h
@@ -117,7 +117,7 @@ static inline bool dax_align_valid(unsigned long align)
 {
 	if (align == PUD_SIZE && IS_ENABLED(CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD))
 		return true;
-	if (align == PMD_SIZE && has_transparent_hugepage())
+	if (align == PMD_SIZE && pgtable_has_pmd_leaves())
 		return true;
 	if (align == PAGE_SIZE)
 		return true;
-- 
2.51.1
Re: [RFC 03/10] drivers: dax: use pgtable_has_pmd_leaves()
Posted by David Hildenbrand (Red Hat) 1 month ago
On 06.11.25 22:28, Luiz Capitulino wrote:
> dav_align_valid() uses has_transparent_hugepage() to check if PMD-sized
> pages are supported, use pgtable_has_pmd_leaves() instead.
> 
> Signed-off-by: Luiz Capitulino <luizcap@redhat.com>
> ---
>   drivers/dax/dax-private.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dax/dax-private.h b/drivers/dax/dax-private.h
> index 0867115aeef2..10aeaec9e789 100644
> --- a/drivers/dax/dax-private.h
> +++ b/drivers/dax/dax-private.h
> @@ -117,7 +117,7 @@ static inline bool dax_align_valid(unsigned long align)
>   {
>   	if (align == PUD_SIZE && IS_ENABLED(CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD))

As discussed offlist, it would be great to later also have this be

if (align == PUD_SIZE && pgtable_has_pud_leaves()

Acked-by: David Hildenbrand (Red Hat) <david@kernel.org>

-- 
Cheers

David