[v6] Non-const bitfield helpers

[PATCH -next v6 24/26] mtd: rawnand: sunxi: Convert to common field_{get,prep}() helpers

Posted by Geert Uytterhoeven 1 month, 1 week ago

Drop the driver-specific field_get() and field_prep() macros, in favor
of the globally available variants from <linux/bitfield.h>.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v6:
  - New.
---
 drivers/mtd/nand/raw/sunxi_nand.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c
index 9dcdc93734cbff39..e66adfcca7cd63fb 100644
--- a/drivers/mtd/nand/raw/sunxi_nand.c
+++ b/drivers/mtd/nand/raw/sunxi_nand.c
@@ -29,12 +29,6 @@
 #include <linux/iopoll.h>
 #include <linux/reset.h>
 
-/* non compile-time field get/prep */
-#undef field_get
-#define field_get(_mask, _reg) (((_reg) & (_mask)) >> (ffs(_mask) - 1))
-#undef field_prep
-#define field_prep(_mask, _val) (((_val) << (ffs(_mask) - 1)) & (_mask))
-
 #define NFC_REG_CTL		0x0000
 #define NFC_REG_ST		0x0004
 #define NFC_REG_INT		0x0008
-- 
2.43.0

Re: [PATCH -next v6 24/26] mtd: rawnand: sunxi: Convert to common field_{get,prep}() helpers

Posted by Miquel Raynal 1 month, 1 week ago

Hello Geert,

On 06/11/2025 at 14:34:12 +01, Geert Uytterhoeven <geert+renesas@glider.be> wrote:

> Drop the driver-specific field_get() and field_prep() macros, in favor
> of the globally available variants from <linux/bitfield.h>.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v6:
>   - New.

Thanks for preemptively handling this case!

Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thansk,
Miquèl