In Agilex5, the TBU (Translation Buffer Unit) can now operate in non-secure
mode, enabling Linux to utilize it through the IOMMU framework. This allows
improved memory management capabilities in non-secure environments. With
Agilex5 lifting this restriction, we are now extending the device tree
bindings to support IOMMU for the Agilex5 SVC.

Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
---
Changes in v5:
	- Use contains enum instead of const
Changes in v4:
	- Fix syntax / style error.
	- Refactor code not to use AllOf but instead use if directly.
Changes in v3:
	- Add iommu property.
	- Add logical check where only Agilex5 required iommus
	- Rewrite the commit message to explain why this changes is 
	  needed.
Changes in v2:
	- Reprase commit message to exclude iommu
---
 .../bindings/firmware/intel,stratix10-svc.yaml     | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
index fac1e955852e..a66aeed0ddee 100644
--- a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
+++ b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
@@ -34,6 +34,7 @@ properties:
     enum:
       - intel,stratix10-svc
       - intel,agilex-svc
+      - intel,agilex5-svc
 
   method:
     description: |
@@ -54,6 +55,9 @@ properties:
       reserved memory region for the service layer driver to
       communicate with the secure device manager.
 
+  iommus:
+    maxItems: 1
+
   fpga-mgr:
     $ref: /schemas/fpga/intel,stratix10-soc-fpga-mgr.yaml
     description: Optional child node for fpga manager to perform fabric configuration.
@@ -63,6 +67,16 @@ required:
   - method
   - memory-region
 
+if:
+  properties:
+    compatible:
+      contains:
+        enum:
+          - intel,agilex5-svc
+then:
+  required:
+    - iommus
+
 additionalProperties: false
 
 examples:
-- 
2.43.7

On Wed, Nov 05, 2025 at 10:28:01AM +0800, Khairul Anuar Romli wrote:
> In Agilex5, the TBU (Translation Buffer Unit) can now operate in non-secure
> mode, enabling Linux to utilize it through the IOMMU framework. This allows
> improved memory management capabilities in non-secure environments. With
> Agilex5 lifting this restriction, we are now extending the device tree
> bindings to support IOMMU for the Agilex5 SVC.
> 
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> ---
> Changes in v5:
> 	- Use contains enum instead of const
> Changes in v4:
> 	- Fix syntax / style error.
> 	- Refactor code not to use AllOf but instead use if directly.

Why? I would expect there allOf, so you won't re-indent when next
if:then: clause comes.

Anyway, slow down with your patches - one posting per 24h. That's like
three versions within that timeframe...


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

On 5/11/2025 4:23 pm, Krzysztof Kozlowski wrote:
> On Wed, Nov 05, 2025 at 10:28:01AM +0800, Khairul Anuar Romli wrote:
>> In Agilex5, the TBU (Translation Buffer Unit) can now operate in non-secure
>> mode, enabling Linux to utilize it through the IOMMU framework. This allows
>> improved memory management capabilities in non-secure environments. With
>> Agilex5 lifting this restriction, we are now extending the device tree
>> bindings to support IOMMU for the Agilex5 SVC.
>>
>> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
>> ---
>> Changes in v5:
>> 	- Use contains enum instead of const
>> Changes in v4:
>> 	- Fix syntax / style error.
>> 	- Refactor code not to use AllOf but instead use if directly.
> 
> Why? I would expect there allOf, so you won't re-indent when next
> if:then: clause comes.
> 
Sure, I will put back the AllOf so that the future changes that require 
different property can be added within that block.

> Anyway, slow down with your patches - one posting per 24h. That's like
> three versions within that timeframe...

Sure, I will slow down to send the next version.

> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
Can I add this in my next version?

> Best regards,
> Krzysztof
>