[v2] f2fs: Add sanity checks before unlinking and loading inodes

[PATCH v2 0/2] f2fs: Add sanity checks before unlinking and loading inodes

Nikola Z. Ivanov posted 2 patches 3 months, 1 week ago

Diff against v3 v4
Download series mbox

There is a newer version of this series

fs/f2fs/inode.c | 10 ++++++++++
fs/f2fs/namei.c | 27 +++++++++++++++++----------
2 files changed, 27 insertions(+), 10 deletions(-)

Expand all Fold all

[PATCH v2 0/2] f2fs: Add sanity checks before unlinking and loading inodes

Posted by Nikola Z. Ivanov 3 months, 1 week ago

This series is provoked by syzbot warnings caused by corrupted directory
inode with i_nlink == 1 that passes the initial sanity check which will
only mark the filesystem as corrupted in case i_nlink == 0.

Tests:
- fio/fsmark parallel create/unlink on VM with f2fs root filesystem.
- syzbot

Changelog:
Changes from v1:
- Rename exit label in f2fs_unlink().
- Add sanity check in sanity_check_inode() and remove it from f2fs_iget().
  as suggested by Chao Yu in order to detect on-disk corruption early.
https://lore.kernel.org/linux-f2fs-devel/d4b7c03c-6554-4407-b823-aecfcdf7dc3f@kernel.org/T/#t

Nikola Z. Ivanov (2):
  f2fs: Rename f2fs_unlink exit label
  f2fs: Add sanity checks before unlinking and loading  inodes

 fs/f2fs/inode.c | 10 ++++++++++
 fs/f2fs/namei.c | 27 +++++++++++++++++----------
 2 files changed, 27 insertions(+), 10 deletions(-)

-- 
2.51.0