[PATCH v2 1/3] dt-bindings: mtd: cdns,hp-nfc: Add iommu property

Khairul Anuar Romli posted 3 patches 2 months, 1 week ago
[PATCH v2 1/3] dt-bindings: mtd: cdns,hp-nfc: Add iommu property
Posted by Khairul Anuar Romli 2 months, 1 week ago
Agilex5 uses the cdns,hp-nfc binding for the nand-controller node.
To support IOMMU functionality, an iommus property needs to be added to the cdns,hp-nfc.yaml binding file.
This ensures the device tree binding correctly describes the IOMMU association for the NAND controller.

Signed-off-by: Adrian Ng Ho Yin <adrianhoyin.ng@altera.com>
Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
---
Changes in v2:
	- Updated the commit message to clarify the need for the changes and the hardware used of this changes.
---
 Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml b/Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml
index e1f4d7c35a88..73dc69cee4d8 100644
--- a/Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml
+++ b/Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml
@@ -40,6 +40,9 @@ properties:
   dmas:
     maxItems: 1
 
+  iommus:
+    maxItems: 1
+
   cdns,board-delay-ps:
     description: |
       Estimated Board delay. The value includes the total round trip
-- 
2.35.3
Re: [PATCH v2 1/3] dt-bindings: mtd: cdns,hp-nfc: Add iommu property
Posted by Krzysztof Kozlowski 2 months, 1 week ago
On 13/10/2025 07:17, Khairul Anuar Romli wrote:
> Agilex5 uses the cdns,hp-nfc binding for the nand-controller node.

That's redundant.

> To support IOMMU functionality, an iommus property needs to be added to the cdns,hp-nfc.yaml binding file.

As well... so just say there is IOMMU used by this <here goes device name>.

> This ensures the device tree binding correctly describes the IOMMU association for the NAND controller.

Redundant. Don't explain us how DT works. We all know. Explain what we
do not know - your hardware. I already ASKED FOR THAT.

Also, completely broken wrapping. Please read submitting patches before
you post next version.

Best regards,
Krzysztof