[PATCH 1/2] mfd: ls2kbmc: Fix an IS_ERR() vs NULL check in probe()

Dan Carpenter posted 2 patches 2 months, 2 weeks ago
[PATCH 1/2] mfd: ls2kbmc: Fix an IS_ERR() vs NULL check in probe()
Posted by Dan Carpenter 2 months, 2 weeks ago
The devm_kzalloc() function returns NULL on error so check for that
instead of error pointers.

Fixes: d952bba3fbb5 ("mfd: ls2kbmc: Add Loongson-2K BMC reset function support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/mfd/ls2k-bmc-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/ls2k-bmc-core.c b/drivers/mfd/ls2k-bmc-core.c
index e162b3c7c9f8..5f38514fa89e 100644
--- a/drivers/mfd/ls2k-bmc-core.c
+++ b/drivers/mfd/ls2k-bmc-core.c
@@ -469,7 +469,7 @@ static int ls2k_bmc_probe(struct pci_dev *dev, const struct pci_device_id *id)
 		return ret;
 
 	ddata = devm_kzalloc(&dev->dev, sizeof(*ddata), GFP_KERNEL);
-	if (IS_ERR(ddata)) {
+	if (!ddata) {
 		ret = -ENOMEM;
 		goto disable_pci;
 	}
-- 
2.51.0