[PATCH v2 1/6] dt-bindings: rtc: Add ST m41t93

Akhilesh Patil posted 6 patches 3 weeks, 1 day ago
[PATCH v2 1/6] dt-bindings: rtc: Add ST m41t93
Posted by Akhilesh Patil 3 weeks, 1 day ago
Document DT bindings for m41t93 rtc which supports time, date,
alarm, watchdog, square wave clock output provider, user sram
and 8 bit timer.

Signed-off-by: Akhilesh Patil <akhilesh@ee.iitb.ac.in>
---
 .../devicetree/bindings/rtc/st,m41t93.yaml    | 50 +++++++++++++++++++
 1 file changed, 50 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rtc/st,m41t93.yaml

diff --git a/Documentation/devicetree/bindings/rtc/st,m41t93.yaml b/Documentation/devicetree/bindings/rtc/st,m41t93.yaml
new file mode 100644
index 000000000000..bd593669cfa2
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/st,m41t93.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/st,m41t93.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ST M41T93 RTC and compatible
+
+maintainers:
+  - linux-rtc@vger.kernel.org
+
+description: |
+  ST M41T93 is spi based Real Time Clock (RTC) with time, date,
+  alarm, watchdog, square wave clock output, 8 bit timer and
+  7 bytes of user SRAM.
+
+properties:
+  compatible:
+    enum:
+      - st,m41t93
+
+  reg:
+    maxItems: 1
+
+  "#clock-cells":
+    const: 0
+
+required:
+  - compatible
+  - reg
+
+allOf:
+  - $ref: rtc.yaml
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    spi {
+      #address-cells = <1>;
+      #size-cells = <0>;
+      rtc@0 {
+        compatible = "st,m41t93";
+        reg = <0>;
+        #clock-cells = <0>;
+        spi-max-frequency = <2000000>;
+      };
+    };
+
-- 
2.34.1
Re: [PATCH v2 1/6] dt-bindings: rtc: Add ST m41t93
Posted by Krzysztof Kozlowski 3 weeks ago
On Wed, Sep 10, 2025 at 07:22:33PM +0530, Akhilesh Patil wrote:
> Document DT bindings for m41t93 rtc which supports time, date,
> alarm, watchdog, square wave clock output provider, user sram
> and 8 bit timer.
> 
> Signed-off-by: Akhilesh Patil <akhilesh@ee.iitb.ac.in>
> ---
>  .../devicetree/bindings/rtc/st,m41t93.yaml    | 50 +++++++++++++++++++
>  1 file changed, 50 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/st,m41t93.yaml
> 
> diff --git a/Documentation/devicetree/bindings/rtc/st,m41t93.yaml b/Documentation/devicetree/bindings/rtc/st,m41t93.yaml
> new file mode 100644
> index 000000000000..bd593669cfa2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/st,m41t93.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/st,m41t93.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ST M41T93 RTC and compatible
> +
> +maintainers:
> +  - linux-rtc@vger.kernel.org

Not much improved. This should be a person responsible/caring about this
hardware support in the kernel. Why would we want to take the binding if
no one cares about it?

> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  ST M41T93 is spi based Real Time Clock (RTC) with time, date,
> +  alarm, watchdog, square wave clock output, 8 bit timer and
> +  7 bytes of user SRAM.

Best regards,
Krzysztof
Re: [PATCH v2 1/6] dt-bindings: rtc: Add ST m41t93
Posted by Akhilesh Patil 2 weeks, 3 days ago
On Thu, Sep 11, 2025 at 09:43:09AM +0200, Krzysztof Kozlowski wrote:
> On Wed, Sep 10, 2025 at 07:22:33PM +0530, Akhilesh Patil wrote:
> > Document DT bindings for m41t93 rtc which supports time, date,
> > alarm, watchdog, square wave clock output provider, user sram
> > and 8 bit timer.
> > 
> > Signed-off-by: Akhilesh Patil <akhilesh@ee.iitb.ac.in>
> > ---
> >  .../devicetree/bindings/rtc/st,m41t93.yaml    | 50 +++++++++++++++++++
> >  1 file changed, 50 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/rtc/st,m41t93.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/rtc/st,m41t93.yaml b/Documentation/devicetree/bindings/rtc/st,m41t93.yaml
> > new file mode 100644
> > index 000000000000..bd593669cfa2
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/st,m41t93.yaml
> > @@ -0,0 +1,50 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/rtc/st,m41t93.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ST M41T93 RTC and compatible
> > +
> > +maintainers:
> > +  - linux-rtc@vger.kernel.org
> 
> Not much improved. This should be a person responsible/caring about this
> hardware support in the kernel. Why would we want to take the binding if
> no one cares about it?

Okay. As per get_maintainer.pl, linux driver corresponding to this binding does not have a dedicated
maintainer, hence it shows rtc subsystem maintainer (Alexandre Belloni).
Looking forward for your suggestion here.
What do you suggest to keep maintainer as Rob Herring or/and me ? as I see in
such cases Rob is the maintainer.

> 
> > +
> > +description: |
> 
> Do not need '|' unless you need to preserve formatting.

Sure. I will remove this. Thanks for pointing it out.

> 
> > +  ST M41T93 is spi based Real Time Clock (RTC) with time, date,
> > +  alarm, watchdog, square wave clock output, 8 bit timer and
> > +  7 bytes of user SRAM.
> 
> Best regards,
> Krzysztof

Regards,
Akhilesh
Re: [PATCH v2 1/6] dt-bindings: rtc: Add ST m41t93
Posted by Krzysztof Kozlowski 2 weeks, 1 day ago
On 15/09/2025 16:19, Akhilesh Patil wrote:
>>> +$id: http://devicetree.org/schemas/rtc/st,m41t93.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: ST M41T93 RTC and compatible
>>> +
>>> +maintainers:
>>> +  - linux-rtc@vger.kernel.org
>>
>> Not much improved. This should be a person responsible/caring about this
>> hardware support in the kernel. Why would we want to take the binding if
>> no one cares about it?
> 
> Okay. As per get_maintainer.pl, linux driver corresponding to this binding does not have a dedicated
> maintainer, hence it shows rtc subsystem maintainer (Alexandre Belloni).

And what did I express at v1?

> Looking forward for your suggestion here.
> What do you suggest to keep maintainer as Rob Herring or/and me ? as I see in
> such cases Rob is the maintainer.

No, I really doubt Rob cares about this particular hardware. Neither do
I, nor Conor.


Best regards,
Krzysztof