Convert QE QPIO devicetree binding to DT schema.
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
---
v5: New
---
.../fsl/cpm_qe/fsl,mpc8323-qe-pario-bank.yaml | 53 +++++++++++++++++++
.../bindings/soc/fsl/cpm_qe/qe/par_io.txt | 26 +--------
2 files changed, 54 insertions(+), 25 deletions(-)
create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,mpc8323-qe-pario-bank.yaml
diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,mpc8323-qe-pario-bank.yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,mpc8323-qe-pario-bank.yaml
new file mode 100644
index 000000000000..e6ba319a75c1
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,mpc8323-qe-pario-bank.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,mpc8323-qe-pario-bank.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale QUICC Engine Parallel I/O (QE PARIO) GPIO Bank
+
+maintainers:
+ - Christophe Leroy <christophe.leroy@csgroup.eu>
+
+description:
+ Bindings for the Freescale QUICC Engine Parallel I/O (PARIO) GPIO controller.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - fsl,chip-qe-pario-bank
+ - const: fsl,mpc8323-qe-pario-bank
+
+ reg:
+ maxItems: 1
+ description: Offset to the register set and its length.
+
+ gpio-controller: true
+
+ '#gpio-cells':
+ const: 2
+
+required:
+ - compatible
+ - reg
+ - gpio-controller
+ - '#gpio-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ qe_pio_a: gpio-controller@1400 {
+ compatible = "fsl,mpc8360-qe-pario-bank", "fsl,mpc8323-qe-pario-bank";
+ reg = <0x1400 0x18>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ qe_pio_e: gpio-controller@1460 {
+ compatible = "fsl,mpc8360-qe-pario-bank", "fsl,mpc8323-qe-pario-bank";
+ reg = <0x1460 0x18>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/par_io.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/par_io.txt
index 09b1b05fa677..782699c14567 100644
--- a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/par_io.txt
+++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/par_io.txt
@@ -24,28 +24,4 @@ par_io@1400 {
Note that "par_io" nodes are obsolete, and should not be used for
the new device trees. Instead, each Par I/O bank should be represented
-via its own gpio-controller node:
-
-Required properties:
-- #gpio-cells : should be "2".
-- compatible : should be "fsl,<chip>-qe-pario-bank",
- "fsl,mpc8323-qe-pario-bank".
-- reg : offset to the register set and its length.
-- gpio-controller : node to identify gpio controllers.
-
-Example:
- qe_pio_a: gpio-controller@1400 {
- #gpio-cells = <2>;
- compatible = "fsl,mpc8360-qe-pario-bank",
- "fsl,mpc8323-qe-pario-bank";
- reg = <0x1400 0x18>;
- gpio-controller;
- };
-
- qe_pio_e: gpio-controller@1460 {
- #gpio-cells = <2>;
- compatible = "fsl,mpc8360-qe-pario-bank",
- "fsl,mpc8323-qe-pario-bank";
- reg = <0x1460 0x18>;
- gpio-controller;
- };
+via its own gpio-controller node.
--
2.49.0On Mon, Sep 01, 2025 at 02:05:13PM +0200, Christophe Leroy wrote:
> Convert QE QPIO devicetree binding to DT schema.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
> v5: New
> ---
> .../fsl/cpm_qe/fsl,mpc8323-qe-pario-bank.yaml | 53 +++++++++++++++++++
This should move to bindings/gpio/
> .../bindings/soc/fsl/cpm_qe/qe/par_io.txt | 26 +--------
> 2 files changed, 54 insertions(+), 25 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,mpc8323-qe-pario-bank.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,mpc8323-qe-pario-bank.yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,mpc8323-qe-pario-bank.yaml
> new file mode 100644
> index 000000000000..e6ba319a75c1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,mpc8323-qe-pario-bank.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,mpc8323-qe-pario-bank.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale QUICC Engine Parallel I/O (QE PARIO) GPIO Bank
> +
> +maintainers:
> + - Christophe Leroy <christophe.leroy@csgroup.eu>
> +
> +description:
> + Bindings for the Freescale QUICC Engine Parallel I/O (PARIO) GPIO controller.
Just drop if nothing more to say than 'title'.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - fsl,chip-qe-pario-bank
> + - const: fsl,mpc8323-qe-pario-bank
> +
> + reg:
> + maxItems: 1
> + description: Offset to the register set and its length.
Drop the description. That's every reg.
> +
> + gpio-controller: true
> +
> + '#gpio-cells':
> + const: 2
> +
> +required:
> + - compatible
> + - reg
> + - gpio-controller
> + - '#gpio-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + qe_pio_a: gpio-controller@1400 {
Drop unused labels.
> + compatible = "fsl,mpc8360-qe-pario-bank", "fsl,mpc8323-qe-pario-bank";
Doesn't match the schema.
> + reg = <0x1400 0x18>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> +
> + qe_pio_e: gpio-controller@1460 {
> + compatible = "fsl,mpc8360-qe-pario-bank", "fsl,mpc8323-qe-pario-bank";
> + reg = <0x1460 0x18>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
Hi Rob,
Le 02/09/2025 à 23:24, Rob Herring a écrit :
> On Mon, Sep 01, 2025 at 02:05:13PM +0200, Christophe Leroy wrote:
>> Convert QE QPIO devicetree binding to DT schema.
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>> ---
>> v5: New
>> ---
>
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - enum:
>> + - fsl,chip-qe-pario-bank
>> + - const: fsl,mpc8323-qe-pario-bank
>> +
snip
>
>> + compatible = "fsl,mpc8360-qe-pario-bank", "fsl,mpc8323-qe-pario-bank";
>
> Doesn't match the schema.
>
Can you be more explicit ? Is it the 'mpc8360' ? It is the 'chip'.
bindings/soc/fsl/cpm_qe/qe/par_io.txt was saying:
- compatible : should be "fsl,<chip>-qe-pario-bank",
"fsl,mpc8323-qe-pario-bank".
Which I first translated in yaml as :
properties:
compatible:
items:
- enum:
- fsl,<chip>-qe-pario-bank
- const: fsl,mpc8323-qe-pario-bank
But 'make dt_binding_check' complained about the < > around 'chip' so I
removed them.
How should it be described ?
Thanks
Christophe
Rob, Conor, Krzysztof,
Can one of you or someone else help me with below comment from Rob ?
Le 03/09/2025 à 06:58, Christophe Leroy a écrit :
> Hi Rob,
>
> Le 02/09/2025 à 23:24, Rob Herring a écrit :
>> On Mon, Sep 01, 2025 at 02:05:13PM +0200, Christophe Leroy wrote:
>>> Convert QE QPIO devicetree binding to DT schema.
>>>
>>> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>>> ---
>>> v5: New
>>> ---
>>
>>> +
>>> +properties:
>>> + compatible:
>>> + items:
>>> + - enum:
>>> + - fsl,chip-qe-pario-bank
>>> + - const: fsl,mpc8323-qe-pario-bank
>>> +
>
> snip
>
>>
>>> + compatible = "fsl,mpc8360-qe-pario-bank", "fsl,mpc8323-qe-
>>> pario-bank";
>>
>> Doesn't match the schema.
>>
>
> Can you be more explicit ? Is it the 'mpc8360' ? It is the 'chip'.
>
>
> bindings/soc/fsl/cpm_qe/qe/par_io.txt was saying:
>
> - compatible : should be "fsl,<chip>-qe-pario-bank", "fsl,mpc8323-qe-
> pario-bank".
>
> Which I first translated in yaml as :
>
> properties:
> compatible:
> items:
> - enum:
> - fsl,<chip>-qe-pario-bank
> - const: fsl,mpc8323-qe-pario-bank
>
> But 'make dt_binding_check' complained about the < > around 'chip' so I
> removed them.
>
> How should it be described ?
>
Here is what we have in existing DTS upstream:
arch/powerpc/boot/dts/fsl/mpc8569mds.dts-
compatible = "fsl,mpc8569-qe-pario-bank",
arch/powerpc/boot/dts/fsl/mpc8569mds.dts:
"fsl,mpc8323-qe-pario-bank";
--
arch/powerpc/boot/dts/fsl/mpc8569mds.dts-
compatible = "fsl,mpc8569-qe-pario-bank",
arch/powerpc/boot/dts/fsl/mpc8569mds.dts:
"fsl,mpc8323-qe-pario-bank";
--
arch/powerpc/boot/dts/kmeter1.dts-
compatible = "fsl,mpc8360-qe-pario-bank",
arch/powerpc/boot/dts/kmeter1.dts:
"fsl,mpc8323-qe-pario-bank";
--
arch/powerpc/boot/dts/mpc832x_rdb.dts:
compatible = "fsl,mpc8323-qe-pario-bank";
--
arch/powerpc/boot/dts/mpc836x_rdk.dts- compatible =
"fsl,mpc8360-qe-pario-bank",
arch/powerpc/boot/dts/mpc836x_rdk.dts:
"fsl,mpc8323-qe-pario-bank";
--
arch/powerpc/boot/dts/mpc836x_rdk.dts- compatible =
"fsl,mpc8360-qe-pario-bank",
arch/powerpc/boot/dts/mpc836x_rdk.dts:
"fsl,mpc8323-qe-pario-bank";
If the problem in the DT schema is the fsl,chip-qe-pario-bank, should I
replace it with the two possible compatible we have in existing DTS, ie
"fsl,mpc8569-qe-pario-bank" and "fsl,mpc8360-qe-pario-bank", or should I
just ignore them are they are useless for the drivers, or else ?
Thanks
Christophe
© 2016 - 2025 Red Hat, Inc.