[PATCH v4 08/11] dt-bindings: iio: adc: ad7476: Drop redundant prop: true

Matti Vaittinen posted 11 patches 4 months ago
[PATCH v4 08/11] dt-bindings: iio: adc: ad7476: Drop redundant prop: true
Posted by Matti Vaittinen 4 months ago
The ad7476 supports a few variants with different power-supplies and
control GPIOs. The binding first unconditionally introduces all the
properties, and later sets them 'true' or 'false' based on the
combatible.

The 'true' seems to be implied by the initial property introduction so
the 'true' -branches in later conditional handling (based on the
compatible) can be omitted.

Drop the redundant true -branches.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>

---
Revision history:
 v3 => v4:
 - New patch
---
 .../bindings/iio/adc/adi,ad7476.yaml          | 54 +++++++++----------
 1 file changed, 24 insertions(+), 30 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7476.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7476.yaml
index d0cb32f136e5..db2a9662bd94 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7476.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7476.yaml
@@ -106,19 +106,17 @@ allOf:
         - vcc-supply
   # Devices with a vref
   - if:
-      properties:
-        compatible:
-          contains:
-            enum:
-              - adi,ad7091r
-              - adi,ad7273
-              - adi,ad7274
-              - adi,ad7475
-              - lltc,ltc2314-14
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - adi,ad7091r
+                - adi,ad7273
+                - adi,ad7274
+                - adi,ad7475
+                - lltc,ltc2314-14
     then:
-      properties:
-        vref-supply: true
-    else:
       properties:
         vref-supply: false
   # Devices with a vref where it is not optional
@@ -135,29 +133,25 @@ allOf:
       required:
         - vref-supply
   - if:
-      properties:
-        compatible:
-          contains:
-            enum:
-              - adi,ad7475
-              - adi,ad7495
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - adi,ad7475
+                - adi,ad7495
     then:
-      properties:
-        vdrive-supply: true
-    else:
       properties:
         vdrive-supply: false
   - if:
-      properties:
-        compatible:
-          contains:
-            enum:
-              - adi,ad7091
-              - adi,ad7091r
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - adi,ad7091
+                - adi,ad7091r
     then:
-      properties:
-        adi,conversion-start-gpios: true
-    else:
       properties:
         adi,conversion-start-gpios: false
 
-- 
2.50.1

Re: [PATCH v4 08/11] dt-bindings: iio: adc: ad7476: Drop redundant prop: true
Posted by Krzysztof Kozlowski 4 months ago
On Mon, Aug 11, 2025 at 11:51:50AM +0300, Matti Vaittinen wrote:
> The ad7476 supports a few variants with different power-supplies and
> control GPIOs. The binding first unconditionally introduces all the
> properties, and later sets them 'true' or 'false' based on the
> combatible.
> 
> The 'true' seems to be implied by the initial property introduction so
> the 'true' -branches in later conditional handling (based on the
> compatible) can be omitted.
> 
> Drop the redundant true -branches.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof