[PATCH v3 00/10] Support ROHM BD79105 ADC

Matti Vaittinen posted 10 patches 4 months, 1 week ago
There is a newer version of this series
.../bindings/iio/adc/adi,ad7476.yaml          |  54 ++
MAINTAINERS                                   |   5 +
drivers/iio/adc/ad7476.c                      | 461 +++++++++---------
3 files changed, 292 insertions(+), 228 deletions(-)
[PATCH v3 00/10] Support ROHM BD79105 ADC
Posted by Matti Vaittinen 4 months, 1 week ago
Add support for the ROHM BD79105 ADC
(and do some minor simplifications to the ad7476 driver while at it).

The first 2 patches were originally sent as an RFC:
https://lore.kernel.org/all/cover.1754041258.git.mazziesaccount@gmail.com/

Revision history:
  v2 => v3:
   - Drop 5/10 "Limit the scope of the chip_info"
   - Add 5/10 "use *_cansleep GPIO APIs"
   - Multiple fixes as suggested during v2 review. More accurate
     changelog included in individual patches

  v1 => v2:
   - Two new patches:
     5/10 "Limit the scope of the chip_info" and
     6/10 "Drop convstart chan_spec"
     Please, let me know if you think some of the changes should be
     squashed.
   - Multiple fixes as suggested during v1 review. More accurate
     changelog included in individual patches

  Simplification RFC => ROHM BD79105 support series v1:
   - Use spi_get_device_match_data()
   - Fix uV to mV conversion
   - Rewording of commit message
   - Added patches 3 to 8.

Matti Vaittinen (10):
  iio: adc: ad7476: Simplify chip type detection
  iio: adc: ad7476: Simplify scale handling
  iio: adc: ad7476: Use mV for internal reference
  iio: adc: ad7476: Use correct channel for bit info
  iio: adc: ad7476: use *_cansleep GPIO APIs
  iio: adc: ad7476: Drop convstart chan_spec
  iio: adc: ad7476: Conditionally call convstart
  dt-bindings: iio: adc: ad7476: Add ROHM bd79105
  iio: adc: ad7476: Support ROHM BD79105
  MAINTAINERS: A driver for simple 1-channel SPI ADCs

 .../bindings/iio/adc/adi,ad7476.yaml          |  54 ++
 MAINTAINERS                                   |   5 +
 drivers/iio/adc/ad7476.c                      | 461 +++++++++---------
 3 files changed, 292 insertions(+), 228 deletions(-)

-- 
2.50.1

Re: [PATCH v3 00/10] Support ROHM BD79105 ADC
Posted by Andy Shevchenko 4 months, 1 week ago
On Fri, Aug 8, 2025 at 10:50 AM Matti Vaittinen
<mazziesaccount@gmail.com> wrote:
>
> Add support for the ROHM BD79105 ADC
> (and do some minor simplifications to the ad7476 driver while at it).
>
> The first 2 patches were originally sent as an RFC:
> https://lore.kernel.org/all/cover.1754041258.git.mazziesaccount@gmail.com/

This version LGTM
Reviewed-by: Andy Shevchenko <andy@kernel.org>
with the exception of patches for DT and MAINTAINERS, I haven't even
looked at them.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v3 00/10] Support ROHM BD79105 ADC
Posted by Jonathan Cameron 4 months ago
On Fri, 8 Aug 2025 14:42:47 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Fri, Aug 8, 2025 at 10:50 AM Matti Vaittinen
> <mazziesaccount@gmail.com> wrote:
> >
> > Add support for the ROHM BD79105 ADC
> > (and do some minor simplifications to the ad7476 driver while at it).
> >
> > The first 2 patches were originally sent as an RFC:
> > https://lore.kernel.org/all/cover.1754041258.git.mazziesaccount@gmail.com/  
> 
> This version LGTM
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
> with the exception of patches for DT and MAINTAINERS, I haven't even
> looked at them.
> 

I took another quick look and just a few comments on the DT patch
which also need a DT maintainer review.


Jonathan