mm/damon/ops-common.c | 19 +++++++ mm/damon/ops-common.h | 3 ++ mm/damon/paddr.c | 29 ++--------- mm/damon/vaddr.c | 113 +++++++++++++++++++++++++++++++++++++++++- 4 files changed, 139 insertions(+), 25 deletions(-)
From: PanJason <pyyjason@gmail.com> Previously damos_stat only supoort paddr. This patch set adds support for damos_stat for vaddr. Also all different types of filters are supported. Functionality Test ================== I wrote a small test program which allocates 10GB of DRAM, use madvise(MADV_HUGEPAGE) to convert the base pages to 2MB huge pages Then my program does the following things in order: 1. Write sequentially to the whole 10GB region 2. Read the first 5GB region sequentially for 10 times 3. Sleep 5s 4. Read the second 5GB region sequentially for 10 times With a proper damon setting, we are expected to see df-passed to be 10GB and hot region move around with the read $ # Start damon record $sudo ./damo/damo record "./my_test/test" --monitoring_intervals 100000\ 1000000 2000000 $ # damon report $sudo ./damo/damo report access --snapshot_damos_filter reject none \ hugepage_size 2MiB 2MiB heatmap: # min/max temperatures: -900,000,000, 100,002,000, column size: 136.564 MiB intervals: sample 100 ms aggr 1 s (max access hz 10) # damos filters (df): reject none hugepage_size [2.000 MiB, 2.000 MiB] df-pass: # min/max temperatures: -663,075,528, 100,002,000, column size: 128.037 MiB 0 addr 86.082 TiB size 682.039 MiB access 0 hz age 9 s df-passed 0 B 1 addr 127.225 TiB size 466.039 MiB access 1.000 hz age 0 ns df-passed 468.000 MiB 2 addr 127.225 TiB size 51.785 MiB access 2.000 hz age 0 ns df-passed 50.000 MiB 3 addr 127.225 TiB size 785.219 MiB access 2.000 hz age 1 s df-passed 786.000 MiB 4 addr 127.226 TiB size 87.250 MiB access 1.000 hz age 1 s df-passed 88.000 MiB 5 addr 127.226 TiB size 982.719 MiB access 1.000 hz age 0 ns df-passed 982.000 MiB 6 addr 127.227 TiB size 109.191 MiB access 0 hz age 0 ns df-passed 110.000 MiB 7 addr 127.227 TiB size 103.945 MiB access 0 hz age 0 ns df-passed 104.000 MiB 8 addr 127.227 TiB size 935.539 MiB access 0 hz age 0 ns df-passed 934.000 MiB 9 addr 127.228 TiB size 386.547 MiB access 0 hz age 0 ns df-passed 388.000 MiB 10 addr 127.228 TiB size 579.824 MiB access 0 hz age 0 ns df-passed 580.000 MiB 11 addr 127.229 TiB size 168.676 MiB access 1.000 hz age 1 s df-passed 168.000 MiB 12 addr 127.229 TiB size 42.172 MiB access 1.000 hz age 1 s df-passed 42.000 MiB 13 addr 127.229 TiB size 63.254 MiB access 0 hz age 0 ns df-passed 64.000 MiB 14 addr 127.229 TiB size 147.598 MiB access 0 hz age 0 ns df-passed 146.000 MiB 15 addr 127.229 TiB size 112.453 MiB access 1.000 hz age 0 ns df-passed 114.000 MiB 16 addr 127.229 TiB size 168.684 MiB access 1.000 hz age 0 ns df-passed 168.000 MiB 17 addr 127.229 TiB size 810.512 MiB access 0 hz age 6 s df-passed 810.000 MiB 18 addr 127.230 TiB size 202.629 MiB access 0 hz age 6 s df-passed 204.000 MiB 19 addr 127.230 TiB size 206.859 MiB access 0 hz age 6 s df-passed 206.000 MiB 20 addr 127.231 TiB size 827.449 MiB access 0 hz age 6 s df-passed 828.000 MiB 21 addr 127.231 TiB size 326.004 MiB access 0 hz age 5 s df-passed 326.000 MiB 22 addr 127.232 TiB size 760.680 MiB access 0 hz age 5 s df-passed 760.000 MiB 23 addr 127.232 TiB size 148.238 MiB access 0 hz age 5 s df-passed 148.000 MiB 24 addr 127.233 TiB size 592.965 MiB access 0 hz age 5 s df-passed 594.000 MiB 25 addr 127.233 TiB size 321.695 MiB access 0 hz age 5 s df-passed 320.000 MiB 26 addr 127.233 TiB size 750.629 MiB access 0 hz age 5 s df-passed 752.000 MiB 27 addr 127.234 TiB size 73.078 MiB access 0 hz age 7 s df-passed 72.000 MiB 28 addr 127.234 TiB size 31.320 MiB access 0 hz age 7 s df-passed 28.000 MiB 29 addr 127.997 TiB size 132.000 KiB access 0 hz age 9 s df-passed 0 B memory bw estimate: 3.615 GiB per second df-passed: 3.615 GiB per second total size: 10.669 GiB df-passed 10.000 GiB record DAMON intervals: sample 100 ms, aggr 1 s $ # damon report again $sudo ./damo/damo report access --snapshot_damos_filter reject none \ hugepage_size 2MiB 2MiB heatmap: # min/max temperatures: -1,100,000,000, 300,001,000, column size: 136.564 MiB intervals: sample 100 ms aggr 1 s (max access hz 10) # damos filters (df): reject none hugepage_size [2.000 MiB, 2.000 MiB] df-pass: # min/max temperatures: -800,000,000, 300,001,000, column size: 128.037 MiB 0 addr 86.082 TiB size 682.039 MiB access 0 hz age 11 s df-passed 0 B 1 addr 127.225 TiB size 10.355 MiB access 1.000 hz age 0 ns df-passed 12.000 MiB 2 addr 127.225 TiB size 93.207 MiB access 1.000 hz age 0 ns df-passed 92.000 MiB 3 addr 127.225 TiB size 414.262 MiB access 1.000 hz age 0 ns df-passed 414.000 MiB 4 addr 127.225 TiB size 706.695 MiB access 1.000 hz age 3 s df-passed 708.000 MiB 5 addr 127.226 TiB size 78.523 MiB access 1.000 hz age 3 s df-passed 78.000 MiB 6 addr 127.226 TiB size 87.250 MiB access 1.000 hz age 3 s df-passed 88.000 MiB 7 addr 127.226 TiB size 384.469 MiB access 1.000 hz age 0 ns df-passed 384.000 MiB 8 addr 127.226 TiB size 256.312 MiB access 1.000 hz age 0 ns df-passed 256.000 MiB 9 addr 127.226 TiB size 427.191 MiB access 1.000 hz age 0 ns df-passed 428.000 MiB 10 addr 127.227 TiB size 319.023 MiB access 1.000 hz age 0 ns df-passed 318.000 MiB 11 addr 127.227 TiB size 212.688 MiB access 0 hz age 0 ns df-passed 212.000 MiB 12 addr 127.227 TiB size 531.711 MiB access 0 hz age 0 ns df-passed 532.000 MiB 13 addr 127.228 TiB size 541.164 MiB access 0 hz age 0 ns df-passed 542.000 MiB 14 addr 127.228 TiB size 135.293 MiB access 0 hz age 0 ns df-passed 136.000 MiB 15 addr 127.229 TiB size 289.914 MiB access 0 hz age 0 ns df-passed 290.000 MiB 16 addr 127.229 TiB size 29.516 MiB access 1.000 hz age 0 ns df-passed 28.000 MiB 17 addr 127.229 TiB size 68.879 MiB access 1.000 hz age 0 ns df-passed 70.000 MiB 18 addr 127.229 TiB size 42.172 MiB access 1.000 hz age 0 ns df-passed 42.000 MiB 19 addr 127.229 TiB size 134.941 MiB access 2.000 hz age 0 ns df-passed 134.000 MiB 20 addr 127.229 TiB size 314.871 MiB access 2.000 hz age 0 ns df-passed 316.000 MiB 21 addr 127.229 TiB size 112.457 MiB access 2.000 hz age 0 ns df-passed 112.000 MiB 22 addr 127.229 TiB size 50.656 MiB access 0 hz age 8 s df-passed 50.000 MiB 23 addr 127.230 TiB size 50.656 MiB access 0 hz age 8 s df-passed 52.000 MiB 24 addr 127.230 TiB size 911.828 MiB access 0 hz age 8 s df-passed 912.000 MiB 25 addr 127.230 TiB size 413.719 MiB access 0 hz age 8 s df-passed 412.000 MiB 26 addr 127.231 TiB size 103.434 MiB access 0 hz age 8 s df-passed 104.000 MiB 27 addr 127.231 TiB size 517.156 MiB access 0 hz age 8 s df-passed 518.000 MiB 28 addr 127.231 TiB size 880.207 MiB access 0 hz age 7 s df-passed 880.000 MiB 29 addr 127.232 TiB size 97.805 MiB access 0 hz age 7 s df-passed 98.000 MiB 30 addr 127.232 TiB size 108.672 MiB access 0 hz age 7 s df-passed 108.000 MiB 31 addr 127.232 TiB size 212.578 MiB access 0 hz age 7 s df-passed 212.000 MiB 32 addr 127.233 TiB size 212.578 MiB access 0 hz age 7 s df-passed 214.000 MiB 33 addr 127.233 TiB size 637.742 MiB access 0 hz age 7 s df-passed 636.000 MiB 34 addr 127.233 TiB size 102.602 MiB access 0 hz age 7 s df-passed 104.000 MiB 35 addr 127.234 TiB size 239.406 MiB access 0 hz age 7 s df-passed 238.000 MiB 36 addr 127.234 TiB size 513.020 MiB access 0 hz age 7 s df-passed 510.000 MiB 37 addr 127.997 TiB size 132.000 KiB access 0 hz age 11 s df-passed 0 B memory bw estimate: 3.948 GiB per second df-passed: 3.947 GiB per second total size: 10.669 GiB df-passed 10.000 GiB record DAMON intervals: sample 100 ms, aggr 1 s As you can see the total df-passed region is 10GiB and the hot region moves as the seq read keeps going PanJason (2): mm/damon: Move invalid folio and has filter to ops-common mm/damon: Add damos_stat support for vaddr mm/damon/ops-common.c | 19 +++++++ mm/damon/ops-common.h | 3 ++ mm/damon/paddr.c | 29 ++--------- mm/damon/vaddr.c | 113 +++++++++++++++++++++++++++++++++++++++++- 4 files changed, 139 insertions(+), 25 deletions(-) -- 2.47.3
Hello Pan (Or, should I call you Yueyang or Jason? Please let me know your
preferrence if you have),
On Tue, 29 Jul 2025 06:53:28 -0700 Yueyang Pan <pyyjason@gmail.com> wrote:
> From: PanJason <pyyjason@gmail.com>
>
> Previously damos_stat only supoort paddr. This patch set adds support
> for damos_stat for vaddr. Also all different types of filters are
> supported.
>
> Functionality Test
> ==================
> I wrote a small test program which allocates 10GB of DRAM, use
> madvise(MADV_HUGEPAGE) to convert the base pages to 2MB huge pages
> Then my program does the following things in order:
> 1. Write sequentially to the whole 10GB region
> 2. Read the first 5GB region sequentially for 10 times
> 3. Sleep 5s
> 4. Read the second 5GB region sequentially for 10 times
>
> With a proper damon setting, we are expected to see df-passed to be 10GB
> and hot region move around with the read
>
> $ # Start damon record
> $sudo ./damo/damo record "./my_test/test" --monitoring_intervals 100000\
> 1000000 2000000
You can use 'start' instead of 'record' for this test purpose.
--monitoring_intervals receive more human-friendly format, so you can do
'--monitoring_intervals 100ms 1s 2s'.
>
> $ # damon report
> $sudo ./damo/damo report access --snapshot_damos_filter reject none \
> hugepage_size 2MiB 2MiB
The --snapshot_damos_filter option means you want to make folios that not
having size 2 MiB not passed by the filter. You can ask same thing in more
intuitive way, like below.
--snapshot_damos_filter allow hugepage_size 2MiB 2MiB
> heatmap:
> # min/max temperatures: -900,000,000, 100,002,000, column size: 136.564 MiB
checkpatch.pl gives me below warning:
WARNING: Commit log lines starting with '#' are dropped by git as comments
I'd suggest adding four spaces prefix to quoted command outputs like this.
> intervals: sample 100 ms aggr 1 s (max access hz 10)
> # damos filters (df): reject none hugepage_size [2.000 MiB, 2.000 MiB]
> df-pass:
> # min/max temperatures: -663,075,528, 100,002,000, column size: 128.037 MiB
> 0 addr 86.082 TiB size 682.039 MiB access 0 hz age 9 s df-passed 0 B
> 1 addr 127.225 TiB size 466.039 MiB access 1.000 hz age 0 ns df-passed 468.000 MiB
[...]
> memory bw estimate: 3.615 GiB per second df-passed: 3.615 GiB per second
> total size: 10.669 GiB df-passed 10.000 GiB
> record DAMON intervals: sample 100 ms, aggr 1 s
>
> $ # damon report again
> $sudo ./damo/damo report access --snapshot_damos_filter reject none \
> hugepage_size 2MiB 2MiB
> heatmap:
> # min/max temperatures: -1,100,000,000, 300,001,000, column size: 136.564 MiB
> intervals: sample 100 ms aggr 1 s (max access hz 10)
> # damos filters (df): reject none hugepage_size [2.000 MiB, 2.000 MiB]
> df-pass:
> # min/max temperatures: -800,000,000, 300,001,000, column size: 128.037 MiB
> 0 addr 86.082 TiB size 682.039 MiB access 0 hz age 11 s df-passed 0 B
> 1 addr 127.225 TiB size 10.355 MiB access 1.000 hz age 0 ns df-passed 12.000 MiB
> 2 addr 127.225 TiB size 93.207 MiB access 1.000 hz age 0 ns df-passed 92.000 MiB
> 3 addr 127.225 TiB size 414.262 MiB access 1.000 hz age 0 ns df-passed 414.000 MiB
> 4 addr 127.225 TiB size 706.695 MiB access 1.000 hz age 3 s df-passed 708.000 MiB
> 5 addr 127.226 TiB size 78.523 MiB access 1.000 hz age 3 s df-passed 78.000 MiB
[...]
> total size: 10.669 GiB df-passed 10.000 GiB
> record DAMON intervals: sample 100 ms, aggr 1 s
>
> As you can see the total df-passed region is 10GiB and the hot region
> moves as the seq read keeps going
>
> PanJason (2):
> mm/damon: Move invalid folio and has filter to ops-common
> mm/damon: Add damos_stat support for vaddr
The changes look good overall, though I left a few comments for formatting and
unnecessary folio references that inherited from my original sin. Looking
forward to more discussions and next version of this great patch series!
Thanks,
SJ
[...]
© 2016 - 2025 Red Hat, Inc.