[PATCH v5 10/10] s390: vmlinux.lds.S: Reorder sections

Alexey Gladkov posted 10 patches 2 months, 1 week ago
There is a newer version of this series
[PATCH v5 10/10] s390: vmlinux.lds.S: Reorder sections
Posted by Alexey Gladkov 2 months, 1 week ago
Reorder the sections to be placed in the default segment. The
.vmlinux.info use :NONE to override the default segment and tell the
linker to not put the section in any segment at all.

>> s390x-linux-ld: .tmp_vmlinux1: warning: allocated section `.modinfo' not in segment
>> s390x-linux-ld: .tmp_vmlinux2: warning: allocated section `.modinfo' not in segment
>> s390x-linux-ld: vmlinux.unstripped: warning: allocated section `.modinfo' not in segment

Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: linux-s390@vger.kernel.org
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202506062053.zbkFBEnJ-lkp@intel.com/
Signed-off-by: Alexey Gladkov <legion@kernel.org>
---
 arch/s390/kernel/vmlinux.lds.S | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/s390/kernel/vmlinux.lds.S b/arch/s390/kernel/vmlinux.lds.S
index ff1ddba96352..3f2f90e38808 100644
--- a/arch/s390/kernel/vmlinux.lds.S
+++ b/arch/s390/kernel/vmlinux.lds.S
@@ -202,6 +202,11 @@ SECTIONS
 	. = ALIGN(PAGE_SIZE);
 	_end = . ;
 
+	/* Debugging sections.	*/
+	STABS_DEBUG
+	DWARF_DEBUG
+	ELF_DETAILS
+
 	/*
 	 * uncompressed image info used by the decompressor
 	 * it should match struct vmlinux_info
@@ -232,11 +237,6 @@ SECTIONS
 #endif
 	} :NONE
 
-	/* Debugging sections.	*/
-	STABS_DEBUG
-	DWARF_DEBUG
-	ELF_DETAILS
-
 	/*
 	 * Make sure that the .got.plt is either completely empty or it
 	 * contains only the three reserved double words.
-- 
2.50.1
Re: [PATCH v5 10/10] s390: vmlinux.lds.S: Reorder sections
Posted by Masahiro Yamada 2 months, 1 week ago
On Thu, Jul 24, 2025 at 10:50 PM Alexey Gladkov <legion@kernel.org> wrote:
>
> Reorder the sections to be placed in the default segment. The
> .vmlinux.info use :NONE to override the default segment and tell the
> linker to not put the section in any segment at all.
>
> >> s390x-linux-ld: .tmp_vmlinux1: warning: allocated section `.modinfo' not in segment
> >> s390x-linux-ld: .tmp_vmlinux2: warning: allocated section `.modinfo' not in segment
> >> s390x-linux-ld: vmlinux.unstripped: warning: allocated section `.modinfo' not in segment

Thank you for root-causing!



> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Alexander Gordeev <agordeev@linux.ibm.com>
> Cc: linux-s390@vger.kernel.org


Hi s390 maintainers,
I need this patch for kbuild tree.
Ack is appreciated.


> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506062053.zbkFBEnJ-lkp@intel.com/
> Signed-off-by: Alexey Gladkov <legion@kernel.org>
> ---
>  arch/s390/kernel/vmlinux.lds.S | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/s390/kernel/vmlinux.lds.S b/arch/s390/kernel/vmlinux.lds.S
> index ff1ddba96352..3f2f90e38808 100644
> --- a/arch/s390/kernel/vmlinux.lds.S
> +++ b/arch/s390/kernel/vmlinux.lds.S
> @@ -202,6 +202,11 @@ SECTIONS
>         . = ALIGN(PAGE_SIZE);
>         _end = . ;
>
> +       /* Debugging sections.  */
> +       STABS_DEBUG
> +       DWARF_DEBUG
> +       ELF_DETAILS
> +
>         /*
>          * uncompressed image info used by the decompressor
>          * it should match struct vmlinux_info
> @@ -232,11 +237,6 @@ SECTIONS
>  #endif
>         } :NONE
>
> -       /* Debugging sections.  */
> -       STABS_DEBUG
> -       DWARF_DEBUG
> -       ELF_DETAILS
> -
>         /*
>          * Make sure that the .got.plt is either completely empty or it
>          * contains only the three reserved double words.
> --
> 2.50.1
>


-- 
Best Regards
Masahiro Yamada
Re: [PATCH v5 10/10] s390: vmlinux.lds.S: Reorder sections
Posted by Heiko Carstens 2 months, 1 week ago
On Sat, Jul 26, 2025 at 07:59:16PM +0900, Masahiro Yamada wrote:
> On Thu, Jul 24, 2025 at 10:50 PM Alexey Gladkov <legion@kernel.org> wrote:
> >
> > Reorder the sections to be placed in the default segment. The
> > .vmlinux.info use :NONE to override the default segment and tell the
> > linker to not put the section in any segment at all.
> >
> > >> s390x-linux-ld: .tmp_vmlinux1: warning: allocated section `.modinfo' not in segment
> > >> s390x-linux-ld: .tmp_vmlinux2: warning: allocated section `.modinfo' not in segment
> > >> s390x-linux-ld: vmlinux.unstripped: warning: allocated section `.modinfo' not in segment
> 
> Thank you for root-causing!
> 
> > Cc: Heiko Carstens <hca@linux.ibm.com>
> > Cc: Vasily Gorbik <gor@linux.ibm.com>
> > Cc: Alexander Gordeev <agordeev@linux.ibm.com>
> > Cc: linux-s390@vger.kernel.org
> 
> Hi s390 maintainers,
> I need this patch for kbuild tree.
> Ack is appreciated.

Acked-by: Heiko Carstens <hca@linux.ibm.com>

But can you reorder the series so this patch comes before any of the
patches which introduces the above warnings, please?

Thanks!
Re: [PATCH v5 10/10] s390: vmlinux.lds.S: Reorder sections
Posted by Alexey Gladkov 2 months, 1 week ago
On Mon, Jul 28, 2025 at 04:01:09PM +0200, Heiko Carstens wrote:
> On Sat, Jul 26, 2025 at 07:59:16PM +0900, Masahiro Yamada wrote:
> > On Thu, Jul 24, 2025 at 10:50 PM Alexey Gladkov <legion@kernel.org> wrote:
> > >
> > > Reorder the sections to be placed in the default segment. The
> > > .vmlinux.info use :NONE to override the default segment and tell the
> > > linker to not put the section in any segment at all.
> > >
> > > >> s390x-linux-ld: .tmp_vmlinux1: warning: allocated section `.modinfo' not in segment
> > > >> s390x-linux-ld: .tmp_vmlinux2: warning: allocated section `.modinfo' not in segment
> > > >> s390x-linux-ld: vmlinux.unstripped: warning: allocated section `.modinfo' not in segment
> > 
> > Thank you for root-causing!
> > 
> > > Cc: Heiko Carstens <hca@linux.ibm.com>
> > > Cc: Vasily Gorbik <gor@linux.ibm.com>
> > > Cc: Alexander Gordeev <agordeev@linux.ibm.com>
> > > Cc: linux-s390@vger.kernel.org
> > 
> > Hi s390 maintainers,
> > I need this patch for kbuild tree.
> > Ack is appreciated.
> 
> Acked-by: Heiko Carstens <hca@linux.ibm.com>
> 
> But can you reorder the series so this patch comes before any of the
> patches which introduces the above warnings, please?

Sure. I will put it first to avoid warnings.

-- 
Rgrds, legion

Re: [PATCH v5 10/10] s390: vmlinux.lds.S: Reorder sections
Posted by Masahiro Yamada 2 months, 1 week ago
On Tue, Jul 29, 2025 at 12:18 AM Alexey Gladkov <legion@kernel.org> wrote:
>
> On Mon, Jul 28, 2025 at 04:01:09PM +0200, Heiko Carstens wrote:
> > On Sat, Jul 26, 2025 at 07:59:16PM +0900, Masahiro Yamada wrote:
> > > On Thu, Jul 24, 2025 at 10:50 PM Alexey Gladkov <legion@kernel.org> wrote:
> > > >
> > > > Reorder the sections to be placed in the default segment. The
> > > > .vmlinux.info use :NONE to override the default segment and tell the
> > > > linker to not put the section in any segment at all.
> > > >
> > > > >> s390x-linux-ld: .tmp_vmlinux1: warning: allocated section `.modinfo' not in segment
> > > > >> s390x-linux-ld: .tmp_vmlinux2: warning: allocated section `.modinfo' not in segment
> > > > >> s390x-linux-ld: vmlinux.unstripped: warning: allocated section `.modinfo' not in segment
> > >
> > > Thank you for root-causing!


I applied this series with patch re-ordering.



-- 
Best Regards
Masahiro Yamada