[PATCH 0/2] Fix up build issues with vpanic

Nam Cao posted 2 patches 2 months, 3 weeks ago
kernel/panic.c            | 2 +-
tools/objtool/noreturns.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
[PATCH 0/2] Fix up build issues with vpanic
Posted by Nam Cao 2 months, 3 weeks ago
Hi,

The newly introduced vpanic() has some build issues. This series fix them
up.

As the vpanic() is only in ftrace tree for now, it is probably best to let
this series goes to ftrace tree, if everyone is okay with that.

Best regards,
Nam

Nam Cao (2):
  objtool: Add vpanic() to the noreturn list
  panic: Fix up description of vpanic()

 kernel/panic.c            | 2 +-
 tools/objtool/noreturns.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
2.39.5
Re: [PATCH 0/2] Fix up build issues with vpanic
Posted by Steven Rostedt 2 months, 3 weeks ago
On Fri, 11 Jul 2025 13:20:41 +0200
Nam Cao <namcao@linutronix.de> wrote:

> Hi,
> 
> The newly introduced vpanic() has some build issues. This series fix them
> up.
> 
> As the vpanic() is only in ftrace tree for now, it is probably best to let
> this series goes to ftrace tree, if everyone is okay with that.

Since the bug is in my tree I'll take it, but can I get an acked-by
from Peter or Josh?

Thanks,

-- Steve
Re: [PATCH 0/2] Fix up build issues with vpanic
Posted by Peter Zijlstra 2 months, 3 weeks ago
On Fri, Jul 11, 2025 at 12:24:13PM -0400, Steven Rostedt wrote:
> On Fri, 11 Jul 2025 13:20:41 +0200
> Nam Cao <namcao@linutronix.de> wrote:
> 
> > Hi,
> > 
> > The newly introduced vpanic() has some build issues. This series fix them
> > up.
> > 
> > As the vpanic() is only in ftrace tree for now, it is probably best to let
> > this series goes to ftrace tree, if everyone is okay with that.
> 
> Since the bug is in my tree I'll take it, but can I get an acked-by
> from Peter or Josh?

Sure

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Re: [PATCH 0/2] Fix up build issues with vpanic
Posted by Peter Zijlstra 2 months, 3 weeks ago
On Fri, Jul 11, 2025 at 01:20:41PM +0200, Nam Cao wrote:
> Hi,
> 
> The newly introduced vpanic() has some build issues. This series fix them
> up.
> 
> As the vpanic() is only in ftrace tree for now, it is probably best to let
> this series goes to ftrace tree, if everyone is okay with that.

Does it make sense to make panic a static inline?
Re: [PATCH 0/2] Fix up build issues with vpanic
Posted by Nam Cao 2 months, 3 weeks ago
On Fri, Jul 11, 2025 at 01:28:44PM +0200, Peter Zijlstra wrote:
> On Fri, Jul 11, 2025 at 01:20:41PM +0200, Nam Cao wrote:
> > Hi,
> > 
> > The newly introduced vpanic() has some build issues. This series fix them
> > up.
> > 
> > As the vpanic() is only in ftrace tree for now, it is probably best to let
> > this series goes to ftrace tree, if everyone is okay with that.
> 
> Does it make sense to make panic a static inline?

I think no, code size increases by a few K:

text      data     bss     dec       hex      filename
12222627  6097658  479669  18799954  11edd52  vmlinux.before
12226703  6098618  479669  18804990  11ef0fe  vmlinux.after

(it's riscv64, I had issue converting on x86 because there's another
definition of panic())

Maybe faster? But panic() doesn't need to be fast, it's not called in
normal circumstances anyway.

Best regards,
Nam