[PATCH 0/2] i2c: omap: 2 Fixes

Christophe JAILLET posted 2 patches 3 months ago
drivers/i2c/busses/i2c-omap.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
[PATCH 0/2] i2c: omap: 2 Fixes
Posted by Christophe JAILLET 3 months ago
This small serie is a follow-up of [1].

For an unkwown reason I don't feel really confident with these patches.
Maybe because one is really old and the other one is related to
pm, which ordering is sometimes tricky (from my PoV at least).

They are compile tested only.

So review with care ;-)

[1]: https://lore.kernel.org/all/vhhxtsspywvuzkfgbn52hysghd6tdxhk32wv3wcnlqwhskto3f@h2bbhek3s4s3/

Christophe JAILLET (2):
  i2c: omap: Handle omap_i2c_init() errors in omap_i2c_probe()
  i2c: omap: Fix an error handling path in omap_i2c_probe()

 drivers/i2c/busses/i2c-omap.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

-- 
2.50.0
Re: [PATCH 0/2] i2c: omap: 2 Fixes
Posted by Andi Shyti 3 months ago
Hi Christophe,

> Christophe JAILLET (2):
>   i2c: omap: Handle omap_i2c_init() errors in omap_i2c_probe()
>   i2c: omap: Fix an error handling path in omap_i2c_probe()

they both make sense to me. It would be nice to have a comment on
the first patch from the Omap guys who have been very silent
whenever I asked for help on reviews.

I will apply them and if any concerns comes, we have time until
the pull request to revert.

Thanks,
Andi