[PATCH 1/2] ASoC: dt-bindings: Add Richtek RTQ9124

cy_huang@richtek.com posted 2 patches 6 months, 2 weeks ago
There is a newer version of this series
[PATCH 1/2] ASoC: dt-bindings: Add Richtek RTQ9124
Posted by cy_huang@richtek.com 6 months, 2 weeks ago
From: ChiYuan Huang <cy_huang@richtek.com>

Document the ASoC Richtek RTQ9124.

Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
---
 .../bindings/sound/richtek,rtq9124.yaml       | 57 +++++++++++++++++++
 1 file changed, 57 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/richtek,rtq9124.yaml

diff --git a/Documentation/devicetree/bindings/sound/richtek,rtq9124.yaml b/Documentation/devicetree/bindings/sound/richtek,rtq9124.yaml
new file mode 100644
index 000000000000..875f0fb226ee
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/richtek,rtq9124.yaml
@@ -0,0 +1,57 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/richtek,rtq9124.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Richtek RTQ9124 Automotive Audio Amplifier
+
+maintainers:
+  - ChiYuan Huang <cy_huang@richtek.com>
+
+description:
+  RTQ9124 is an ultra-low output noise, digital input, mono-channel Class-D
+  power amplifier that supports a 2.1MHz switching frequency. It integrates
+  both DC and AC load diagnostics, as well as real-time load monitoring to
+  assess speaker condition. The device operates from 4.5V to 18V and delivers
+  up to 30W output power.
+
+allOf:
+  - $ref: dai-common.yaml#
+
+properties:
+  compatible:
+    enum:
+      - richtek,rtq9124
+
+  reg:
+    maxItems: 1
+
+  '#sound-dai-cells':
+    const: 0
+
+  enable-gpios:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - '#sound-dai-cells'
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        amplifier@13 {
+            compatible = "richtek,rtq9124";
+            reg = <0x13>;
+            enable-gpios = <&gpio 26 GPIO_ACTIVE_HIGH>;
+            #sound-dai-cells = <0>;
+        };
+    };
-- 
2.34.1
Re: [PATCH 1/2] ASoC: dt-bindings: Add Richtek RTQ9124
Posted by Krzysztof Kozlowski 6 months, 2 weeks ago
On 06/06/2025 10:24, cy_huang@richtek.com wrote:
> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - richtek,rtq9124

Exactly the same as richtek,rt9123. Don't create same binding files for
similar devices.

Best regards,
Krzysztof
Re: [PATCH 1/2] ASoC: dt-bindings: Add Richtek RTQ9124
Posted by ChiYuan Huang 6 months, 2 weeks ago
On Fri, Jun 06, 2025 at 10:33:46AM +0200, Krzysztof Kozlowski wrote:
> On 06/06/2025 10:24, cy_huang@richtek.com wrote:
> > +
> > +allOf:
> > +  - $ref: dai-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - richtek,rtq9124
> 
> Exactly the same as richtek,rt9123. Don't create same binding files for
> similar devices.
> 
Do you mean to expand rtq9124 description in rt9123 binding file? Any example that I
can refer to?

> Best regards,
> Krzysztof
Re: [PATCH 1/2] ASoC: dt-bindings: Add Richtek RTQ9124
Posted by Krzysztof Kozlowski 6 months, 2 weeks ago
On 06/06/2025 10:43, ChiYuan Huang wrote:
> On Fri, Jun 06, 2025 at 10:33:46AM +0200, Krzysztof Kozlowski wrote:
>> On 06/06/2025 10:24, cy_huang@richtek.com wrote:
>>> +
>>> +allOf:
>>> +  - $ref: dai-common.yaml#
>>> +
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - richtek,rtq9124
>>
>> Exactly the same as richtek,rt9123. Don't create same binding files for
>> similar devices.
>>
> Do you mean to expand rtq9124 description in rt9123 binding file? 

Yes

> Any example that I
> can refer to?

Majority of bindings.

Best regards,
Krzysztof
Re: [PATCH 1/2] ASoC: dt-bindings: Add Richtek RTQ9124
Posted by ChiYuan Huang 6 months, 2 weeks ago
On Fri, Jun 06, 2025 at 10:50:14AM +0200, Krzysztof Kozlowski wrote:
> On 06/06/2025 10:43, ChiYuan Huang wrote:
> > On Fri, Jun 06, 2025 at 10:33:46AM +0200, Krzysztof Kozlowski wrote:
> >> On 06/06/2025 10:24, cy_huang@richtek.com wrote:
> >>> +
> >>> +allOf:
> >>> +  - $ref: dai-common.yaml#
> >>> +
> >>> +properties:
> >>> +  compatible:
> >>> +    enum:
> >>> +      - richtek,rtq9124
> >>
> >> Exactly the same as richtek,rt9123. Don't create same binding files for
> >> similar devices.
> >>
> > Do you mean to expand rtq9124 description in rt9123 binding file? 
> 
> Yes
> 
Compared to write a similar file, this should be better.
Will use that way in next revision.

Thanks.
> > Any example that I
> > can refer to?
> 
> Majority of bindings.
> 
> Best regards,
> Krzysztof