Introduce an interface to modify assignments within a group.
Modifications follow this format:
<Event configuration>:<Domain id>=<Assignment type>
The assignment type can be one of the following:
_ : No event configuration assigned
e : Event configuration assigned in exclusive mode
Domain id can be any valid domain ID number or '*' to update all the
domains.
Example:
$cd /sys/fs/resctrl
$cat mbm_L3_assignments
mbm_total_bytes:0=e;1=e
mbm_local_bytes:0=e;1=e
To unassign the configuration of mbm_total_bytes on domain 0:
$echo "mbm_total_bytes:0=_" > mbm_L3_assignments
$cat mbm_L3_assignments
mbm_total_bytes:0=_;1=e
mbm_local_bytes:0=e;1=e
To unassign the mbm_total_bytes configuration on all domains:
$echo "mbm_total_bytes:*=_" > mbm_L3_assignments
$cat mbm_L3_assignments
mbm_total_bytes:0=_;1=_
mbm_local_bytes:0=e;1=e
Signed-off-by: Babu Moger <babu.moger@amd.com>
---
v13: Few changes in mbm_L3_assignments_write() after moving the event config to evt_list.
Resolved conflicts caused by the recent FS/ARCH code restructure.
v12: New patch:
Assignment interface moved inside the group based the discussion
https://lore.kernel.org/lkml/CALPaoCiii0vXOF06mfV=kVLBzhfNo0SFqt4kQGwGSGVUqvr2Dg@mail.gmail.com/#t
---
Documentation/filesystems/resctrl.rst | 29 ++++-
fs/resctrl/internal.h | 9 ++
fs/resctrl/rdtgroup.c | 165 +++++++++++++++++++++++++-
3 files changed, 201 insertions(+), 2 deletions(-)
diff --git a/Documentation/filesystems/resctrl.rst b/Documentation/filesystems/resctrl.rst
index 2350c1f21f4e..d779554a2f91 100644
--- a/Documentation/filesystems/resctrl.rst
+++ b/Documentation/filesystems/resctrl.rst
@@ -515,7 +515,7 @@ When the "mba_MBps" mount option is used all CTRL_MON groups will also contain:
Event configuration: A valid event configuration listed in the
/sys/fs/resctrl/info/L3_MON/counter_configs directory.
- Domain ID: A valid domain ID number.
+ Domain ID: A valid domain ID number or '*' to update all the domains.
Assignment types:
@@ -532,6 +532,33 @@ When the "mba_MBps" mount option is used all CTRL_MON groups will also contain:
mbm_total_bytes:0=e;1=e
mbm_local_bytes:0=e;1=e
+ Modify the assignment states by writing to the interface file.
+
+ Example:
+ To unassign the configuration of mbm_total_bytes on domain 0:
+ ::
+
+ # echo "mbm_total_bytes:0=_" > mbm_L3_assignments
+ # cat mbm_L3_assignments
+ mbm_total_bytes:0=_;1=e
+ mbm_local_bytes:0=e;1=e
+
+ To unassign the mbm_total_bytes configuration on all domains:
+ ::
+
+ # echo "mbm_total_bytes:*=_" > mbm_L3_assignments
+ # cat mbm_L3_assignments
+ mbm_total_bytes:0=_;1=_
+ mbm_local_bytes:0=e;1=e
+
+ To assign the mbm_total_bytes configuration on all domains in exclusive mode:
+ ::
+
+ # echo "mbm_total_bytes:*=e" > mbm_L3_assignments
+ # cat mbm_L3_assignments
+ mbm_total_bytes:0=e;1=e
+ mbm_local_bytes:0=e;1=e
+
Resource allocation rules
-------------------------
diff --git a/fs/resctrl/internal.h b/fs/resctrl/internal.h
index 446cc9cc61df..a6069a5dfd49 100644
--- a/fs/resctrl/internal.h
+++ b/fs/resctrl/internal.h
@@ -51,6 +51,15 @@ static inline struct rdt_fs_context *rdt_fc2context(struct fs_context *fc)
return container_of(kfc, struct rdt_fs_context, kfc);
}
+/*
+ * Assignment types for mbm_cntr_assign mode
+ */
+enum {
+ ASSIGN_NONE = 0,
+ ASSIGN_EXCLUSIVE,
+ ASSIGN_INVALID,
+};
+
/**
* struct mon_evt - Entry in the event list of a resource
* @evtid: event id
diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c
index 8d970b99bbbd..ea1782723f81 100644
--- a/fs/resctrl/rdtgroup.c
+++ b/fs/resctrl/rdtgroup.c
@@ -2126,6 +2126,168 @@ static int mbm_L3_assignments_show(struct kernfs_open_file *of, struct seq_file
return ret;
}
+/*
+ * mbm_get_mon_event_by_name() - Return the mon_evt entry for the matching
+ * event name.
+ */
+static struct mon_evt *mbm_get_mon_event_by_name(struct rdt_resource *r,
+ char *name)
+{
+ struct mon_evt *mevt;
+
+ list_for_each_entry(mevt, &r->mon.evt_list, list) {
+ if (!strcmp(mevt->name, name))
+ return mevt;
+ }
+
+ return NULL;
+}
+
+static unsigned int resctrl_get_assing_type(char *assign)
+{
+ unsigned int mon_state = ASSIGN_NONE;
+ int len = strlen(assign);
+
+ if (!len || len > 1)
+ return ASSIGN_INVALID;
+
+ switch (*assign) {
+ case 'e':
+ mon_state = ASSIGN_EXCLUSIVE;
+ break;
+ case '_':
+ mon_state = ASSIGN_NONE;
+ break;
+ default:
+ mon_state = ASSIGN_INVALID;
+ break;
+ }
+
+ return mon_state;
+}
+
+static int resctrl_process_assign(struct rdt_resource *r, struct rdtgroup *rdtgrp,
+ char *config, char *tok)
+{
+ struct rdt_mon_domain *d;
+ char *dom_str, *id_str;
+ unsigned long dom_id = 0;
+ struct mon_evt *mevt;
+ int assign_type;
+ char domain[10];
+ bool found;
+ int ret;
+
+ mevt = mbm_get_mon_event_by_name(r, config);
+ if (!mevt) {
+ rdt_last_cmd_printf("Invalid assign configuration %s\n", config);
+ return -ENOENT;
+ }
+
+next:
+ if (!tok || tok[0] == '\0')
+ return 0;
+
+ /* Start processing the strings for each domain */
+ dom_str = strim(strsep(&tok, ";"));
+
+ id_str = strsep(&dom_str, "=");
+
+ /* Check for domain id '*' which means all domains */
+ if (id_str && *id_str == '*') {
+ d = NULL;
+ goto check_state;
+ } else if (!id_str || kstrtoul(id_str, 10, &dom_id)) {
+ rdt_last_cmd_puts("Missing domain id\n");
+ return -EINVAL;
+ }
+
+ /* Verify if the dom_id is valid */
+ found = false;
+ list_for_each_entry(d, &r->mon_domains, hdr.list) {
+ if (d->hdr.id == dom_id) {
+ found = true;
+ break;
+ }
+ }
+
+ if (!found) {
+ rdt_last_cmd_printf("Invalid domain id %ld\n", dom_id);
+ return -EINVAL;
+ }
+
+check_state:
+ assign_type = resctrl_get_assing_type(dom_str);
+
+ switch (assign_type) {
+ case ASSIGN_NONE:
+ ret = resctrl_unassign_cntr_event(r, d, rdtgrp, mevt->evtid);
+ break;
+ case ASSIGN_EXCLUSIVE:
+ ret = resctrl_assign_cntr_event(r, d, rdtgrp, mevt->evtid);
+ break;
+ case ASSIGN_INVALID:
+ ret = -EINVAL;
+ }
+
+ if (ret)
+ goto out_fail;
+
+ goto next;
+
+out_fail:
+ sprintf(domain, d ? "%ld" : "*", dom_id);
+
+ rdt_last_cmd_printf("Assign operation '%s:%s=%s' failed\n", config, domain, dom_str);
+
+ return ret;
+}
+
+static ssize_t mbm_L3_assignments_write(struct kernfs_open_file *of, char *buf,
+ size_t nbytes, loff_t off)
+{
+ struct rdt_resource *r = resctrl_arch_get_resource(RDT_RESOURCE_L3);
+ struct rdtgroup *rdtgrp;
+ char *token, *config;
+ int ret = 0;
+
+ /* Valid input requires a trailing newline */
+ if (nbytes == 0 || buf[nbytes - 1] != '\n')
+ return -EINVAL;
+
+ buf[nbytes - 1] = '\0';
+
+ rdtgrp = rdtgroup_kn_lock_live(of->kn);
+ if (!rdtgrp) {
+ rdtgroup_kn_unlock(of->kn);
+ return -ENOENT;
+ }
+ rdt_last_cmd_clear();
+
+ if (!resctrl_arch_mbm_cntr_assign_enabled(r)) {
+ rdt_last_cmd_puts("mbm_cntr_assign mode is not enabled\n");
+ rdtgroup_kn_unlock(of->kn);
+ return -EINVAL;
+ }
+
+ while ((token = strsep(&buf, "\n")) != NULL) {
+ /*
+ * The write command follows the following format:
+ * “<Assign config>:<domain_id>=<assign mode>”
+ * Extract Assign config first.
+ */
+ config = strsep(&token, ":");
+
+ ret = resctrl_process_assign(r, rdtgrp, config, token);
+ if (ret)
+ break;
+ }
+
+ rdtgroup_kn_unlock(of->kn);
+
+ return ret ?: nbytes;
+}
+
/* rdtgroup information files for one cache resource. */
static struct rftype res_common_files[] = {
{
@@ -2266,9 +2428,10 @@ static struct rftype res_common_files[] = {
},
{
.name = "mbm_L3_assignments",
- .mode = 0444,
+ .mode = 0644,
.kf_ops = &rdtgroup_kf_single_ops,
.seq_show = mbm_L3_assignments_show,
+ .write = mbm_L3_assignments_write,
},
{
.name = "mbm_assign_mode",
--
2.34.1
Hi Babu,
On Fri, May 16, 2025 at 12:56 AM Babu Moger <babu.moger@amd.com> wrote:
> diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c
> index 8d970b99bbbd..ea1782723f81 100644
> --- a/fs/resctrl/rdtgroup.c
> +++ b/fs/resctrl/rdtgroup.c
> @@ -2126,6 +2126,168 @@ static int mbm_L3_assignments_show(struct kernfs_open_file *of, struct seq_file
> return ret;
> }
>
> +/*
> + * mbm_get_mon_event_by_name() - Return the mon_evt entry for the matching
> + * event name.
> + */
> +static struct mon_evt *mbm_get_mon_event_by_name(struct rdt_resource *r,
> + char *name)
> +{
> + struct mon_evt *mevt;
> +
> + list_for_each_entry(mevt, &r->mon.evt_list, list) {
> + if (!strcmp(mevt->name, name))
> + return mevt;
> + }
> +
> + return NULL;
> +}
> +
> +static unsigned int resctrl_get_assing_type(char *assign)
> +{
> + unsigned int mon_state = ASSIGN_NONE;
> + int len = strlen(assign);
[ 395.013183] BUG: kernel NULL pointer dereference, address: 0000000000000000
[ 395.013426] #PF: supervisor read access in kernel mode
[ 395.013600] #PF: error_code(0x0000) - not-present page
[ 395.013779] PGD 39322c067 P4D 2a4f49067 PUD 2a4f4a067 PMD 0
[ 395.013973] Oops: Oops: 0000 [#1] SMP DEBUG_PAGEALLOC NOPTI
[ 395.014156] CPU: 37 UID: 0 PID: 24147 Comm: bash Not tainted
6.15.0-dbg-DEV #13 NONE
[ 395.014403] Hardware name: Google Astoria-Turin/astoria, BIOS
0.20241223.2-0 01/17/2025
[ 395.014652] RIP: 0010:strlen+0xb/0x20
[ 395.014778] Code: 66 66 66 66 66 66 2e 0f 1f 84 00 00 00 00 00 90
90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 f3 0f 1e fa 48 c7 c0 ff
ff ff ff <80> 7c 07 01 00 48 8d 40 01 75 f5 c3 cc cc cc cc cc 0f 1f 40
00 90
[ 395.015356] RSP: 0018:ffa000002f743d58 EFLAGS: 00010246
[ 395.015522] RAX: ffffffffffffffff RBX: ff11000129a00600 RCX: 0000000000000000
[ 395.015747] RDX: ff110001299f5253 RSI: ffffffff827b9651 RDI: 0000000000000000
[ 395.015968] RBP: 0000000000000000 R08: 000000000000003d R09: 0000000000000000
[ 395.016202] R10: ffffffff827b9652 R11: 0000000000000000 R12: ffffffff8305b7f8
[ 395.016421] R13: ff110001299f5240 R14: 0000000000000014 R15: 0000000000000000
[ 395.016644] FS: 00007f1281ff8b80(0000) GS:ff1100bdc8276000(0000)
knlGS:0000000000000000
[ 395.016893] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 395.017071] CR2: 0000000000000000 CR3: 0000000420bc8002 CR4: 0000000000771ef0
[ 395.017298] PKRU: 55555554
[ 395.017388] Call Trace:
[ 395.017471] <TASK>
[ 395.017545] mbm_L3_assignments_write+0x2d4/0x4e0
[ 395.017700] kernfs_fop_write_iter+0x132/0x1c0
[ 395.017851] vfs_write+0x2bf/0x3c0
[ 395.017963] ksys_write+0x82/0x100
[ 395.018074] do_syscall_64+0xee/0x210
[ 395.018198] ? exc_page_fault+0x81/0xe0
[ 395.018321] entry_SYSCALL_64_after_hwframe+0x77/0x7f
[ 395.018482] RIP: 0033:0x7f128177f8b3
[ 395.018598] Code: cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc
cc cc cc cc cc cc cc 48 8b 05 99 91 07 00 83 38 00 75 10 b8 01 00 00
00 0f 05 <48> 3d 01 f0 ff ff 73 4d c3 55 48 89 e5 41 57 41 56 53 50 48
89 d3
[ 395.019167] RSP: 002b:00007ffff66e80f8 EFLAGS: 00000246 ORIG_RAX:
0000000000000001
[ 395.019409] RAX: ffffffffffffffda RBX: 0000000000000014 RCX: 00007f128177f8b3
[ 395.019636] RDX: 0000000000000014 RSI: 0000000001eedb60 RDI: 0000000000000001
[ 395.019861] RBP: 00007ffff66e8120 R08: 0000000000000000 R09: 0000000000000000
[ 395.020081] R10: 00007ffff66e81b0 R11: 0000000000000246 R12: 0000000001eedb60
[ 395.020303] R13: 0000000000000001 R14: 00007f12817fa650 R15: 0000000000000014
[ 395.020532] </TASK>
> +
> + if (!len || len > 1)
> + return ASSIGN_INVALID;
> +
> + switch (*assign) {
> + case 'e':
> + mon_state = ASSIGN_EXCLUSIVE;
> + break;
> + case '_':
> + mon_state = ASSIGN_NONE;
> + break;
> + default:
> + mon_state = ASSIGN_INVALID;
> + break;
> + }
> +
> + return mon_state;
> +}
> +
> +static int resctrl_process_assign(struct rdt_resource *r, struct rdtgroup *rdtgrp,
> + char *config, char *tok)
> +{
> + struct rdt_mon_domain *d;
> + char *dom_str, *id_str;
> + unsigned long dom_id = 0;
> + struct mon_evt *mevt;
> + int assign_type;
> + char domain[10];
> + bool found;
> + int ret;
> +
> + mevt = mbm_get_mon_event_by_name(r, config);
> + if (!mevt) {
> + rdt_last_cmd_printf("Invalid assign configuration %s\n", config);
> + return -ENOENT;
> + }
> +
> +next:
> + if (!tok || tok[0] == '\0')
> + return 0;
> +
> + /* Start processing the strings for each domain */
> + dom_str = strim(strsep(&tok, ";"));
> +
> + id_str = strsep(&dom_str, "=");
If there's no '=' then dom_str becomes NULL...
> +
> + /* Check for domain id '*' which means all domains */
> + if (id_str && *id_str == '*') {
> + d = NULL;
> + goto check_state;
> + } else if (!id_str || kstrtoul(id_str, 10, &dom_id)) {
> + rdt_last_cmd_puts("Missing domain id\n");
> + return -EINVAL;
> + }
> +
> + /* Verify if the dom_id is valid */
> + found = false;
> + list_for_each_entry(d, &r->mon_domains, hdr.list) {
> + if (d->hdr.id == dom_id) {
> + found = true;
> + break;
> + }
> + }
> +
> + if (!found) {
> + rdt_last_cmd_printf("Invalid domain id %ld\n", dom_id);
> + return -EINVAL;
> + }
> +
> +check_state:
> + assign_type = resctrl_get_assing_type(dom_str);
then the resulting type of whatever this is supposed to mean is "panic"
Thanks,
-Peter
Hi Peter,
On 5/26/25 04:48, Peter Newman wrote:
> Hi Babu,
>
> On Fri, May 16, 2025 at 12:56 AM Babu Moger <babu.moger@amd.com> wrote:
>
>> diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c
>> index 8d970b99bbbd..ea1782723f81 100644
>> --- a/fs/resctrl/rdtgroup.c
>> +++ b/fs/resctrl/rdtgroup.c
>> @@ -2126,6 +2126,168 @@ static int mbm_L3_assignments_show(struct kernfs_open_file *of, struct seq_file
>> return ret;
>> }
>>
>> +/*
>> + * mbm_get_mon_event_by_name() - Return the mon_evt entry for the matching
>> + * event name.
>> + */
>> +static struct mon_evt *mbm_get_mon_event_by_name(struct rdt_resource *r,
>> + char *name)
>> +{
>> + struct mon_evt *mevt;
>> +
>> + list_for_each_entry(mevt, &r->mon.evt_list, list) {
>> + if (!strcmp(mevt->name, name))
>> + return mevt;
>> + }
>> +
>> + return NULL;
>> +}
>> +
>> +static unsigned int resctrl_get_assing_type(char *assign)
>> +{
>> + unsigned int mon_state = ASSIGN_NONE;
>> + int len = strlen(assign);
>
> [ 395.013183] BUG: kernel NULL pointer dereference, address: 0000000000000000
> [ 395.013426] #PF: supervisor read access in kernel mode
> [ 395.013600] #PF: error_code(0x0000) - not-present page
> [ 395.013779] PGD 39322c067 P4D 2a4f49067 PUD 2a4f4a067 PMD 0
> [ 395.013973] Oops: Oops: 0000 [#1] SMP DEBUG_PAGEALLOC NOPTI
> [ 395.014156] CPU: 37 UID: 0 PID: 24147 Comm: bash Not tainted
> 6.15.0-dbg-DEV #13 NONE
> [ 395.014403] Hardware name: Google Astoria-Turin/astoria, BIOS
> 0.20241223.2-0 01/17/2025
> [ 395.014652] RIP: 0010:strlen+0xb/0x20
> [ 395.014778] Code: 66 66 66 66 66 66 2e 0f 1f 84 00 00 00 00 00 90
> 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 f3 0f 1e fa 48 c7 c0 ff
> ff ff ff <80> 7c 07 01 00 48 8d 40 01 75 f5 c3 cc cc cc cc cc 0f 1f 40
> 00 90
> [ 395.015356] RSP: 0018:ffa000002f743d58 EFLAGS: 00010246
> [ 395.015522] RAX: ffffffffffffffff RBX: ff11000129a00600 RCX: 0000000000000000
> [ 395.015747] RDX: ff110001299f5253 RSI: ffffffff827b9651 RDI: 0000000000000000
> [ 395.015968] RBP: 0000000000000000 R08: 000000000000003d R09: 0000000000000000
> [ 395.016202] R10: ffffffff827b9652 R11: 0000000000000000 R12: ffffffff8305b7f8
> [ 395.016421] R13: ff110001299f5240 R14: 0000000000000014 R15: 0000000000000000
> [ 395.016644] FS: 00007f1281ff8b80(0000) GS:ff1100bdc8276000(0000)
> knlGS:0000000000000000
> [ 395.016893] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 395.017071] CR2: 0000000000000000 CR3: 0000000420bc8002 CR4: 0000000000771ef0
> [ 395.017298] PKRU: 55555554
> [ 395.017388] Call Trace:
> [ 395.017471] <TASK>
> [ 395.017545] mbm_L3_assignments_write+0x2d4/0x4e0
> [ 395.017700] kernfs_fop_write_iter+0x132/0x1c0
> [ 395.017851] vfs_write+0x2bf/0x3c0
> [ 395.017963] ksys_write+0x82/0x100
> [ 395.018074] do_syscall_64+0xee/0x210
> [ 395.018198] ? exc_page_fault+0x81/0xe0
> [ 395.018321] entry_SYSCALL_64_after_hwframe+0x77/0x7f
> [ 395.018482] RIP: 0033:0x7f128177f8b3
> [ 395.018598] Code: cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc
> cc cc cc cc cc cc cc 48 8b 05 99 91 07 00 83 38 00 75 10 b8 01 00 00
> 00 0f 05 <48> 3d 01 f0 ff ff 73 4d c3 55 48 89 e5 41 57 41 56 53 50 48
> 89 d3
> [ 395.019167] RSP: 002b:00007ffff66e80f8 EFLAGS: 00000246 ORIG_RAX:
> 0000000000000001
> [ 395.019409] RAX: ffffffffffffffda RBX: 0000000000000014 RCX: 00007f128177f8b3
> [ 395.019636] RDX: 0000000000000014 RSI: 0000000001eedb60 RDI: 0000000000000001
> [ 395.019861] RBP: 00007ffff66e8120 R08: 0000000000000000 R09: 0000000000000000
> [ 395.020081] R10: 00007ffff66e81b0 R11: 0000000000000246 R12: 0000000001eedb60
> [ 395.020303] R13: 0000000000000001 R14: 00007f12817fa650 R15: 0000000000000014
> [ 395.020532] </TASK>
>
Yes. Got it. Missing NULL check. Simplified the function now. Thanks
static unsigned int resctrl_get_assign_type(char *assign)
{
if (!assign || strlen(assign) != 1)
return ASSIGN_INVALID;
switch (*assign) {
case 'e':
return ASSIGN_EXCLUSIVE;
case '_':
return ASSIGN_NONE;
default:
return ASSIGN_INVALID;
}
}
>> +
>> + if (!len || len > 1)
>> + return ASSIGN_INVALID;
>> +
>> + switch (*assign) {
>> + case 'e':
>> + mon_state = ASSIGN_EXCLUSIVE;
>> + break;
>> + case '_':
>> + mon_state = ASSIGN_NONE;
>> + break;
>> + default:
>> + mon_state = ASSIGN_INVALID;
>> + break;
>> + }
>> +
>> + return mon_state;
>> +}
>> +
>> +static int resctrl_process_assign(struct rdt_resource *r, struct rdtgroup *rdtgrp,
>> + char *config, char *tok)
>> +{
>> + struct rdt_mon_domain *d;
>> + char *dom_str, *id_str;
>> + unsigned long dom_id = 0;
>> + struct mon_evt *mevt;
>> + int assign_type;
>> + char domain[10];
>> + bool found;
>> + int ret;
>> +
>> + mevt = mbm_get_mon_event_by_name(r, config);
>> + if (!mevt) {
>> + rdt_last_cmd_printf("Invalid assign configuration %s\n", config);
>> + return -ENOENT;
>> + }
>> +
>> +next:
>> + if (!tok || tok[0] == '\0')
>> + return 0;
>> +
>> + /* Start processing the strings for each domain */
>> + dom_str = strim(strsep(&tok, ";"));
>> +
>> + id_str = strsep(&dom_str, "=");
>
> If there's no '=' then dom_str becomes NULL...
Yea. That is correct.
>
>> +
>> + /* Check for domain id '*' which means all domains */
>> + if (id_str && *id_str == '*') {
>> + d = NULL;
>> + goto check_state;
>> + } else if (!id_str || kstrtoul(id_str, 10, &dom_id)) {
>> + rdt_last_cmd_puts("Missing domain id\n");
>> + return -EINVAL;
>> + }
>> +
>> + /* Verify if the dom_id is valid */
>> + found = false;
>> + list_for_each_entry(d, &r->mon_domains, hdr.list) {
>> + if (d->hdr.id == dom_id) {
>> + found = true;
>> + break;
>> + }
>> + }
>> +
>> + if (!found) {
>> + rdt_last_cmd_printf("Invalid domain id %ld\n", dom_id);
>> + return -EINVAL;
>> + }
>> +
>> +check_state:
>> + assign_type = resctrl_get_assing_type(dom_str);
>
> then the resulting type of whatever this is supposed to mean is "panic"
>
> Thanks,
> -Peter
>
--
Thanks
Babu Moger
© 2016 - 2025 Red Hat, Inc.