[PATCH v7 01/12] iio: adc: ad7768-1: reorganize driver headers

Jonathan Santos posted 12 patches 7 months, 1 week ago
There is a newer version of this series
[PATCH v7 01/12] iio: adc: ad7768-1: reorganize driver headers
Posted by Jonathan Santos 7 months, 1 week ago
Remove kernel.h since it adds a lot of unnecessary dependencies.
Add specific headers to ensure all functions and macros used in the driver
are directly declared.

Signed-off-by: Jonathan Santos <Jonathan.Santos@analog.com>
---
v7 Changes:
* New patch.
---
 drivers/iio/adc/ad7768-1.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
index 09e4ab76e2b6..e90bb5d50076 100644
--- a/drivers/iio/adc/ad7768-1.c
+++ b/drivers/iio/adc/ad7768-1.c
@@ -4,13 +4,15 @@
  *
  * Copyright 2017 Analog Devices Inc.
  */
+#include <linux/array_size.h>
 #include <linux/bitfield.h>
 #include <linux/clk.h>
+#include <linux/completion.h>
 #include <linux/delay.h>
 #include <linux/device.h>
 #include <linux/err.h>
 #include <linux/gpio/consumer.h>
-#include <linux/kernel.h>
+#include <linux/interrupt.h>
 #include <linux/module.h>
 #include <linux/regmap.h>
 #include <linux/regulator/consumer.h>
-- 
2.34.1
Re: [PATCH v7 01/12] iio: adc: ad7768-1: reorganize driver headers
Posted by Andy Shevchenko 7 months, 1 week ago
On Thu, May 08, 2025 at 02:03:04PM -0300, Jonathan Santos wrote:
> Remove kernel.h since it adds a lot of unnecessary dependencies.
> Add specific headers to ensure all functions and macros used in the driver
> are directly declared.

Suggested-by: ?

Nevertheless,
Reviewed-by: Andy Shevchenko <andy@kernel.org>

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v7 01/12] iio: adc: ad7768-1: reorganize driver headers
Posted by Jonathan Cameron 7 months, 1 week ago
On Thu, 8 May 2025 22:22:46 +0300
Andy Shevchenko <andy@kernel.org> wrote:

> On Thu, May 08, 2025 at 02:03:04PM -0300, Jonathan Santos wrote:
> > Remove kernel.h since it adds a lot of unnecessary dependencies.
> > Add specific headers to ensure all functions and macros used in the driver
> > are directly declared.  
> 
> Suggested-by: ?

Blamed-on: :)

Anyhow, I added it and picked this one up as good change on it's own
even if maybe some other bits of this series need a little more work.
> 
> Nevertheless,
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
>