[PATCH 3/3] media: i2c: ds90ub960: Fix uninitialized variable in ub960_rxport_bc_ser_config()

Dan Carpenter posted 3 patches 9 months, 2 weeks ago
[PATCH 3/3] media: i2c: ds90ub960: Fix uninitialized variable in ub960_rxport_bc_ser_config()
Posted by Dan Carpenter 9 months, 2 weeks ago
The "ret" variable is not initialized on success.  Set it to zero.

Fixes: e2a3b695bc5f ("media: i2c: ds90ub960: Configure serializer using back-channel")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/media/i2c/ds90ub960.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c
index cf104461b9a7..ed2cf9d247d1 100644
--- a/drivers/media/i2c/ds90ub960.c
+++ b/drivers/media/i2c/ds90ub960.c
@@ -2133,7 +2133,7 @@ static int ub960_rxport_bc_ser_config(struct ub960_rxport *rxport)
 	struct ub960_data *priv = rxport->priv;
 	struct device *dev = &priv->client->dev;
 	u8 nport = rxport->nport;
-	int ret;
+	int ret = 0;
 
 	/* Skip port if serializer's address is not known */
 	if (rxport->ser.addr < 0) {
-- 
2.47.2
Re: [PATCH 3/3] media: i2c: ds90ub960: Fix uninitialized variable in ub960_rxport_bc_ser_config()
Posted by Jai Luthra 9 months, 2 weeks ago
On Apr 30, 2025 at 11:27:42 +0300, Dan Carpenter wrote:
> The "ret" variable is not initialized on success.  Set it to zero.
> 
> Fixes: e2a3b695bc5f ("media: i2c: ds90ub960: Configure serializer using back-channel")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Reviewed-By: Jai Luthra <jai.luthra@ideasonboard.com>

> ---
>  drivers/media/i2c/ds90ub960.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c
> index cf104461b9a7..ed2cf9d247d1 100644
> --- a/drivers/media/i2c/ds90ub960.c
> +++ b/drivers/media/i2c/ds90ub960.c
> @@ -2133,7 +2133,7 @@ static int ub960_rxport_bc_ser_config(struct ub960_rxport *rxport)
>  	struct ub960_data *priv = rxport->priv;
>  	struct device *dev = &priv->client->dev;
>  	u8 nport = rxport->nport;
> -	int ret;
> +	int ret = 0;
>  
>  	/* Skip port if serializer's address is not known */
>  	if (rxport->ser.addr < 0) {
> -- 
> 2.47.2
> 

-- 
Thanks,
Jai