The "ret" variable is not initialized on the success path.

Fixes: a05744749600 ("media: i2c: ds90ub9xx: Set serializer temperature ramp")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/media/i2c/ds90ub960.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c
index 8075bffbac2b..cf104461b9a7 100644
--- a/drivers/media/i2c/ds90ub960.c
+++ b/drivers/media/i2c/ds90ub960.c
@@ -2058,7 +2058,7 @@ static int ub960_serializer_temp_ramp(struct ub960_rxport *rxport)
 	u8 temp_dynamic_cfg;
 	u8 nport = rxport->nport;
 	u8 ser_temp_code;
-	int ret;
+	int ret = 0;
 
 	/* Configure temp ramp only on UB953 */
 	if (!fwnode_device_is_compatible(rxport->ser.fwnode, "ti,ds90ub953-q1"))
-- 
2.47.2

Hi Dan,

On Apr 30, 2025 at 11:27:36 +0300, Dan Carpenter wrote:
> The "ret" variable is not initialized on the success path.
> 
> Fixes: a05744749600 ("media: i2c: ds90ub9xx: Set serializer temperature ramp")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  drivers/media/i2c/ds90ub960.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c
> index 8075bffbac2b..cf104461b9a7 100644
> --- a/drivers/media/i2c/ds90ub960.c
> +++ b/drivers/media/i2c/ds90ub960.c
> @@ -2058,7 +2058,7 @@ static int ub960_serializer_temp_ramp(struct ub960_rxport *rxport)
>  	u8 temp_dynamic_cfg;
>  	u8 nport = rxport->nport;
>  	u8 ser_temp_code;
> -	int ret;
> +	int ret = 0;

Oops, thanks for the fix.

Reviewed-By: Jai Luthra <jai.luthra@ideasonboard.com>

>  
>  	/* Configure temp ramp only on UB953 */
>  	if (!fwnode_device_is_compatible(rxport->ser.fwnode, "ti,ds90ub953-q1"))
> -- 
> 2.47.2
> 

-- 
Thanks,
Jai