[PATCH v2 0/3] mfd: exynos-lpass: Fix some error handling paths

Christophe JAILLET posted 3 patches 8 months ago
drivers/mfd/exynos-lpass.c | 31 +++++++++++++++++--------------
1 file changed, 17 insertions(+), 14 deletions(-)
[PATCH v2 0/3] mfd: exynos-lpass: Fix some error handling paths
Posted by Christophe JAILLET 8 months ago
This serie fixes several issues related to error handling paths in
drivers/mfd/exynos-lpass.c.

I've split it in 3 patches to ease review, but it could be merge in only
1 patch if preferred.

Patch 1: Fix a leak in the error handling path of the probe. It should
be straighforward. This patch is already R-b.

Patch 2: Slighly unsure of the order of the code. In the probe, we
enable pm, then lpass, so should we disable lpass, then pm?
This patch is already R-b.

Patch 3: Fix a leak in the error handling path of the probe. It should
be straighforward. This replaces patch 3 and 4 of the v1.


All these patches are compile tested only.

Christophe JAILLET (3):
  mfd: exynos-lpass: Fix an error handling path in exynos_lpass_probe()
  mfd: exynos-lpass: Avoid calling exynos_lpass_disable() twice in
    exynos_lpass_remove()
  mfd: exynos-lpass: Fix another error handling path in
    exynos_lpass_probe()

 drivers/mfd/exynos-lpass.c | 31 +++++++++++++++++--------------
 1 file changed, 17 insertions(+), 14 deletions(-)

-- 
2.49.0
Re: [PATCH v2 0/3] mfd: exynos-lpass: Fix some error handling paths
Posted by Lee Jones 7 months, 3 weeks ago
On Mon, 21 Apr 2025 17:00:32 +0200, Christophe JAILLET wrote:
> This serie fixes several issues related to error handling paths in
> drivers/mfd/exynos-lpass.c.
> 
> I've split it in 3 patches to ease review, but it could be merge in only
> 1 patch if preferred.
> 
> Patch 1: Fix a leak in the error handling path of the probe. It should
> be straighforward. This patch is already R-b.
> 
> [...]

Applied, thanks!

[1/3] mfd: exynos-lpass: Fix an error handling path in exynos_lpass_probe()
      commit: 8cc4952d1e8618eff474dc7154c6537db88178df
[2/3] mfd: exynos-lpass: Avoid calling exynos_lpass_disable() twice in exynos_lpass_remove()
      commit: cb931849ec1e71900eb54d0a377ae30e0bcfcffa
[3/3] mfd: exynos-lpass: Fix another error handling path in exynos_lpass_probe()
      commit: f408e20757afa3d8c719a8a804cd2c83262514dd

--
Lee Jones [李琼斯]