1. Patchew
  2. linux
  3. [PATCH net-next 0/4] RGMII mode clarification + am65-cpsw fix
  4. View patch

[PATCH net-next 2/4] dt-bindings: net: ti: k3-am654-cpsw-nuss: update phy-mode in example

Matthias Schiffer posted 4 patches 8 months, 1 week ago
[PATCH net-next 2/4] dt-bindings: net: ti: k3-am654-cpsw-nuss: update phy-mode in example
Posted by Matthias Schiffer 8 months, 1 week ago 
k3-am65-cpsw-nuss controllers have a fixed internal TX delay, so RXID
mode is not actually possible and will result in a warning from the
driver going forward.

Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
 .../devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
index b11894fbaec47..c8128b8ca74fb 100644
--- a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
+++ b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
@@ -282,7 +282,7 @@ examples:
                     ti,syscon-efuse = <&mcu_conf 0x200>;
                     phys = <&phy_gmii_sel 1>;
 
-                    phy-mode = "rgmii-rxid";
+                    phy-mode = "rgmii-id";
                     phy-handle = <&phy0>;
                 };
             };
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/
Re: [PATCH net-next 2/4] dt-bindings: net: ti: k3-am654-cpsw-nuss: update phy-mode in example
Posted by Roger Quadros 7 months, 3 weeks ago 
Hi Matthias,

On 15/04/2025 13:18, Matthias Schiffer wrote:
> k3-am65-cpsw-nuss controllers have a fixed internal TX delay, so RXID
> mode is not actually possible and will result in a warning from the
> driver going forward.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
>  .../devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml          | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
> index b11894fbaec47..c8128b8ca74fb 100644
> --- a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
> @@ -282,7 +282,7 @@ examples:
>                      ti,syscon-efuse = <&mcu_conf 0x200>;
>                      phys = <&phy_gmii_sel 1>;
>  
> -                    phy-mode = "rgmii-rxid";
> +                    phy-mode = "rgmii-id";
>                      phy-handle = <&phy0>;
>                  };
>              };

FYI the following TI boards using this driver are using "rgmii-rxid".
Will you be sending fixes to the device trees files?

arch/arm64/boot/dts/ti
k3-am625-beagleplay.dts:	phy-mode = "rgmii-rxid";
k3-am625-sk.dts:	phy-mode = "rgmii-rxid";
k3-am625-sk.dts.orig:	phy-mode = "rgmii-rxid";
k3-am62a7-sk.dts:	phy-mode = "rgmii-rxid";
k3-am62a-phycore-som.dtsi:	phy-mode = "rgmii-rxid";
k3-am62p5-sk.dts:	phy-mode = "rgmii-rxid";
k3-am62p5-sk.dts:	phy-mode = "rgmii-rxid";
k3-am62-phycore-som.dtsi:	phy-mode = "rgmii-rxid";
k3-am62-verdin-dev.dtsi:	phy-mode = "rgmii-rxid";
k3-am62-verdin.dtsi:	phy-mode = "rgmii-rxid";
k3-am62-verdin-ivy.dtsi:	phy-mode = "rgmii-rxid";
k3-am62x-phyboard-lyra.dtsi:	phy-mode = "rgmii-rxid";
k3-am62x-sk-common.dtsi:	phy-mode = "rgmii-rxid";
k3-am642-evm.dts:	phy-mode = "rgmii-rxid";
k3-am642-evm.dts:	phy-mode = "rgmii-rxid";
k3-am642-sk.dts:	phy-mode = "rgmii-rxid";
k3-am642-sk.dts:	phy-mode = "rgmii-rxid";
k3-am642-tqma64xxl-mbax4xxl.dts:	phy-mode = "rgmii-rxid";
k3-am642-tqma64xxl-mbax4xxl.dts:	/* phy-mode is fixed up to rgmii-rxid by prueth driver to account for
k3-am64-phycore-som.dtsi:	phy-mode = "rgmii-rxid";
k3-am654-base-board.dts:	phy-mode = "rgmii-rxid";
k3-am67a-beagley-ai.dts:	phy-mode = "rgmii-rxid";
k3-am68-sk-base-board.dts:	phy-mode = "rgmii-rxid";
k3-am69-sk.dts:	phy-mode = "rgmii-rxid";
k3-j7200-common-proc-board.dts:	phy-mode = "rgmii-rxid";
k3-j721e-beagleboneai64.dts:	phy-mode = "rgmii-rxid";
k3-j721e-common-proc-board.dts:	phy-mode = "rgmii-rxid";
k3-j721e-evm-gesi-exp-board.dtso:	phy-mode = "rgmii-rxid";
k3-j721e-evm-gesi-exp-board.dtso:	phy-mode = "rgmii-rxid";
k3-j721e-evm-gesi-exp-board.dtso:	phy-mode = "rgmii-rxid";
k3-j721e-evm-gesi-exp-board.dtso:	phy-mode = "rgmii-rxid";
k3-j721e-sk.dts:	phy-mode = "rgmii-rxid";
k3-j721s2-common-proc-board.dts:	phy-mode = "rgmii-rxid";
k3-j721s2-evm-gesi-exp-board.dtso:	phy-mode = "rgmii-rxid";
k3-j722s-evm.dts:	phy-mode = "rgmii-rxid";
k3-j784s4-j742s2-evm-common.dtsi:	phy-mode = "rgmii-rxid";
k3-j784s4-j742s2-evm-common.dtsi:	phy-mode = "rgmii-rxid";

-- 
cheers,
-roger
Re: [PATCH net-next 2/4] dt-bindings: net: ti: k3-am654-cpsw-nuss: update phy-mode in example
Posted by Matthias Schiffer 7 months, 2 weeks ago 
On Wed, 2025-04-30 at 17:22 +0300, Roger Quadros wrote:
> 
> Hi Matthias,
> 
> On 15/04/2025 13:18, Matthias Schiffer wrote:
> > k3-am65-cpsw-nuss controllers have a fixed internal TX delay, so RXID
> > mode is not actually possible and will result in a warning from the
> > driver going forward.
> > 
> > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> > ---
> >  .../devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml          | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
> > index b11894fbaec47..c8128b8ca74fb 100644
> > --- a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
> > +++ b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
> > @@ -282,7 +282,7 @@ examples:
> >                      ti,syscon-efuse = <&mcu_conf 0x200>;
> >                      phys = <&phy_gmii_sel 1>;
> >  
> > -                    phy-mode = "rgmii-rxid";
> > +                    phy-mode = "rgmii-id";
> >                      phy-handle = <&phy0>;
> >                  };
> >              };
> 
> FYI the following TI boards using this driver are using "rgmii-rxid".
> Will you be sending fixes to the device trees files?


Hi Roger,

as written in the cover letter, I haven't fixed any DTS for now, so projects
consuming Linux's Device Tree sources (like U-Boot) have some time to update
their driver first (as fixing the Device Trees without updating the driver would
break Ethernet).

Once a fix has been accepted in U-Boot (and preferably after we've come to an
agreement on the open questions...) I can also send a patch to update these
files.

Best,
Matthias



> 
> arch/arm64/boot/dts/ti
> k3-am625-beagleplay.dts:	phy-mode = "rgmii-rxid";
> k3-am625-sk.dts:	phy-mode = "rgmii-rxid";
> k3-am625-sk.dts.orig:	phy-mode = "rgmii-rxid";
> k3-am62a7-sk.dts:	phy-mode = "rgmii-rxid";
> k3-am62a-phycore-som.dtsi:	phy-mode = "rgmii-rxid";
> k3-am62p5-sk.dts:	phy-mode = "rgmii-rxid";
> k3-am62p5-sk.dts:	phy-mode = "rgmii-rxid";
> k3-am62-phycore-som.dtsi:	phy-mode = "rgmii-rxid";
> k3-am62-verdin-dev.dtsi:	phy-mode = "rgmii-rxid";
> k3-am62-verdin.dtsi:	phy-mode = "rgmii-rxid";
> k3-am62-verdin-ivy.dtsi:	phy-mode = "rgmii-rxid";
> k3-am62x-phyboard-lyra.dtsi:	phy-mode = "rgmii-rxid";
> k3-am62x-sk-common.dtsi:	phy-mode = "rgmii-rxid";
> k3-am642-evm.dts:	phy-mode = "rgmii-rxid";
> k3-am642-evm.dts:	phy-mode = "rgmii-rxid";
> k3-am642-sk.dts:	phy-mode = "rgmii-rxid";
> k3-am642-sk.dts:	phy-mode = "rgmii-rxid";
> k3-am642-tqma64xxl-mbax4xxl.dts:	phy-mode = "rgmii-rxid";
> k3-am642-tqma64xxl-mbax4xxl.dts:	/* phy-mode is fixed up to rgmii-rxid by prueth driver to account for
> k3-am64-phycore-som.dtsi:	phy-mode = "rgmii-rxid";
> k3-am654-base-board.dts:	phy-mode = "rgmii-rxid";
> k3-am67a-beagley-ai.dts:	phy-mode = "rgmii-rxid";
> k3-am68-sk-base-board.dts:	phy-mode = "rgmii-rxid";
> k3-am69-sk.dts:	phy-mode = "rgmii-rxid";
> k3-j7200-common-proc-board.dts:	phy-mode = "rgmii-rxid";
> k3-j721e-beagleboneai64.dts:	phy-mode = "rgmii-rxid";
> k3-j721e-common-proc-board.dts:	phy-mode = "rgmii-rxid";
> k3-j721e-evm-gesi-exp-board.dtso:	phy-mode = "rgmii-rxid";
> k3-j721e-evm-gesi-exp-board.dtso:	phy-mode = "rgmii-rxid";
> k3-j721e-evm-gesi-exp-board.dtso:	phy-mode = "rgmii-rxid";
> k3-j721e-evm-gesi-exp-board.dtso:	phy-mode = "rgmii-rxid";
> k3-j721e-sk.dts:	phy-mode = "rgmii-rxid";
> k3-j721s2-common-proc-board.dts:	phy-mode = "rgmii-rxid";
> k3-j721s2-evm-gesi-exp-board.dtso:	phy-mode = "rgmii-rxid";
> k3-j722s-evm.dts:	phy-mode = "rgmii-rxid";
> k3-j784s4-j742s2-evm-common.dtsi:	phy-mode = "rgmii-rxid";
> k3-j784s4-j742s2-evm-common.dtsi:	phy-mode = "rgmii-rxid";
> 

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/
Re: [PATCH net-next 2/4] dt-bindings: net: ti: k3-am654-cpsw-nuss: update phy-mode in example
Posted by Rob Herring (Arm) 8 months ago 
On Tue, 15 Apr 2025 12:18:02 +0200, Matthias Schiffer wrote:
> k3-am65-cpsw-nuss controllers have a fixed internal TX delay, so RXID
> mode is not actually possible and will result in a warning from the
> driver going forward.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
>  .../devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml          | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>
Re: [PATCH net-next 2/4] dt-bindings: net: ti: k3-am654-cpsw-nuss: update phy-mode in example
Posted by Andrew Lunn 8 months ago 
On Tue, Apr 15, 2025 at 12:18:02PM +0200, Matthias Schiffer wrote:
> k3-am65-cpsw-nuss controllers have a fixed internal TX delay, so RXID
> mode is not actually possible and will result in a warning from the
> driver going forward.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
>  .../devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml          | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
> index b11894fbaec47..c8128b8ca74fb 100644
> --- a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
> @@ -282,7 +282,7 @@ examples:
>                      ti,syscon-efuse = <&mcu_conf 0x200>;
>                      phys = <&phy_gmii_sel 1>;
>  
> -                    phy-mode = "rgmii-rxid";
> +                    phy-mode = "rgmii-id";

It would be good to enforce the phy-modes which are valid, which i
think are:

        case PHY_INTERFACE_MODE_RGMII_ID:
        case PHY_INTERFACE_MODE_RGMII_TXID:
        case PHY_INTERFACE_MODE_RMII:
        case PHY_INTERFACE_MODE_QSGMII:
        case PHY_INTERFACE_MODE_SGMII:
        case PHY_INTERFACE_MODE_USXGMII:

Anyway, this can be a follow up patch, it should not block this
patchset.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Re: [PATCH net-next 2/4] dt-bindings: net: ti: k3-am654-cpsw-nuss: update phy-mode in example
Posted by Maxime Chevallier 8 months, 1 week ago 
On Tue, 15 Apr 2025 12:18:02 +0200
Matthias Schiffer <matthias.schiffer@ew.tq-group.com> wrote:

> k3-am65-cpsw-nuss controllers have a fixed internal TX delay, so RXID
> mode is not actually possible and will result in a warning from the
> driver going forward.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Maxime

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.