The patchset modifies unnecessary duplicate NULL test on a
value in an expression, when the value has been NULL tested in a
previous expression.

Changes in v2:
- Suggested by Andy Shevchenko.

* Dropped patch files for media drivers from patchset as it is
not meant for outreachy applicants.
* Added full-stop sign to text in commit message.
* Added space around binary operators.
* Made code more breadable by adding a line break.
* Replace bitwise AND (&) with modulo (%) in expression.

Changes in v1:
- Suggested by Andy Shevchenko

* Patch for drivers/staging/media/av7110/sp8870.c and
  drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
  is split into two different patches in the patchset for use
  by the different driver maintainers.
* Added subject title for each of the separated patch.
* Patch 1: Removed unnecessary curl braces {} initially inserted.
* Patch 2: Unnecessary {} was also removed for v1.

Abraham Samuel Adekunle (1):
  staging: rtl8723bs: Prevent duplicate NULL tests on a value

 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  2 +-
 drivers/staging/rtl8723bs/core/rtw_xmit.c     | 58 +++++++++----------
 2 files changed, 30 insertions(+), 30 deletions(-)

-- 
2.34.1

On Fri, Apr 04, 2025 at 01:02:19AM +0100, Abraham Samuel Adekunle wrote:
> The patchset modifies unnecessary duplicate NULL test on a
> value in an expression, when the value has been NULL tested in a
> previous expression.

Nit, the subject line does nto have "staging:" in it, so I don't know
where this goes.

Also, it really reads as "this is an unnecessary patch" :)

And finally, for a single patch, there's usually not a need for a 0/X
email to describe it, everything should be in just the single patch
itself.

thanks,

greg k-h

On Sat, Apr 5, 2025 at 9:37 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Apr 04, 2025 at 01:02:19AM +0100, Abraham Samuel Adekunle wrote:
> > The patchset modifies unnecessary duplicate NULL test on a
> > value in an expression, when the value has been NULL tested in a
> > previous expression.
>
> Nit, the subject line does nto have "staging:" in it, so I don't know
> where this goes.
>
> Also, it really reads as "this is an unnecessary patch" :)

Argh, Not what I meant to say at all :)
Thank you.
>
> And finally, for a single patch, there's usually not a need for a 0/X
> email to describe it, everything should be in just the single patch
> itself.

It initially started as a patchset with modification for three different
drivers, one patch for each driver, but two were dropped from the patchset
for being media drivers.
So I thought I should add the cover letter to the only patch
left in the patchset so details about the changes can be made known.

I've made a note of this. Thanks.
Adekunle.

On Sat, 5 Apr 2025, Greg KH wrote:

> On Fri, Apr 04, 2025 at 01:02:19AM +0100, Abraham Samuel Adekunle wrote:
> > The patchset modifies unnecessary duplicate NULL test on a
> > value in an expression, when the value has been NULL tested in a
> > previous expression.
>
> Nit, the subject line does nto have "staging:" in it, so I don't know
> where this goes.
>
> Also, it really reads as "this is an unnecessary patch" :)

Technically, in English, if you have a noun that is being used as an
adjective and that noun is itself modified in some way, you should use a
hyphen:

Unnecessary-code cleanup patches

But something like

Remove unnecessary code

would have had no ambiguity at all.  Also everything you are doing is a
patch, so "patches" in the subject line doesn't seem very necessary.

julia


>
> And finally, for a single patch, there's usually not a need for a 0/X
> email to describe it, everything should be in just the single patch
> itself.
>
> thanks,
>
> greg k-h
>
>

On Sat, Apr 5, 2025 at 9:49 AM Julia Lawall <julia.lawall@inria.fr> wrote:
>
>
>
> On Sat, 5 Apr 2025, Greg KH wrote:
>
> > On Fri, Apr 04, 2025 at 01:02:19AM +0100, Abraham Samuel Adekunle wrote:
> > > The patchset modifies unnecessary duplicate NULL test on a
> > > value in an expression, when the value has been NULL tested in a
> > > previous expression.
> >
> > Nit, the subject line does nto have "staging:" in it, so I don't know
> > where this goes.
> >
> > Also, it really reads as "this is an unnecessary patch" :)
>
> Technically, in English, if you have a noun that is being used as an
> adjective and that noun is itself modified in some way, you should use a
> hyphen:
>
> Unnecessary-code cleanup patches

Yes this was what I intended to do. ;)
Thank you
>
> But something like
>
> Remove unnecessary code

Yes perfect.
>
> would have had no ambiguity at all.  Also everything you are doing is a
> patch, so "patches" in the subject line doesn't seem very necessary.
>

Thank you, Julia.

I will update it as necessary.

Adekunle.