1. Patchew
  2. linux
  3. [PATCH v2 0/5] Clean up patches for rtl8723bs driver
  4. View patch

[PATCH v2 5/5] staging: rtl8723bs: no space before tabs

Erick Karanja posted 5 patches 1 month, 1 week ago
[PATCH v2 5/5] staging: rtl8723bs: no space before tabs
Posted by Erick Karanja 1 month, 1 week ago 
Remove spaces before tabs to comply with the Linux kernel coding style
guidelines. Proper indentation using tabs improves code consistency
and readability.

Reported by checkpatch:

    WARNING: please, no space before tabs

Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
---
 drivers/staging/rtl8723bs/hal/hal_btcoex.c | 33 ++++------------------
 1 file changed, 6 insertions(+), 27 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
index 9105594d2dde..44f73baf1cb4 100644
--- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
+++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
@@ -9,14 +9,14 @@
 #include <hal_btcoex.h>
 #include <Mp_Precomp.h>
 
-/* 		Global variables */
+/*Global variables */
 
 struct btc_coexist GLBtCoexist;
 static u8 GLBtcWiFiInScanState;
 static u8 GLBtcWiFiInIQKState;
 
 /*  */
-/* 		Debug related function */
+/*Debug related function */
 /*  */
 static u8 halbtcoutsrc_IsBtCoexistAvailable(struct btc_coexist *pBtCoexist)
 {
@@ -84,9 +84,9 @@ static void halbtcoutsrc_LeaveLowPower(struct btc_coexist *pBtCoexist)
 	ready = _FAIL;
 #ifdef LPS_RPWM_WAIT_MS
 	timeout = LPS_RPWM_WAIT_MS;
-#else /*  !LPS_RPWM_WAIT_MS */
+#else
 	timeout = 30;
-#endif /*  !LPS_RPWM_WAIT_MS */
+#endif
 
 	stime = jiffies;
 	do {
@@ -401,9 +401,6 @@ static u8 halbtcoutsrc_Get(void *pBtcContext, u8 getType, void *pOutBuf)
 
 	case BTC_GET_U1_MAC_PHY_MODE:
 		*pu8 = BTC_SMSP;
-/* 			*pU1Tmp = BTC_DMSP; */
-/* 			*pU1Tmp = BTC_DMDP; */
-/* 			*pU1Tmp = BTC_MP_UNKNOWN; */
 		break;
 
 	case BTC_GET_U1_AP_NUM:
@@ -561,7 +558,7 @@ static u8 halbtcoutsrc_Set(void *pBtcContext, u8 setType, void *pInBuf)
 }
 
 /*  */
-/* 		IO related function */
+/* IO related function */
 /*  */
 static u8 halbtcoutsrc_Read1Byte(void *pBtcContext, u32 RegAddr)
 {
@@ -772,7 +769,7 @@ static void halbtcoutsrc_FillH2cCmd(void *pBtcContext, u8 elementId, u32 cmdLen,
 }
 
 /*  */
-/* 		Extern functions called by other module */
+/* Extern functions called by other module */
 /*  */
 static u8 EXhalbtcoutsrc_BindBtCoexWithAdapter(void *padapter)
 {
@@ -808,8 +805,6 @@ void hal_btcoex_Initialize(void *padapter)
 
 	pBtCoexist = &GLBtCoexist;
 
-	/* pBtCoexist->statistics.cntBind++; */
-
 	pBtCoexist->chipInterface = BTC_INTF_SDIO;
 
 	EXhalbtcoutsrc_BindBtCoexWithAdapter(padapter);
@@ -900,14 +895,12 @@ void EXhalbtcoutsrc_IpsNotify(struct btc_coexist *pBtCoexist, u8 type)
 		ipsType = BTC_IPS_ENTER;
 
 	/*  All notify is called in cmd thread, don't need to leave low power again */
-/* 	halbtcoutsrc_LeaveLowPower(pBtCoexist); */
 
 	if (pBtCoexist->boardInfo.btdmAntNum == 2)
 		EXhalbtc8723b2ant_IpsNotify(pBtCoexist, ipsType);
 	else if (pBtCoexist->boardInfo.btdmAntNum == 1)
 		EXhalbtc8723b1ant_IpsNotify(pBtCoexist, ipsType);
 
-/* 	halbtcoutsrc_NormalLowPower(pBtCoexist); */
 }
 
 void EXhalbtcoutsrc_LpsNotify(struct btc_coexist *pBtCoexist, u8 type)
@@ -952,14 +945,12 @@ void EXhalbtcoutsrc_ScanNotify(struct btc_coexist *pBtCoexist, u8 type)
 	}
 
 	/*  All notify is called in cmd thread, don't need to leave low power again */
-/* 	halbtcoutsrc_LeaveLowPower(pBtCoexist); */
 
 	if (pBtCoexist->boardInfo.btdmAntNum == 2)
 		EXhalbtc8723b2ant_ScanNotify(pBtCoexist, scanType);
 	else if (pBtCoexist->boardInfo.btdmAntNum == 1)
 		EXhalbtc8723b1ant_ScanNotify(pBtCoexist, scanType);
 
-/* 	halbtcoutsrc_NormalLowPower(pBtCoexist); */
 }
 
 void EXhalbtcoutsrc_ConnectNotify(struct btc_coexist *pBtCoexist, u8 action)
@@ -978,14 +969,12 @@ void EXhalbtcoutsrc_ConnectNotify(struct btc_coexist *pBtCoexist, u8 action)
 		assoType = BTC_ASSOCIATE_FINISH;
 
 	/*  All notify is called in cmd thread, don't need to leave low power again */
-/* 	halbtcoutsrc_LeaveLowPower(pBtCoexist); */
 
 	if (pBtCoexist->boardInfo.btdmAntNum == 2)
 		EXhalbtc8723b2ant_ConnectNotify(pBtCoexist, assoType);
 	else if (pBtCoexist->boardInfo.btdmAntNum == 1)
 		EXhalbtc8723b1ant_ConnectNotify(pBtCoexist, assoType);
 
-/* 	halbtcoutsrc_NormalLowPower(pBtCoexist); */
 }
 
 void EXhalbtcoutsrc_MediaStatusNotify(struct btc_coexist *pBtCoexist, enum
@@ -1006,14 +995,12 @@ void EXhalbtcoutsrc_MediaStatusNotify(struct btc_coexist *pBtCoexist, enum
 		mStatus = BTC_MEDIA_DISCONNECT;
 
 	/*  All notify is called in cmd thread, don't need to leave low power again */
-/* 	halbtcoutsrc_LeaveLowPower(pBtCoexist); */
 
 	if (pBtCoexist->boardInfo.btdmAntNum == 2)
 		EXhalbtc8723b2ant_MediaStatusNotify(pBtCoexist, mStatus);
 	else if (pBtCoexist->boardInfo.btdmAntNum == 1)
 		EXhalbtc8723b1ant_MediaStatusNotify(pBtCoexist, mStatus);
 
-/* 	halbtcoutsrc_NormalLowPower(pBtCoexist); */
 }
 
 void EXhalbtcoutsrc_SpecialPacketNotify(struct btc_coexist *pBtCoexist, u8 pktType)
@@ -1037,14 +1024,12 @@ void EXhalbtcoutsrc_SpecialPacketNotify(struct btc_coexist *pBtCoexist, u8 pktTy
 	}
 
 	/*  All notify is called in cmd thread, don't need to leave low power again */
-/* 	halbtcoutsrc_LeaveLowPower(pBtCoexist); */
 
 	if (pBtCoexist->boardInfo.btdmAntNum == 2)
 		EXhalbtc8723b2ant_SpecialPacketNotify(pBtCoexist, packetType);
 	else if (pBtCoexist->boardInfo.btdmAntNum == 1)
 		EXhalbtc8723b1ant_SpecialPacketNotify(pBtCoexist, packetType);
 
-/* 	halbtcoutsrc_NormalLowPower(pBtCoexist); */
 }
 
 void EXhalbtcoutsrc_BtInfoNotify(struct btc_coexist *pBtCoexist, u8 *tmpBuf, u8 length)
@@ -1055,14 +1040,12 @@ void EXhalbtcoutsrc_BtInfoNotify(struct btc_coexist *pBtCoexist, u8 *tmpBuf, u8
 	pBtCoexist->statistics.cntBtInfoNotify++;
 
 	/*  All notify is called in cmd thread, don't need to leave low power again */
-/* 	halbtcoutsrc_LeaveLowPower(pBtCoexist); */
 
 	if (pBtCoexist->boardInfo.btdmAntNum == 2)
 		EXhalbtc8723b2ant_BtInfoNotify(pBtCoexist, tmpBuf, length);
 	else if (pBtCoexist->boardInfo.btdmAntNum == 1)
 		EXhalbtc8723b1ant_BtInfoNotify(pBtCoexist, tmpBuf, length);
 
-/* 	halbtcoutsrc_NormalLowPower(pBtCoexist); */
 }
 
 void EXhalbtcoutsrc_HaltNotify(struct btc_coexist *pBtCoexist)
@@ -1102,14 +1085,12 @@ void EXhalbtcoutsrc_Periodical(struct btc_coexist *pBtCoexist)
 
 	/*  Periodical should be called in cmd thread, */
 	/*  don't need to leave low power again */
-/* 	halbtcoutsrc_LeaveLowPower(pBtCoexist); */
 
 	if (pBtCoexist->boardInfo.btdmAntNum == 2)
 		EXhalbtc8723b2ant_Periodical(pBtCoexist);
 	else if (pBtCoexist->boardInfo.btdmAntNum == 1)
 		EXhalbtc8723b1ant_Periodical(pBtCoexist);
 
-/* 	halbtcoutsrc_NormalLowPower(pBtCoexist); */
 }
 
 void EXhalbtcoutsrc_SetAntNum(u8 type, u8 antNum)
@@ -1119,10 +1100,8 @@ void EXhalbtcoutsrc_SetAntNum(u8 type, u8 antNum)
 		GLBtCoexist.boardInfo.btdmAntNum = antNum;
 	} else if (type == BT_COEX_ANT_TYPE_ANTDIV) {
 		GLBtCoexist.boardInfo.btdmAntNum = antNum;
-		/* GLBtCoexist.boardInfo.btdmAntPos = BTC_ANTENNA_AT_MAIN_PORT; */
 	} else if (type == BT_COEX_ANT_TYPE_DETECTED) {
 		GLBtCoexist.boardInfo.btdmAntNum = antNum;
-		/* GLBtCoexist.boardInfo.btdmAntPos = BTC_ANTENNA_AT_MAIN_PORT; */
 	}
 }
 
-- 
2.43.0
Re: [PATCH v2 5/5] staging: rtl8723bs: no space before tabs
Posted by Julia Lawall 1 month, 1 week ago 
On Tue, 1 Apr 2025, Erick Karanja wrote:

> Remove spaces before tabs to comply with the Linux kernel coding style
> guidelines. Proper indentation using tabs improves code consistency
> and readability.

Now you are mixing spaces and tabs with simply deleting commented code in
one patch.  They should be in separate patches, because those are
different things.

>
> Reported by checkpatch:
>
>     WARNING: please, no space before tabs
>
> Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/hal_btcoex.c | 33 ++++------------------
>  1 file changed, 6 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> index 9105594d2dde..44f73baf1cb4 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> @@ -9,14 +9,14 @@
>  #include <hal_btcoex.h>
>  #include <Mp_Precomp.h>
>
> -/* 		Global variables */
> +/*Global variables */

There should be a space after the /*

>
>  struct btc_coexist GLBtCoexist;
>  static u8 GLBtcWiFiInScanState;
>  static u8 GLBtcWiFiInIQKState;
>
>  /*  */
> -/* 		Debug related function */
> +/*Debug related function */
>  /*  */
>  static u8 halbtcoutsrc_IsBtCoexistAvailable(struct btc_coexist *pBtCoexist)
>  {
> @@ -84,9 +84,9 @@ static void halbtcoutsrc_LeaveLowPower(struct btc_coexist *pBtCoexist)
>  	ready = _FAIL;
>  #ifdef LPS_RPWM_WAIT_MS
>  	timeout = LPS_RPWM_WAIT_MS;
> -#else /*  !LPS_RPWM_WAIT_MS */
> +#else
>  	timeout = 30;
> -#endif /*  !LPS_RPWM_WAIT_MS */
> +#endif

I would be inclined to keep the comments on the #else and #endif.  That's
more documentation about which #if they belong with.

julia

>
>  	stime = jiffies;
>  	do {
> @@ -401,9 +401,6 @@ static u8 halbtcoutsrc_Get(void *pBtcContext, u8 getType, void *pOutBuf)
>
>  	case BTC_GET_U1_MAC_PHY_MODE:
>  		*pu8 = BTC_SMSP;
> -/* 			*pU1Tmp = BTC_DMSP; */
> -/* 			*pU1Tmp = BTC_DMDP; */
> -/* 			*pU1Tmp = BTC_MP_UNKNOWN; */
>  		break;
>
>  	case BTC_GET_U1_AP_NUM:
> @@ -561,7 +558,7 @@ static u8 halbtcoutsrc_Set(void *pBtcContext, u8 setType, void *pInBuf)
>  }
>
>  /*  */
> -/* 		IO related function */
> +/* IO related function */
>  /*  */
>  static u8 halbtcoutsrc_Read1Byte(void *pBtcContext, u32 RegAddr)
>  {
> @@ -772,7 +769,7 @@ static void halbtcoutsrc_FillH2cCmd(void *pBtcContext, u8 elementId, u32 cmdLen,
>  }
>
>  /*  */
> -/* 		Extern functions called by other module */
> +/* Extern functions called by other module */
>  /*  */
>  static u8 EXhalbtcoutsrc_BindBtCoexWithAdapter(void *padapter)
>  {
> @@ -808,8 +805,6 @@ void hal_btcoex_Initialize(void *padapter)
>
>  	pBtCoexist = &GLBtCoexist;
>
> -	/* pBtCoexist->statistics.cntBind++; */
> -
>  	pBtCoexist->chipInterface = BTC_INTF_SDIO;
>
>  	EXhalbtcoutsrc_BindBtCoexWithAdapter(padapter);
> @@ -900,14 +895,12 @@ void EXhalbtcoutsrc_IpsNotify(struct btc_coexist *pBtCoexist, u8 type)
>  		ipsType = BTC_IPS_ENTER;
>
>  	/*  All notify is called in cmd thread, don't need to leave low power again */
> -/* 	halbtcoutsrc_LeaveLowPower(pBtCoexist); */
>
>  	if (pBtCoexist->boardInfo.btdmAntNum == 2)
>  		EXhalbtc8723b2ant_IpsNotify(pBtCoexist, ipsType);
>  	else if (pBtCoexist->boardInfo.btdmAntNum == 1)
>  		EXhalbtc8723b1ant_IpsNotify(pBtCoexist, ipsType);
>
> -/* 	halbtcoutsrc_NormalLowPower(pBtCoexist); */
>  }
>
>  void EXhalbtcoutsrc_LpsNotify(struct btc_coexist *pBtCoexist, u8 type)
> @@ -952,14 +945,12 @@ void EXhalbtcoutsrc_ScanNotify(struct btc_coexist *pBtCoexist, u8 type)
>  	}
>
>  	/*  All notify is called in cmd thread, don't need to leave low power again */
> -/* 	halbtcoutsrc_LeaveLowPower(pBtCoexist); */
>
>  	if (pBtCoexist->boardInfo.btdmAntNum == 2)
>  		EXhalbtc8723b2ant_ScanNotify(pBtCoexist, scanType);
>  	else if (pBtCoexist->boardInfo.btdmAntNum == 1)
>  		EXhalbtc8723b1ant_ScanNotify(pBtCoexist, scanType);
>
> -/* 	halbtcoutsrc_NormalLowPower(pBtCoexist); */
>  }
>
>  void EXhalbtcoutsrc_ConnectNotify(struct btc_coexist *pBtCoexist, u8 action)
> @@ -978,14 +969,12 @@ void EXhalbtcoutsrc_ConnectNotify(struct btc_coexist *pBtCoexist, u8 action)
>  		assoType = BTC_ASSOCIATE_FINISH;
>
>  	/*  All notify is called in cmd thread, don't need to leave low power again */
> -/* 	halbtcoutsrc_LeaveLowPower(pBtCoexist); */
>
>  	if (pBtCoexist->boardInfo.btdmAntNum == 2)
>  		EXhalbtc8723b2ant_ConnectNotify(pBtCoexist, assoType);
>  	else if (pBtCoexist->boardInfo.btdmAntNum == 1)
>  		EXhalbtc8723b1ant_ConnectNotify(pBtCoexist, assoType);
>
> -/* 	halbtcoutsrc_NormalLowPower(pBtCoexist); */
>  }
>
>  void EXhalbtcoutsrc_MediaStatusNotify(struct btc_coexist *pBtCoexist, enum
> @@ -1006,14 +995,12 @@ void EXhalbtcoutsrc_MediaStatusNotify(struct btc_coexist *pBtCoexist, enum
>  		mStatus = BTC_MEDIA_DISCONNECT;
>
>  	/*  All notify is called in cmd thread, don't need to leave low power again */
> -/* 	halbtcoutsrc_LeaveLowPower(pBtCoexist); */
>
>  	if (pBtCoexist->boardInfo.btdmAntNum == 2)
>  		EXhalbtc8723b2ant_MediaStatusNotify(pBtCoexist, mStatus);
>  	else if (pBtCoexist->boardInfo.btdmAntNum == 1)
>  		EXhalbtc8723b1ant_MediaStatusNotify(pBtCoexist, mStatus);
>
> -/* 	halbtcoutsrc_NormalLowPower(pBtCoexist); */
>  }
>
>  void EXhalbtcoutsrc_SpecialPacketNotify(struct btc_coexist *pBtCoexist, u8 pktType)
> @@ -1037,14 +1024,12 @@ void EXhalbtcoutsrc_SpecialPacketNotify(struct btc_coexist *pBtCoexist, u8 pktTy
>  	}
>
>  	/*  All notify is called in cmd thread, don't need to leave low power again */
> -/* 	halbtcoutsrc_LeaveLowPower(pBtCoexist); */
>
>  	if (pBtCoexist->boardInfo.btdmAntNum == 2)
>  		EXhalbtc8723b2ant_SpecialPacketNotify(pBtCoexist, packetType);
>  	else if (pBtCoexist->boardInfo.btdmAntNum == 1)
>  		EXhalbtc8723b1ant_SpecialPacketNotify(pBtCoexist, packetType);
>
> -/* 	halbtcoutsrc_NormalLowPower(pBtCoexist); */
>  }
>
>  void EXhalbtcoutsrc_BtInfoNotify(struct btc_coexist *pBtCoexist, u8 *tmpBuf, u8 length)
> @@ -1055,14 +1040,12 @@ void EXhalbtcoutsrc_BtInfoNotify(struct btc_coexist *pBtCoexist, u8 *tmpBuf, u8
>  	pBtCoexist->statistics.cntBtInfoNotify++;
>
>  	/*  All notify is called in cmd thread, don't need to leave low power again */
> -/* 	halbtcoutsrc_LeaveLowPower(pBtCoexist); */
>
>  	if (pBtCoexist->boardInfo.btdmAntNum == 2)
>  		EXhalbtc8723b2ant_BtInfoNotify(pBtCoexist, tmpBuf, length);
>  	else if (pBtCoexist->boardInfo.btdmAntNum == 1)
>  		EXhalbtc8723b1ant_BtInfoNotify(pBtCoexist, tmpBuf, length);
>
> -/* 	halbtcoutsrc_NormalLowPower(pBtCoexist); */
>  }
>
>  void EXhalbtcoutsrc_HaltNotify(struct btc_coexist *pBtCoexist)
> @@ -1102,14 +1085,12 @@ void EXhalbtcoutsrc_Periodical(struct btc_coexist *pBtCoexist)
>
>  	/*  Periodical should be called in cmd thread, */
>  	/*  don't need to leave low power again */
> -/* 	halbtcoutsrc_LeaveLowPower(pBtCoexist); */
>
>  	if (pBtCoexist->boardInfo.btdmAntNum == 2)
>  		EXhalbtc8723b2ant_Periodical(pBtCoexist);
>  	else if (pBtCoexist->boardInfo.btdmAntNum == 1)
>  		EXhalbtc8723b1ant_Periodical(pBtCoexist);
>
> -/* 	halbtcoutsrc_NormalLowPower(pBtCoexist); */
>  }
>
>  void EXhalbtcoutsrc_SetAntNum(u8 type, u8 antNum)
> @@ -1119,10 +1100,8 @@ void EXhalbtcoutsrc_SetAntNum(u8 type, u8 antNum)
>  		GLBtCoexist.boardInfo.btdmAntNum = antNum;
>  	} else if (type == BT_COEX_ANT_TYPE_ANTDIV) {
>  		GLBtCoexist.boardInfo.btdmAntNum = antNum;
> -		/* GLBtCoexist.boardInfo.btdmAntPos = BTC_ANTENNA_AT_MAIN_PORT; */
>  	} else if (type == BT_COEX_ANT_TYPE_DETECTED) {
>  		GLBtCoexist.boardInfo.btdmAntNum = antNum;
> -		/* GLBtCoexist.boardInfo.btdmAntPos = BTC_ANTENNA_AT_MAIN_PORT; */
>  	}
>  }
>
> --
> 2.43.0
>
>
>
Re: [PATCH v2 5/5] staging: rtl8723bs: no space before tabs
Posted by Greg KH 1 month, 1 week ago 
On Tue, Apr 01, 2025 at 07:59:37PM +0300, Erick Karanja wrote:
> Remove spaces before tabs to comply with the Linux kernel coding style
> guidelines. Proper indentation using tabs improves code consistency
> and readability.
> 
> Reported by checkpatch:
> 
>     WARNING: please, no space before tabs
> 
> Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/hal_btcoex.c | 33 ++++------------------
>  1 file changed, 6 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> index 9105594d2dde..44f73baf1cb4 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> @@ -9,14 +9,14 @@
>  #include <hal_btcoex.h>
>  #include <Mp_Precomp.h>
>  
> -/* 		Global variables */
> +/*Global variables */

Does that look right?  (hint, it isn't...)

Always put a space after the /* and before text.  You removed the one
that was there already :(

thanks,

greg k-h

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.