Hi, Ryan,
On 01.04.2025 19:13, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
>
> Enable GMAC0 interface for sama7d65_curiosity board.
>
> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
> ---
> .../dts/microchip/at91-sama7d65_curiosity.dts | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
>
> diff --git a/arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts
> index 30fdc4f55a3b..441370dbb4c2 100644
> --- a/arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts
> +++ b/arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts
> @@ -105,7 +105,58 @@ &main_xtal {
> clock-frequency = <24000000>;
> };
>
> +&gmac0 {
Please keep nodes alphanumerically sorted.
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_gmac0_default
> + &pinctrl_gmac0_mdio_default
> + &pinctrl_gmac0_txck_default
> + &pinctrl_gmac0_phy_irq>;
> + phy-mode = "rgmii-id";
> + status = "okay";
> +
> + ethernet-phy@7 {
> + reg = <0x7>;
> + interrupt-parent = <&pioa>;
> + interrupts = <PIN_PC1 IRQ_TYPE_LEVEL_LOW>;
> + status = "okay";
No need for status here, default is okay.
> + };
> +};
Missing blank line here.
As this are mainly cosmetics I will adjust while applying.
Thank you,
Claudiu
> &pioa {
> + pinctrl_gmac0_default: gmac0-default {
> + pinmux = <PIN_PA26__G0_TX0>,
> + <PIN_PA27__G0_TX1>,
> + <PIN_PB4__G0_TX2>,
> + <PIN_PB5__G0_TX3>,
> + <PIN_PA29__G0_RX0>,
> + <PIN_PA30__G0_RX1>,
> + <PIN_PB2__G0_RX2>,
> + <PIN_PB6__G0_RX3>,
> + <PIN_PA25__G0_TXCTL>,
> + <PIN_PB3__G0_RXCK>,
> + <PIN_PA28__G0_RXCTL>;
> + slew-rate = <0>;
> + bias-disable;
> + };
> +
> + pinctrl_gmac0_mdio_default: gmac0-mdio-default {
> + pinmux = <PIN_PA31__G0_MDC>,
> + <PIN_PB0__G0_MDIO>;
> + bias-disable;
> + };
> +
> + pinctrl_gmac0_phy_irq: gmac0-phy-irq {
> + pinmux = <PIN_PC1__GPIO>;
> + bias-disable;
> + };
> +
> + pinctrl_gmac0_txck_default: gmac0-txck-default {
> + pinmux = <PIN_PB1__G0_REFCK>;
> + slew-rate = <0>;
> + bias-pull-up;
> + };
> +
> pinctrl_i2c10_default: i2c10-default{
> pinmux = <PIN_PB19__FLEXCOM10_IO1>,
> <PIN_PB20__FLEXCOM10_IO0>;