[PATCH v2 02/15] dt-bindings: mfd: syscon: add microchip,sama7d65-sfrbu

Ryan.Wanner@microchip.com posted 15 patches 1 year ago
There is a newer version of this series
[PATCH v2 02/15] dt-bindings: mfd: syscon: add microchip,sama7d65-sfrbu
Posted by Ryan.Wanner@microchip.com 1 year ago
From: Ryan Wanner <Ryan.Wanner@microchip.com>

Add SAMA7D65 SFRBU compatible string to DT bindings documentation

Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 51d896c88dafa..727292ffe092e 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -91,6 +91,7 @@ select:
           - microchip,mpfs-sysreg-scb
           - microchip,sam9x60-sfr
           - microchip,sama7d65-ddr3phy
+          - microchip,sama7d65-sfrbu
           - microchip,sama7g5-ddr3phy
           - mscc,ocelot-cpu-syscon
           - mstar,msc313-pmsleep
-- 
2.43.0
Re: [PATCH v2 02/15] dt-bindings: mfd: syscon: add microchip,sama7d65-sfrbu
Posted by Krzysztof Kozlowski 12 months ago
On Mon, Feb 10, 2025 at 02:13:02PM -0700, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
> 
> Add SAMA7D65 SFRBU compatible string to DT bindings documentation
> 
> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
> ---
>  Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 51d896c88dafa..727292ffe092e 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -91,6 +91,7 @@ select:
>            - microchip,mpfs-sysreg-scb
>            - microchip,sam9x60-sfr
>            - microchip,sama7d65-ddr3phy
> +          - microchip,sama7d65-sfrbu

You got comment on #1 of your v1, so if you make exactly the same
mistake in other patches then fix it there as well.

Apply v1 Rob's comments to all your patches.

Best regards,
Krzysztof
Re: [PATCH v2 02/15] dt-bindings: mfd: syscon: add microchip,sama7d65-sfrbu
Posted by Conor Dooley 12 months ago
On Tue, Feb 11, 2025 at 09:14:05AM +0100, Krzysztof Kozlowski wrote:
> On Mon, Feb 10, 2025 at 02:13:02PM -0700, Ryan.Wanner@microchip.com wrote:
> > From: Ryan Wanner <Ryan.Wanner@microchip.com>
> > 
> > Add SAMA7D65 SFRBU compatible string to DT bindings documentation
> > 
> > Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
> > ---
> >  Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> > index 51d896c88dafa..727292ffe092e 100644
> > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> > @@ -91,6 +91,7 @@ select:
> >            - microchip,mpfs-sysreg-scb
> >            - microchip,sam9x60-sfr
> >            - microchip,sama7d65-ddr3phy
> > +          - microchip,sama7d65-sfrbu
> 
> You got comment on #1 of your v1, so if you make exactly the same
> mistake in other patches then fix it there as well.
> 
> Apply v1 Rob's comments to all your patches.

Actually, this patch v1 did put it in both lists, but here it got
dropped from the second list:
https://lore.kernel.org/all/20250130233431.GB1868322-robh@kernel.org/
Re: [PATCH v2 02/15] dt-bindings: mfd: syscon: add microchip,sama7d65-sfrbu
Posted by Krzysztof Kozlowski 12 months ago
On 13/02/2025 21:30, Conor Dooley wrote:
>>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
>>> index 51d896c88dafa..727292ffe092e 100644
>>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>>> @@ -91,6 +91,7 @@ select:
>>>            - microchip,mpfs-sysreg-scb
>>>            - microchip,sam9x60-sfr
>>>            - microchip,sama7d65-ddr3phy
>>> +          - microchip,sama7d65-sfrbu
>>
>> You got comment on #1 of your v1, so if you make exactly the same
>> mistake in other patches then fix it there as well.
>>
>> Apply v1 Rob's comments to all your patches.
> 
> Actually, this patch v1 did put it in both lists, but here it got
> dropped from the second list:
> https://lore.kernel.org/all/20250130233431.GB1868322-robh@kernel.org/


That's even weirder...

Best regards,
Krzysztof