"include/asm-<arch>" was replaced by "arch/<arch>/include/asm" a long
time ago.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 9eed3683ad76caff..dbb9c3c6fe30f906 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2875,7 +2875,7 @@ sub process {
 
 			if ($realfile =~ m@^include/asm/@) {
 				ERROR("MODIFIED_INCLUDE_ASM",
-				      "do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
+				      "do not modify files in include/asm, change architecture specific files in arch/<architecture>/include/asm\n" . "$here$rawline\n");
 			}
 			$found_file = 1;
 		}
-- 
2.34.1

On Thu, 2024-12-05 at 14:20 +0100, Geert Uytterhoeven wrote:
> "include/asm-<arch>" was replaced by "arch/<arch>/include/asm" a long
> time ago.

Thanks.

> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 9eed3683ad76caff..dbb9c3c6fe30f906 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2875,7 +2875,7 @@ sub process {
>  
>  			if ($realfile =~ m@^include/asm/@) {
>  				ERROR("MODIFIED_INCLUDE_ASM",
> -				      "do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
> +				      "do not modify files in include/asm, change architecture specific files in arch/<architecture>/include/asm\n" . "$here$rawline\n");
>  			}
>  			$found_file = 1;
>  		}

On Fri, Dec 6, 2024 at 1:40 AM Joe Perches <joe@perches.com> wrote:
>
> On Thu, 2024-12-05 at 14:20 +0100, Geert Uytterhoeven wrote:
> > "include/asm-<arch>" was replaced by "arch/<arch>/include/asm" a long
> > time ago.
>
> Thanks.


Is this check still needed?

include/asm was a symlink to include/asm-<architecture> in the old days,
but it no longer exists.

In which case, is this check triggered?




-- 
Best Regards
Masahiro Yamada

Hi Yamada-san,

On Sat, Dec 7, 2024 at 3:31 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> On Fri, Dec 6, 2024 at 1:40 AM Joe Perches <joe@perches.com> wrote:
> > On Thu, 2024-12-05 at 14:20 +0100, Geert Uytterhoeven wrote:
> > > "include/asm-<arch>" was replaced by "arch/<arch>/include/asm" a long
> > > time ago.
>
> Is this check still needed?
>
> include/asm was a symlink to include/asm-<architecture> in the old days,
> but it no longer exists.
>
> In which case, is this check triggered?

Someone might still try to create a header file under include/asm/.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds