Fix read permissions for VPD attributes

[PATCH v1 0/2] Fix read permissions for VPD attributes

Posted by Leon Romanovsky 2 weeks, 2 days ago

From: Leon Romanovsky <leonro@nvidia.com>

Changelog:
v1: 
 * Changed implementation from open-read-to-everyone to be opt-in
 * Removed stable and Fixes tags, as it seems like feature now.
v0: https://lore.kernel.org/all/65791906154e3e5ea12ea49127cf7c707325ca56.1730102428.git.leonro@nvidia.com/

--------------------------------------------------------------------------
Hi,

The Vital Product Data (VPD) sysfs file is not readable by unprivileged
users. This limitation is not necessary and can be removed at least for
devices which are known as safe.

Thanks

Leon Romanovsky (2):
  PCI/sysfs: Change read permissions for VPD attributes
  net/mlx5: Enable unprivileged read of PCI VPD file

 drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 +
 drivers/pci/vpd.c                              | 9 ++++++++-
 include/linux/pci.h                            | 7 ++++++-
 3 files changed, 15 insertions(+), 2 deletions(-)

-- 
2.47.0

Re: [PATCH v1 0/2] Fix read permissions for VPD attributes

Posted by Leon Romanovsky 1 week, 5 days ago

On Thu, Nov 07, 2024 at 08:56:55PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
> 
> Changelog:
> v1: 
>  * Changed implementation from open-read-to-everyone to be opt-in
>  * Removed stable and Fixes tags, as it seems like feature now.
> v0: https://lore.kernel.org/all/65791906154e3e5ea12ea49127cf7c707325ca56.1730102428.git.leonro@nvidia.com/
> 
> --------------------------------------------------------------------------
> Hi,
> 
> The Vital Product Data (VPD) sysfs file is not readable by unprivileged
> users. This limitation is not necessary and can be removed at least for
> devices which are known as safe.
> 
> Thanks
> 
> Leon Romanovsky (2):
>   PCI/sysfs: Change read permissions for VPD attributes
>   net/mlx5: Enable unprivileged read of PCI VPD file
> 
>  drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 +
>  drivers/pci/vpd.c                              | 9 ++++++++-
>  include/linux/pci.h                            | 7 ++++++-
>  3 files changed, 15 insertions(+), 2 deletions(-)

Bjorn,

Does this version resolve your concerns about broken devices in the field?

Thanks

> 
> -- 
> 2.47.0
> 
>