[PATCH 0/2] timers test fix and duplicate defines cleanup

Shuah Khan posted 2 patches 2 months ago
tools/testing/selftests/timers/Makefile       |  2 +-
tools/testing/selftests/timers/adjtick.c      |  4 +--
.../selftests/timers/alarmtimer-suspend.c     |  2 +-
.../selftests/timers/inconsistency-check.c    |  2 +-
tools/testing/selftests/timers/leap-a-day.c   |  2 +-
tools/testing/selftests/timers/mqueue-lat.c   |  2 +-
tools/testing/selftests/timers/nanosleep.c    |  3 +--
tools/testing/selftests/timers/posix_timers.c | 27 ++++++++++---------
tools/testing/selftests/timers/raw_skew.c     |  2 +-
tools/testing/selftests/timers/set-2038.c     |  3 +--
.../testing/selftests/timers/set-timer-lat.c  |  3 +--
.../testing/selftests/timers/valid-adjtimex.c |  4 +--
12 files changed, 26 insertions(+), 30 deletions(-)
[PATCH 0/2] timers test fix and duplicate defines cleanup
Posted by Shuah Khan 2 months ago
The first patch in this two patch fixes warn_unused_result compile
time warning in posix_timers test.

The second patch removes local NSEC_PER_SEC and USEC_PER_SEC defines.
NSEC_PER_SEC and USEC_PER_SEC are defines in several timers tests.
These defines are inconsistent with variations of ULL, LL, etc. without
any explanation why it is necessary.

These defines can be picked up from include/vdso/time64.h header
file. In the interest of making it easier to maintain, remove the
local defines. Include include/vdso/time64.h instead. This change
will also make the defines consistent.

Shuah Khan (2):
  selftests:timers: posix_timers: Fix warn_unused_result in
    __fatal_error()
  selftests: timers: Remove local NSEC_PER_SEC and USEC_PER_SEC defines

 tools/testing/selftests/timers/Makefile       |  2 +-
 tools/testing/selftests/timers/adjtick.c      |  4 +--
 .../selftests/timers/alarmtimer-suspend.c     |  2 +-
 .../selftests/timers/inconsistency-check.c    |  2 +-
 tools/testing/selftests/timers/leap-a-day.c   |  2 +-
 tools/testing/selftests/timers/mqueue-lat.c   |  2 +-
 tools/testing/selftests/timers/nanosleep.c    |  3 +--
 tools/testing/selftests/timers/posix_timers.c | 27 ++++++++++---------
 tools/testing/selftests/timers/raw_skew.c     |  2 +-
 tools/testing/selftests/timers/set-2038.c     |  3 +--
 .../testing/selftests/timers/set-timer-lat.c  |  3 +--
 .../testing/selftests/timers/valid-adjtimex.c |  4 +--
 12 files changed, 26 insertions(+), 30 deletions(-)

-- 
2.40.1
Re: [PATCH 0/2] timers test fix and duplicate defines cleanup
Posted by Thomas Gleixner 2 months ago
On Tue, Sep 24 2024 at 09:56, Shuah Khan wrote:

> The first patch in this two patch fixes warn_unused_result compile
> time warning in posix_timers test.
>
> The second patch removes local NSEC_PER_SEC and USEC_PER_SEC defines.
> NSEC_PER_SEC and USEC_PER_SEC are defines in several timers tests.
> These defines are inconsistent with variations of ULL, LL, etc. without
> any explanation why it is necessary.
>
> These defines can be picked up from include/vdso/time64.h header
> file. In the interest of making it easier to maintain, remove the
> local defines. Include include/vdso/time64.h instead. This change
> will also make the defines consistent.

Acked-by: Thomas Gleixner <tglx@linutronix.de>