'struct regulator_desc' is not modified in this driver.

Constifying this structure moves some data to a read-only section, so
increase overall security, especially when the structure holds some
function pointers.

On a x86_64, with allmodconfig:
Before:
======
   text	   data	    bss	    dec	    hex	filename
   3906	   5808	     16	   9730	   2602	drivers/regulator/max77826-regulator.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
   9218	    496	     16	   9730	   2602	drivers/regulator/max77826-regulator.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
--
Compile tested only
---
 drivers/regulator/max77826-regulator.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/max77826-regulator.c b/drivers/regulator/max77826-regulator.c
index 5590cdf615b7..376e3110c695 100644
--- a/drivers/regulator/max77826-regulator.c
+++ b/drivers/regulator/max77826-regulator.c
@@ -153,7 +153,7 @@ enum max77826_regulators {
 
 struct max77826_regulator_info {
 	struct regmap *regmap;
-	struct regulator_desc *rdesc;
+	const struct regulator_desc *rdesc;
 };
 
 static const struct regmap_config max77826_regmap_config = {
@@ -187,7 +187,7 @@ static const struct regulator_ops max77826_buck_ops = {
 	.set_voltage_time_sel	= max77826_set_voltage_time_sel,
 };
 
-static struct regulator_desc max77826_regulators_desc[] = {
+static const struct regulator_desc max77826_regulators_desc[] = {
 	MAX77826_LDO(1, NMOS),
 	MAX77826_LDO(2, NMOS),
 	MAX77826_LDO(3, NMOS),
-- 
2.46.0

Reviewed-by: Iskren Chernev <iskren.chernev@gmail.com>

On Sun, Sep 8, 2024 at 2:41 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> 'struct regulator_desc' is not modified in this driver.
>
> Constifying this structure moves some data to a read-only section, so
> increase overall security, especially when the structure holds some
> function pointers.
>
> On a x86_64, with allmodconfig:
> Before:
> ======
>    text    data     bss     dec     hex filename
>    3906    5808      16    9730    2602 drivers/regulator/max77826-regulator.o
>
> After:
> =====
>    text    data     bss     dec     hex filename
>    9218     496      16    9730    2602 drivers/regulator/max77826-regulator.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> --
> Compile tested only
> ---
>  drivers/regulator/max77826-regulator.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/max77826-regulator.c b/drivers/regulator/max77826-regulator.c
> index 5590cdf615b7..376e3110c695 100644
> --- a/drivers/regulator/max77826-regulator.c
> +++ b/drivers/regulator/max77826-regulator.c
> @@ -153,7 +153,7 @@ enum max77826_regulators {
>
>  struct max77826_regulator_info {
>         struct regmap *regmap;
> -       struct regulator_desc *rdesc;
> +       const struct regulator_desc *rdesc;
>  };
>
>  static const struct regmap_config max77826_regmap_config = {
> @@ -187,7 +187,7 @@ static const struct regulator_ops max77826_buck_ops = {
>         .set_voltage_time_sel   = max77826_set_voltage_time_sel,
>  };
>
> -static struct regulator_desc max77826_regulators_desc[] = {
> +static const struct regulator_desc max77826_regulators_desc[] = {
>         MAX77826_LDO(1, NMOS),
>         MAX77826_LDO(2, NMOS),
>         MAX77826_LDO(3, NMOS),
> --
> 2.46.0
>