[v2] mfd: stm32-timers: Make register definition more flexible

[PATCH v2 0/5] mfd: stm32-timers: Make register definition more flexible

Posted by Uwe Kleine-König 1 year, 6 months ago

Hello,

(implicit) v1 is available at
https://lore.kernel.org/lkml/cover.1718352022.git.u.kleine-koenig@baylibre.com
.

Changes introduced here:

 - Split the patch removing TIM_DIER_CC_IE() and use appropriate subject
   prefixes. Lee and William didn't like the patch touching both
   include/linux/mfd/stm32-timers.h and
   drivers/counter/stm32-timer-cnt.c not having a hint to the counter
   subsystem (at least that's my interpretation of their feedback).
   Not mentioning mfd didn't seem to be considerably better in my eyes,
   so I split this patch.
 - Fix typo noticed by Thorsten.
 - Update subject prefix of the last patch to match what is usually done
   for pwm.

I have some further updates to the pwm-stm32 driver that will probably
go in before v6.10-rc1. They shouldn't conflict, still I'd prefer to let
the pwm patch go in via my tree as I might have some further changes for
that driver. So if this is merged using the mfd or counter tree, please
skip the pwm patch. A stable branch would be welcome in this case.

Best regards
Uwe


Uwe Kleine-König (5):
  mfd: stm32-timers: Unify alignment of register definition
  mfd: stm32-timers: Add some register definitions with a parameter
  counter: stm32-timer-cnt: Use TIM_DIER_CCxIE(x) instead of
    TIM_DIER_CCxIE(x)
  mfd: stm32-timers: Drop unused TIM_DIER_CC_IE
  pwm: stm32: Make use of parametrised register definitions

 drivers/counter/stm32-timer-cnt.c |   4 +-
 drivers/pwm/pwm-stm32.c           |  22 ++--
 include/linux/mfd/stm32-timers.h  | 179 ++++++++++++++++--------------
 3 files changed, 107 insertions(+), 98 deletions(-)

base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
-- 
2.43.0

Re: [PATCH v2 0/5] mfd: stm32-timers: Make register definition more flexible

Posted by Lee Jones 1 year, 5 months ago

On Wed, 19 Jun 2024, Uwe Kleine-König wrote:

> Hello,
> 
> (implicit) v1 is available at
> https://lore.kernel.org/lkml/cover.1718352022.git.u.kleine-koenig@baylibre.com
> .
> 
> Changes introduced here:
> 
>  - Split the patch removing TIM_DIER_CC_IE() and use appropriate subject
>    prefixes. Lee and William didn't like the patch touching both
>    include/linux/mfd/stm32-timers.h and
>    drivers/counter/stm32-timer-cnt.c not having a hint to the counter
>    subsystem (at least that's my interpretation of their feedback).
>    Not mentioning mfd didn't seem to be considerably better in my eyes,
>    so I split this patch.
>  - Fix typo noticed by Thorsten.
>  - Update subject prefix of the last patch to match what is usually done
>    for pwm.
> 
> I have some further updates to the pwm-stm32 driver that will probably
> go in before v6.10-rc1. They shouldn't conflict, still I'd prefer to let
> the pwm patch go in via my tree as I might have some further changes for
> that driver. So if this is merged using the mfd or counter tree, please
> skip the pwm patch. A stable branch would be welcome in this case.
> 
> Best regards
> Uwe
> 
> 
> Uwe Kleine-König (5):
>   mfd: stm32-timers: Unify alignment of register definition
>   mfd: stm32-timers: Add some register definitions with a parameter
>   counter: stm32-timer-cnt: Use TIM_DIER_CCxIE(x) instead of
>     TIM_DIER_CCxIE(x)
>   mfd: stm32-timers: Drop unused TIM_DIER_CC_IE
>   pwm: stm32: Make use of parametrised register definitions
> 
>  drivers/counter/stm32-timer-cnt.c |   4 +-
>  drivers/pwm/pwm-stm32.c           |  22 ++--
>  include/linux/mfd/stm32-timers.h  | 179 ++++++++++++++++--------------
>  3 files changed, 107 insertions(+), 98 deletions(-)
> 
> base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0

Applied patches 1-4 and submitted for build testing.

If all is good, I'll sent out a PR for William.

Note to self: ib-mfd-counter-5.11

-- 
Lee Jones [李琼斯]

[GIT PULL] Immutable branch between MFD and Counter due for the v5.11 merge window

Posted by Lee Jones 1 year, 5 months ago

Enjoy!

The following changes since commit 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0:

  Linux 6.10-rc1 (2024-05-26 15:20:12 -0700)

are available in the Git repository at:

  ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git tags/ib-mfd-counter-v5.11

for you to fetch changes up to 304d02aa711369da89b4f8c01702bf1b5d1f7abc:

  mfd: stm32-timers: Drop unused TIM_DIER_CC_IE (2024-06-26 16:09:58 +0100)

----------------------------------------------------------------
Immutable branch between MFD and Counter due for the v5.11 merge window

----------------------------------------------------------------
Uwe Kleine-König (4):
      mfd: stm32-timers: Unify alignment of register definition
      mfd: stm32-timers: Add some register definitions with a parameter
      counter: stm32-timer-cnt: Use TIM_DIER_CCxIE(x) instead of TIM_DIER_CCxIE(x)
      mfd: stm32-timers: Drop unused TIM_DIER_CC_IE

 drivers/counter/stm32-timer-cnt.c |   4 +-
 include/linux/mfd/stm32-timers.h  | 179 ++++++++++++++++++++------------------
 2 files changed, 96 insertions(+), 87 deletions(-)

-- 
Lee Jones [李琼斯]

Re: [GIT PULL] Immutable branch between MFD and Counter due for the v5.11 merge window

Posted by William Breathitt Gray 1 year, 5 months ago

On Fri, Jun 28, 2024 at 03:28:47PM +0100, Lee Jones wrote:
> Enjoy!
> 
> The following changes since commit 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0:
> 
>   Linux 6.10-rc1 (2024-05-26 15:20:12 -0700)
> 
> are available in the Git repository at:
> 
>   ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git tags/ib-mfd-counter-v5.11
> 
> for you to fetch changes up to 304d02aa711369da89b4f8c01702bf1b5d1f7abc:
> 
>   mfd: stm32-timers: Drop unused TIM_DIER_CC_IE (2024-06-26 16:09:58 +0100)
> 
> ----------------------------------------------------------------
> Immutable branch between MFD and Counter due for the v5.11 merge window
> 
> ----------------------------------------------------------------
> Uwe Kleine-König (4):
>       mfd: stm32-timers: Unify alignment of register definition
>       mfd: stm32-timers: Add some register definitions with a parameter
>       counter: stm32-timer-cnt: Use TIM_DIER_CCxIE(x) instead of TIM_DIER_CCxIE(x)
>       mfd: stm32-timers: Drop unused TIM_DIER_CC_IE
> 
>  drivers/counter/stm32-timer-cnt.c |   4 +-
>  include/linux/mfd/stm32-timers.h  | 179 ++++++++++++++++++++------------------
>  2 files changed, 96 insertions(+), 87 deletions(-)
> 
> -- 
> Lee Jones [李琼斯]

Merged and pushed out to counter-next.

Thanks,

William Breathitt Gray

Re: [GIT PULL] Immutable branch between MFD and Counter due for the v5.11 merge window

Posted by Uwe Kleine-König 1 year, 5 months ago

Hi Lee,

On Fri, Jun 28, 2024 at 03:28:47PM +0100, Lee Jones wrote:
> The following changes since commit 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0:
> 
>   Linux 6.10-rc1 (2024-05-26 15:20:12 -0700)
> 
> are available in the Git repository at:
> 
>   ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git tags/ib-mfd-counter-v5.11
> 
> for you to fetch changes up to 304d02aa711369da89b4f8c01702bf1b5d1f7abc:
> 
>   mfd: stm32-timers: Drop unused TIM_DIER_CC_IE (2024-06-26 16:09:58 +0100)

Thanks, merged into pwm/for-next!

Best regards
Uwe