[PATCH v2 0/4] KCOV fixes

Dmitry Vyukov posted 4 patches 1 year, 8 months ago
arch/x86/include/asm/hardirq.h  |  8 ++++++--
arch/x86/include/asm/idtentry.h |  6 +++---
arch/x86/kernel/Makefile        |  8 ++++++++
kernel/kcov.c                   | 31 +++++++++++++++++++++++++++++++
kernel/module/Makefile          |  2 +-
lib/Kconfig.debug               |  8 ++++++++
6 files changed, 57 insertions(+), 6 deletions(-)
[PATCH v2 0/4] KCOV fixes
Posted by Dmitry Vyukov 1 year, 8 months ago
Fix spurious KCOV coverage from interrupts and add a test.
Ignore some additional files that lead to large amounts
of uninteresting coverage.
As a reference point, tracing a simple open system call
produces ~10K PCs with these changes instead of ~45K PCs.

Dmitry Vyukov (4):
  x86/entry: Remove unwanted instrumentation in common_interrupt()
  kcov: add interrupt handling self test
  module: Fix KCOV-ignored file name
  x86: Ignore stack unwinding in KCOV

 arch/x86/include/asm/hardirq.h  |  8 ++++++--
 arch/x86/include/asm/idtentry.h |  6 +++---
 arch/x86/kernel/Makefile        |  8 ++++++++
 kernel/kcov.c                   | 31 +++++++++++++++++++++++++++++++
 kernel/module/Makefile          |  2 +-
 lib/Kconfig.debug               |  8 ++++++++
 6 files changed, 57 insertions(+), 6 deletions(-)


base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
-- 
2.45.2.505.gda0bf45e8d-goog
Re: [PATCH v2 0/4] KCOV fixes
Posted by Dmitry Vyukov 1 year, 8 months ago
On Tue, 11 Jun 2024 at 09:50, Dmitry Vyukov <dvyukov@google.com> wrote:
>
> Fix spurious KCOV coverage from interrupts and add a test.
> Ignore some additional files that lead to large amounts
> of uninteresting coverage.
> As a reference point, tracing a simple open system call
> produces ~10K PCs with these changes instead of ~45K PCs.
>
> Dmitry Vyukov (4):
>   x86/entry: Remove unwanted instrumentation in common_interrupt()
>   kcov: add interrupt handling self test
>   module: Fix KCOV-ignored file name
>   x86: Ignore stack unwinding in KCOV
>
>  arch/x86/include/asm/hardirq.h  |  8 ++++++--
>  arch/x86/include/asm/idtentry.h |  6 +++---
>  arch/x86/kernel/Makefile        |  8 ++++++++
>  kernel/kcov.c                   | 31 +++++++++++++++++++++++++++++++
>  kernel/module/Makefile          |  2 +-
>  lib/Kconfig.debug               |  8 ++++++++
>  6 files changed, 57 insertions(+), 6 deletions(-)
>
>
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> --
> 2.45.2.505.gda0bf45e8d-goog

Thomas, Ingo, Borislav, Dave,

Can you take this via x86 tree please?
Re: [PATCH v2 0/4] KCOV fixes
Posted by Dmitry Vyukov 1 year, 7 months ago
On Tue, 11 Jun 2024 at 11:31, Dmitry Vyukov <dvyukov@google.com> wrote:
> > Fix spurious KCOV coverage from interrupts and add a test.
> > Ignore some additional files that lead to large amounts
> > of uninteresting coverage.
> > As a reference point, tracing a simple open system call
> > produces ~10K PCs with these changes instead of ~45K PCs.
> >
> > Dmitry Vyukov (4):
> >   x86/entry: Remove unwanted instrumentation in common_interrupt()
> >   kcov: add interrupt handling self test
> >   module: Fix KCOV-ignored file name
> >   x86: Ignore stack unwinding in KCOV
> >
> >  arch/x86/include/asm/hardirq.h  |  8 ++++++--
> >  arch/x86/include/asm/idtentry.h |  6 +++---
> >  arch/x86/kernel/Makefile        |  8 ++++++++
> >  kernel/kcov.c                   | 31 +++++++++++++++++++++++++++++++
> >  kernel/module/Makefile          |  2 +-
> >  lib/Kconfig.debug               |  8 ++++++++
> >  6 files changed, 57 insertions(+), 6 deletions(-)
> >
> >
> > base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> > --
> > 2.45.2.505.gda0bf45e8d-goog
>
> Thomas, Ingo, Borislav, Dave,
>
> Can you take this via x86 tree please?

Or is it OK to take this via mm tree (where KCOV changes usually go)?
Re: [PATCH v2 0/4] KCOV fixes
Posted by Borislav Petkov 1 year, 7 months ago
On Wed, Jun 19, 2024 at 07:20:56AM +0200, Dmitry Vyukov wrote:
> Or is it OK to take this via mm tree (where KCOV changes usually go)?

Be patient, pls, you're on the TODO list.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
Re: [PATCH v2 0/4] KCOV fixes
Posted by Andrey Konovalov 1 year, 6 months ago
On Wed, Jun 19, 2024 at 10:31 AM Borislav Petkov <bp@alien8.de> wrote:
>
> On Wed, Jun 19, 2024 at 07:20:56AM +0200, Dmitry Vyukov wrote:
> > Or is it OK to take this via mm tree (where KCOV changes usually go)?
>
> Be patient, pls, you're on the TODO list.

Hi Borislav,

I was wondering what's the status of these patches? They didn't make
it into 6.11 and I also still don't see them in linux-next.

Thank you!
Re: [PATCH v2 0/4] KCOV fixes
Posted by Thomas Gleixner 1 year, 6 months ago
On Mon, Aug 05 2024 at 14:52, Andrey Konovalov wrote:
> On Wed, Jun 19, 2024 at 10:31 AM Borislav Petkov <bp@alien8.de> wrote:
>>
>> On Wed, Jun 19, 2024 at 07:20:56AM +0200, Dmitry Vyukov wrote:
>> > Or is it OK to take this via mm tree (where KCOV changes usually go)?
>>
>> Be patient, pls, you're on the TODO list.
>
> Hi Borislav,
>
> I was wondering what's the status of these patches? They didn't make
> it into 6.11 and I also still don't see them in linux-next.

Sorry. That fell through the cracks. I'm picking it up now.