[PATCH v3 4/4] selftests/resctrl: Enable MBA/MBA tests on AMD

Babu Moger posted 4 patches 1 year, 6 months ago
[PATCH v3 4/4] selftests/resctrl: Enable MBA/MBA tests on AMD
Posted by Babu Moger 1 year, 6 months ago
Enable MBA/MBM tests if UMC (Unified Memory Controller) support is
available on the system. Tests will be skipped otherwise.

Signed-off-by: Babu Moger <babu.moger@amd.com>
---
v3: Separated fix as another patch.
    https://lore.kernel.org/lkml/3a6c9dd9dc6bda6e2582db049bfe853cd836139f.1717622080.git.babu.moger@amd.com/

v2: No changes.
---
 tools/testing/selftests/resctrl/mba_test.c | 1 -
 tools/testing/selftests/resctrl/mbm_test.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/tools/testing/selftests/resctrl/mba_test.c b/tools/testing/selftests/resctrl/mba_test.c
index 394bbfd8a93e..5702bb1d6a98 100644
--- a/tools/testing/selftests/resctrl/mba_test.c
+++ b/tools/testing/selftests/resctrl/mba_test.c
@@ -192,7 +192,6 @@ static bool mba_feature_check(const struct resctrl_test *test)
 struct resctrl_test mba_test = {
 	.name = "MBA",
 	.resource = "MB",
-	.vendor_specific = ARCH_INTEL,
 	.feature_check = mba_feature_check,
 	.run_test = mba_run_test,
 	.cleanup = mba_test_cleanup,
diff --git a/tools/testing/selftests/resctrl/mbm_test.c b/tools/testing/selftests/resctrl/mbm_test.c
index 9b6f7f162282..dbdb1b490df8 100644
--- a/tools/testing/selftests/resctrl/mbm_test.c
+++ b/tools/testing/selftests/resctrl/mbm_test.c
@@ -162,7 +162,6 @@ static bool mbm_feature_check(const struct resctrl_test *test)
 struct resctrl_test mbm_test = {
 	.name = "MBM",
 	.resource = "MB",
-	.vendor_specific = ARCH_INTEL,
 	.feature_check = mbm_feature_check,
 	.run_test = mbm_run_test,
 	.cleanup = mbm_test_cleanup,
-- 
2.34.1
Re: [PATCH v3 4/4] selftests/resctrl: Enable MBA/MBA tests on AMD
Posted by Reinette Chatre 1 year, 6 months ago
Hi Babu,

On 6/5/24 3:45 PM, Babu Moger wrote:
> Enable MBA/MBM tests if UMC (Unified Memory Controller) support is
> available on the system. Tests will be skipped otherwise.

Could you please point out where the test is skipped if UMC is
not available?

Reinette
Re: [PATCH v3 4/4] selftests/resctrl: Enable MBA/MBA tests on AMD
Posted by Moger, Babu 1 year, 6 months ago
Hi Reinette,

On 6/14/24 13:39, Reinette Chatre wrote:
> Hi Babu,
> 
> On 6/5/24 3:45 PM, Babu Moger wrote:
>> Enable MBA/MBM tests if UMC (Unified Memory Controller) support is
>> available on the system. Tests will be skipped otherwise.
> 
> Could you please point out where the test is skipped if UMC is
> not available?

My bad. It is not skipped. It will report as failed in UMC is not
detected. I will update the commit message.

-- 
Thanks
Babu Moger